All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/openjdk: needs host gcc >= 4.9
@ 2021-09-11 21:40 Fabrice Fontaine
  2021-09-12  7:39 ` Yann E. MORIN
  2021-09-13 18:06 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-09-11 21:40 UTC (permalink / raw)
  To: buildroot; +Cc: Tudor Holton, Fabrice Fontaine

openjdk needs host gcc >= 4.9 since bump to version 16.0.1+9 in commit
057e27029c9811ba8cc4922e30cc3878bed98807 and
https://github.com/openjdk/jdk/commit/2a8f92e7e71f7c1ed4010fa31f4b413758c8752a:

configure: Using gcc BuildC compiler version 4.8.5 [cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)]
configure: Using gcc BuildC++ compiler version 4.8.5 [g++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)]
configure: Using gcc build linker version 2.27 [GNU ld version 2.27-44.base.el7]

[...]

g++: error: unrecognized command line option '-std=c++14'

Add this new dependency to all openjdk versions including version 11 as
most of the users will have host gcc >= 4.9

Fixes:
 - http://autobuild.buildroot.org/results/7072308d148ccb8237180729551df65c87a76f11

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/openjdk/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/openjdk/Config.in b/package/openjdk/Config.in
index f2b7f5ffd7..cee361ec6f 100644
--- a/package/openjdk/Config.in
+++ b/package/openjdk/Config.in
@@ -20,7 +20,8 @@ config BR2_PACKAGE_OPENJDK
 	depends on !BR2_STATIC_LIBS # glibc
 	depends on BR2_INSTALL_LIBSTDCPP # cups
 	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib, cups, libusb
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
+	depends on BR2_HOST_GCC_AT_LEAST_4_9 # C++14
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_USE_MMU # cups
 	depends on BR2_PACKAGE_XORG7
@@ -152,13 +153,14 @@ comment "openjdk needs X.Org"
 	depends on BR2_USE_MMU
 	depends on !BR2_PACKAGE_XORG7
 
-comment "openjdk needs glibc, and a toolchain w/ wchar, dynamic library, threads, C++, gcc >= 4.9"
+comment "openjdk needs glibc, and a toolchain w/ wchar, dynamic library, threads, C++, host gcc >= 4.9, gcc >= 4.9"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_OPENJDK_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_HOST_GCC_AT_LEAST_4_9 || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 
 comment "openjdk does not support soft float configurations"
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/openjdk: needs host gcc >= 4.9
  2021-09-11 21:40 [Buildroot] [PATCH 1/1] package/openjdk: needs host gcc >= 4.9 Fabrice Fontaine
@ 2021-09-12  7:39 ` Yann E. MORIN
  2021-09-13 18:06 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-09-12  7:39 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Tudor Holton, buildroot

Fabrice, All,

On 2021-09-11 23:40 +0200, Fabrice Fontaine spake thusly:
> openjdk needs host gcc >= 4.9 since bump to version 16.0.1+9 in commit
> 057e27029c9811ba8cc4922e30cc3878bed98807 and
> https://github.com/openjdk/jdk/commit/2a8f92e7e71f7c1ed4010fa31f4b413758c8752a:
> 
> configure: Using gcc BuildC compiler version 4.8.5 [cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)]
> configure: Using gcc BuildC++ compiler version 4.8.5 [g++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)]
> configure: Using gcc build linker version 2.27 [GNU ld version 2.27-44.base.el7]
> 
> [...]
> 
> g++: error: unrecognized command line option '-std=c++14'
> 
> Add this new dependency to all openjdk versions including version 11 as
> most of the users will have host gcc >= 4.9

Actually, I think that users that are stuck on using OpenJDK 11 are
those big enterprise players, who will also have stringent requirements
on their build environment, and are thus stuck with years old distro,
like those RHEL-7 that Matt is running on his autobuilder.

So, I think we should just limit the dependency on host gcc-4.9 to
OpenJDK 16.

Applied to master with that fixed, thanks.

Regards,
Yann E. MORIN.

> Fixes:
>  - http://autobuild.buildroot.org/results/7072308d148ccb8237180729551df65c87a76f11
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/openjdk/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/openjdk/Config.in b/package/openjdk/Config.in
> index f2b7f5ffd7..cee361ec6f 100644
> --- a/package/openjdk/Config.in
> +++ b/package/openjdk/Config.in
> @@ -20,7 +20,8 @@ config BR2_PACKAGE_OPENJDK
>  	depends on !BR2_STATIC_LIBS # glibc
>  	depends on BR2_INSTALL_LIBSTDCPP # cups
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib, cups, libusb
> -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
> +	depends on BR2_HOST_GCC_AT_LEAST_4_9 # C++14
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
>  	depends on BR2_TOOLCHAIN_USES_GLIBC
>  	depends on BR2_USE_MMU # cups
>  	depends on BR2_PACKAGE_XORG7
> @@ -152,13 +153,14 @@ comment "openjdk needs X.Org"
>  	depends on BR2_USE_MMU
>  	depends on !BR2_PACKAGE_XORG7
>  
> -comment "openjdk needs glibc, and a toolchain w/ wchar, dynamic library, threads, C++, gcc >= 4.9"
> +comment "openjdk needs glibc, and a toolchain w/ wchar, dynamic library, threads, C++, host gcc >= 4.9, gcc >= 4.9"
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_OPENJDK_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
>  	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP || \
>  		!BR2_TOOLCHAIN_HAS_THREADS || \
>  		!BR2_TOOLCHAIN_USES_GLIBC || \
> +		!BR2_HOST_GCC_AT_LEAST_4_9 || \
>  		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>  
>  comment "openjdk does not support soft float configurations"
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/openjdk: needs host gcc >= 4.9
  2021-09-11 21:40 [Buildroot] [PATCH 1/1] package/openjdk: needs host gcc >= 4.9 Fabrice Fontaine
  2021-09-12  7:39 ` Yann E. MORIN
@ 2021-09-13 18:06 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-09-13 18:06 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Tudor Holton, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > openjdk needs host gcc >= 4.9 since bump to version 16.0.1+9 in commit
 > 057e27029c9811ba8cc4922e30cc3878bed98807 and
 > https://github.com/openjdk/jdk/commit/2a8f92e7e71f7c1ed4010fa31f4b413758c8752a:

 > configure: Using gcc BuildC compiler version 4.8.5 [cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)]
 > configure: Using gcc BuildC++ compiler version 4.8.5 [g++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)]
 > configure: Using gcc build linker version 2.27 [GNU ld version 2.27-44.base.el7]

 > [...]

 > g++: error: unrecognized command line option '-std=c++14'

 > Add this new dependency to all openjdk versions including version 11 as
 > most of the users will have host gcc >= 4.9

 > Fixes:
 >  - http://autobuild.buildroot.org/results/7072308d148ccb8237180729551df65c87a76f11

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.05.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-14 18:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11 21:40 [Buildroot] [PATCH 1/1] package/openjdk: needs host gcc >= 4.9 Fabrice Fontaine
2021-09-12  7:39 ` Yann E. MORIN
2021-09-13 18:06 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.