From: Jonathan Cameron <jic23@kernel.org> To: Cai Huoqing <caihuoqing@baidu.com> Cc: <lars@metafoo.de>, <robh+dt@kernel.org>, <shawnguo@kernel.org>, <s.hauer@pengutronix.de>, <kernel@pengutronix.de>, <festevam@gmail.com>, <linux-imx@nxp.com>, <aardelean@deviqon.com>, <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 2/3] dt-bindings: iio: adc: Add binding documentation for NXP IMX8QXP ADC Date: Sun, 12 Sep 2021 17:45:44 +0100 [thread overview] Message-ID: <20210912174544.285b40bd@jic23-huawei> (raw) In-Reply-To: <20210912071334.1745-3-caihuoqing@baidu.com> On Sun, 12 Sep 2021 15:13:33 +0800 Cai Huoqing <caihuoqing@baidu.com> wrote: > The NXP i.MX 8QuadXPlus SOC a new ADC IP, so add > binding documentation for NXP IMX8QXP ADC > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > v1->v2: *Fix some indentation issues. > *Mark status as okay. > *Change clock2 source. > v3->v4: *Remove 'status' from examples. > *Remove unused 'state'. > *Remove interrupts-parent. > *Change num of address/size-cells from 1 to 2. > v1 link: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830172140.414-5-caihuoqing@baidu.com/ > v3 link: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210907015724.1377-3-caihuoqing@baidu.com/ > > .../bindings/iio/adc/nxp,imx8qxp-adc.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > new file mode 100644 > index 000000000000..8e16adf9a28a > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/nxp,imx8qxp-adc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP IMX8QXP ADC bindings > + > +maintainers: > + - Cai Huoqing <caihuoqing@baidu.com> > + > +description: > + Supports the ADC found on the IMX8QXP SoC. > + > +properties: > + compatible: > + const: nxp,imx8qxp-adc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: per > + - const: ipg > + > + assigned-clocks: > + maxItems: 1 > + > + assigned-clock-rates: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + '#address-cells': > + const: 2 > + > + '#size-cells': > + const: 2 > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - assigned-clocks > + - assigned-clock-rates > + - power-domains > + - '#address-cells' > + - '#size-cells' > + - "#io-channel-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/firmware/imx/rsrc.h> > + soc { > + #address-cells = <2>; > + #size-cells = <2>; These indeed need to be here so we know what form reg for child nodes takes, but... > + adc@5a880000 { > + #address-cells = <2>; > + #size-cells = <2>; Why are these required properties? There aren't any child nodes defined in this binding so I don't think they are used. > + compatible = "nxp,imx8qxp-adc"; > + reg = <0x0 0x5a880000 0x0 0x10000>; > + interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk IMX_SC_R_ADC_0>, > + <&clk IMX_SC_R_ADC_0>; > + clock-names = "per", "ipg"; > + assigned-clocks = <&clk IMX_SC_R_ADC_0>; > + assigned-clock-rates = <24000000>; > + power-domains = <&pd IMX_SC_R_ADC_0>; > + #io-channel-cells = <1>; > + }; > + }; > +...
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Cai Huoqing <caihuoqing@baidu.com> Cc: <lars@metafoo.de>, <robh+dt@kernel.org>, <shawnguo@kernel.org>, <s.hauer@pengutronix.de>, <kernel@pengutronix.de>, <festevam@gmail.com>, <linux-imx@nxp.com>, <aardelean@deviqon.com>, <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 2/3] dt-bindings: iio: adc: Add binding documentation for NXP IMX8QXP ADC Date: Sun, 12 Sep 2021 17:45:44 +0100 [thread overview] Message-ID: <20210912174544.285b40bd@jic23-huawei> (raw) In-Reply-To: <20210912071334.1745-3-caihuoqing@baidu.com> On Sun, 12 Sep 2021 15:13:33 +0800 Cai Huoqing <caihuoqing@baidu.com> wrote: > The NXP i.MX 8QuadXPlus SOC a new ADC IP, so add > binding documentation for NXP IMX8QXP ADC > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > v1->v2: *Fix some indentation issues. > *Mark status as okay. > *Change clock2 source. > v3->v4: *Remove 'status' from examples. > *Remove unused 'state'. > *Remove interrupts-parent. > *Change num of address/size-cells from 1 to 2. > v1 link: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830172140.414-5-caihuoqing@baidu.com/ > v3 link: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210907015724.1377-3-caihuoqing@baidu.com/ > > .../bindings/iio/adc/nxp,imx8qxp-adc.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > new file mode 100644 > index 000000000000..8e16adf9a28a > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/nxp,imx8qxp-adc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP IMX8QXP ADC bindings > + > +maintainers: > + - Cai Huoqing <caihuoqing@baidu.com> > + > +description: > + Supports the ADC found on the IMX8QXP SoC. > + > +properties: > + compatible: > + const: nxp,imx8qxp-adc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: per > + - const: ipg > + > + assigned-clocks: > + maxItems: 1 > + > + assigned-clock-rates: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + '#address-cells': > + const: 2 > + > + '#size-cells': > + const: 2 > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - assigned-clocks > + - assigned-clock-rates > + - power-domains > + - '#address-cells' > + - '#size-cells' > + - "#io-channel-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/firmware/imx/rsrc.h> > + soc { > + #address-cells = <2>; > + #size-cells = <2>; These indeed need to be here so we know what form reg for child nodes takes, but... > + adc@5a880000 { > + #address-cells = <2>; > + #size-cells = <2>; Why are these required properties? There aren't any child nodes defined in this binding so I don't think they are used. > + compatible = "nxp,imx8qxp-adc"; > + reg = <0x0 0x5a880000 0x0 0x10000>; > + interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk IMX_SC_R_ADC_0>, > + <&clk IMX_SC_R_ADC_0>; > + clock-names = "per", "ipg"; > + assigned-clocks = <&clk IMX_SC_R_ADC_0>; > + assigned-clock-rates = <24000000>; > + power-domains = <&pd IMX_SC_R_ADC_0>; > + #io-channel-cells = <1>; > + }; > + }; > +... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-12 16:42 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-12 7:13 [PATCH v4 0/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC Cai Huoqing 2021-09-12 7:13 ` Cai Huoqing 2021-09-12 7:13 ` [PATCH v4 1/3] iio: imx8qxp-adc: Add binding documentation " Cai Huoqing 2021-09-12 7:13 ` Cai Huoqing 2021-09-12 16:59 ` Jonathan Cameron 2021-09-12 16:59 ` Jonathan Cameron 2021-09-13 6:35 ` Alexandru Ardelean 2021-09-13 6:35 ` Alexandru Ardelean 2021-09-12 7:13 ` [PATCH v4 2/3] dt-bindings: iio: adc: " Cai Huoqing 2021-09-12 7:13 ` Cai Huoqing 2021-09-12 16:45 ` Jonathan Cameron [this message] 2021-09-12 16:45 ` Jonathan Cameron 2021-09-12 7:13 ` [PATCH v4 3/3] MAINTAINERS: Add the driver info of the " Cai Huoqing 2021-09-12 7:13 ` Cai Huoqing
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210912174544.285b40bd@jic23-huawei \ --to=jic23@kernel.org \ --cc=aardelean@deviqon.com \ --cc=caihuoqing@baidu.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.