Re: [PATCH v3 2/2] hwmon: (nct6775) Support access via Asus WMI

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]

Hi Denis,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hwmon/hwmon-next]
[also build test ERROR on v5.14 next-20210910]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Denis-Pauk/hwmon-nct6775-Support-access-via-Asus-WMI/20210912-190749
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: ia64-randconfig-r024-20210912 (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5b6bc5cd3f9d089d5a31a391a7cd61350fffc073
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Denis-Pauk/hwmon-nct6775-Support-access-via-Asus-WMI/20210912-190749
        git checkout 5b6bc5cd3f9d089d5a31a391a7cd61350fffc073
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/hwmon/nct6775.c: In function 'asuswmi_evaluate_method':
>> drivers/hwmon/nct6775.c:168:18: error: implicit declaration of function 'wmi_evaluate_method'; did you mean 'wmidev_evaluate_method'? [-Werror=implicit-function-declaration]
     168 |         status = wmi_evaluate_method(ASUSWMI_MGMT2_GUID, 0, method_id,
         |                  ^~~~~~~~~~~~~~~~~~~
         |                  wmidev_evaluate_method
   cc1: some warnings being treated as errors


vim +168 drivers/hwmon/nct6775.c

   158	
   159	static int asuswmi_evaluate_method(u32 method_id, u8 bank, u8 reg, u8 val, u32 *retval)
   160	{
   161		u32 args = bank | (reg << 8) | (val << 16);
   162		struct acpi_buffer input = { (acpi_size) sizeof(args), &args };
   163		struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
   164		acpi_status status;
   165		union acpi_object *obj;
   166		u32 tmp = 0;
   167	
 > 168		status = wmi_evaluate_method(ASUSWMI_MGMT2_GUID, 0, method_id,
   169					     &input, &output);
   170	
   171		if (ACPI_FAILURE(status))
   172			return -EIO;
   173	
   174		obj = output.pointer;
   175		if (obj && obj->type == ACPI_TYPE_INTEGER)
   176			tmp = obj->integer.value;
   177	
   178		if (retval)
   179			*retval = tmp;
   180	
   181		kfree(obj);
   182	
   183		if (tmp == ASUSWMI_UNSUPPORTED_METHOD)
   184			return -ENODEV;
   185		return 0;
   186	}
   187	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26292 bytes --]