All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Denis Pauk <pauk.denis@gmail.com>
Cc: "Bernhard Seibold" <mail@bernhard-seibold.de>,
	"Pär Ekholm" <pehlm@pekholm.org>,
	to.eivind@gmail.com, "Artem S . Tashkinov" <aros@gmx.com>,
	"Vittorio Roberto Alfieri" <me@rebtoor.com>,
	"Sahan Fernando" <sahan.h.fernando@gmail.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Jean Delvare" <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] hwmon: (nct6775) Support access via Asus WMI
Date: Sun, 12 Sep 2021 18:14:23 +0300	[thread overview]
Message-ID: <YT4ZT18e1NtM4T5C@smile.fi.intel.com> (raw)
In-Reply-To: <20210912110557.41346-1-pauk.denis@gmail.com>

On Sun, Sep 12, 2021 at 02:05:55PM +0300, Denis Pauk wrote:
> Support accessing the NCT677x via Asus WMI functions.
> 
> On mainboards that support this way of accessing the chip,
> the driver will usually not work without this option since
> in these mainboards, ACPI will mark the I/O port as used.
> 
> @Andy Shevchenko, I have left type of sioreg, in other places
> sioreg has same integer type, should I change all occurrences
> of usage?
> @Guenter Roeck, I have left nct6775_*_set_back() call without
> changes as its always called from platform specific callbacks.
> 
> Could you please review?
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
> Co-developed-by: Bernhard Seibold <mail@bernhard-seibold.de>
> Signed-off-by: Bernhard Seibold <mail@bernhard-seibold.de>
> Tested-by: Pär Ekholm <pehlm@pekholm.org>
> Tested-by: <to.eivind@gmail.com>
> Tested-by: Artem S. Tashkinov <aros@gmx.com>
> Tested-by: Vittorio Roberto Alfieri <me@rebtoor.com>
> Tested-by: Sahan Fernando <sahan.h.fernando@gmail.com>

This should go to the actual patch that makes it work (preparatory patches may
or may not have all above be listed).

As kbuild bot rightfully noted, the series has to be bisectable.

Compile time bisectability means: each patch should compile incrementally.
And run-time bisectability means: the device should work with each patch
applied incrementally.

I.o.w. you have to compile and boot kernel as many times as patches in your
series + 1 (the clean build of the base).

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2021-09-12 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 11:05 [PATCH v3 0/2] hwmon: (nct6775) Support access via Asus WMI Denis Pauk
2021-09-12 11:05 ` [PATCH v3 1/2] hwmon: (nct6775) Use sio_data in superio_*() Denis Pauk
2021-09-12 14:50   ` kernel test robot
2021-09-12 14:50     ` kernel test robot
2021-09-12 11:05 ` [PATCH v3 2/2] hwmon: (nct6775) Support access via Asus WMI Denis Pauk
2021-09-12 12:47   ` kernel test robot
2021-09-12 15:14 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YT4ZT18e1NtM4T5C@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=aros@gmx.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mail@bernhard-seibold.de \
    --cc=me@rebtoor.com \
    --cc=pauk.denis@gmail.com \
    --cc=pehlm@pekholm.org \
    --cc=sahan.h.fernando@gmail.com \
    --cc=to.eivind@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.