From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Mark Greer <mgreer@animalcreek.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [linux-nfc] [PATCH v2 14/15] nfc: microread: drop unneeded memory allocation fail messages
Date: Mon, 13 Sep 2021 15:20:34 +0200 [thread overview]
Message-ID: <20210913132035.242870-15-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210913132035.242870-1-krzysztof.kozlowski@canonical.com>
nfc_mei_phy_alloc() already prints an error message on memory allocation
failure.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/nfc/microread/mei.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index 686be3381727..e2a77a5fc887 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -24,10 +24,8 @@ static int microread_mei_probe(struct mei_cl_device *cldev,
int r;
phy = nfc_mei_phy_alloc(cldev);
- if (!phy) {
- pr_err("Cannot allocate memory for microread mei phy.\n");
+ if (!phy)
return -ENOMEM;
- }
r = microread_probe(phy, &mei_phy_ops, LLC_NOP_NAME,
MEI_NFC_HEADER_SIZE, 0, MEI_NFC_MAX_HCI_PAYLOAD,
--
2.30.2
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Mark Greer <mgreer@animalcreek.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH v2 14/15] nfc: microread: drop unneeded memory allocation fail messages
Date: Mon, 13 Sep 2021 15:20:34 +0200 [thread overview]
Message-ID: <20210913132035.242870-15-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210913132035.242870-1-krzysztof.kozlowski@canonical.com>
nfc_mei_phy_alloc() already prints an error message on memory allocation
failure.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/nfc/microread/mei.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index 686be3381727..e2a77a5fc887 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -24,10 +24,8 @@ static int microread_mei_probe(struct mei_cl_device *cldev,
int r;
phy = nfc_mei_phy_alloc(cldev);
- if (!phy) {
- pr_err("Cannot allocate memory for microread mei phy.\n");
+ if (!phy)
return -ENOMEM;
- }
r = microread_probe(phy, &mei_phy_ops, LLC_NOP_NAME,
MEI_NFC_HEADER_SIZE, 0, MEI_NFC_MAX_HCI_PAYLOAD,
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Subject: [PATCH v2 14/15] nfc: microread: drop unneeded memory allocation fail messages
Date: Mon, 13 Sep 2021 15:20:34 +0200 [thread overview]
Message-ID: <20210913132035.242870-15-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210913132035.242870-1-krzysztof.kozlowski@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
nfc_mei_phy_alloc() already prints an error message on memory allocation
failure.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/nfc/microread/mei.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index 686be3381727..e2a77a5fc887 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -24,10 +24,8 @@ static int microread_mei_probe(struct mei_cl_device *cldev,
int r;
phy = nfc_mei_phy_alloc(cldev);
- if (!phy) {
- pr_err("Cannot allocate memory for microread mei phy.\n");
+ if (!phy)
return -ENOMEM;
- }
r = microread_probe(phy, &mei_phy_ops, LLC_NOP_NAME,
MEI_NFC_HEADER_SIZE, 0, MEI_NFC_MAX_HCI_PAYLOAD,
--
2.30.2
next prev parent reply other threads:[~2021-09-13 13:21 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 13:20 [linux-nfc] [PATCH v2 00/15] nfc: minor printk cleanup Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 01/15] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 02/15] nfc: do not break pr_debug() call into separate lines Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 03/15] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 04/15] nfc: fdp: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 05/15] nfc: pn533: " Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 06/15] nfc: pn533: use dev_err() instead of pr_err() Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 07/15] nfc: pn544: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 08/15] nfc: pn544: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 09/15] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 10/15] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 11/15] nfc: st21nfca: " Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 12/15] nfc: trf7970a: " Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 16:57 ` Mark Greer
2021-09-13 16:57 ` Mark Greer
2021-09-13 16:57 ` [linux-nfc] " Mark Greer
2021-10-07 13:01 ` Krzysztof Kozlowski
2021-10-07 13:01 ` Krzysztof Kozlowski
2021-10-07 13:01 ` Krzysztof Kozlowski
2021-10-07 13:12 ` Jakub Kicinski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 13/15] nfc: microread: " Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski [this message]
2021-09-13 13:20 ` [PATCH v2 14/15] nfc: microread: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [linux-nfc] [PATCH v2 15/15] nfc: mrvl: " Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913132035.242870-15-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=k.opasiak@samsung.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.