From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mauri Sandberg" <sandberg@mailfence.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"DENG Qingfang" <dqfext@gmail.com>
Subject: [PATCH net-next 6/8] net: dsa: rtl8366rb: Fix off-by-one bug
Date: Mon, 13 Sep 2021 16:42:58 +0200 [thread overview]
Message-ID: <20210913144300.1265143-7-linus.walleij@linaro.org> (raw)
In-Reply-To: <20210913144300.1265143-1-linus.walleij@linaro.org>
The max VLAN number with non-4K VLAN activated is 15, and the
range is 0..15. Not 16.
Cc: Vladimir Oltean <olteanv@gmail.com>
Cc: Mauri Sandberg <sandberg@mailfence.com>
Cc: Alvin Šipraga <alsi@bang-olufsen.dk>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: DENG Qingfang <dqfext@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v4:
- New patch for a bug discovered when fixing the other issues.
---
drivers/net/dsa/rtl8366rb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
index 6c35e1ed49aa..dfc8ef470972 100644
--- a/drivers/net/dsa/rtl8366rb.c
+++ b/drivers/net/dsa/rtl8366rb.c
@@ -1456,7 +1456,7 @@ static int rtl8366rb_set_mc_index(struct realtek_smi *smi, int port, int index)
static bool rtl8366rb_is_vlan_valid(struct realtek_smi *smi, unsigned int vlan)
{
- unsigned int max = RTL8366RB_NUM_VLANS;
+ unsigned int max = RTL8366RB_NUM_VLANS - 1;
if (smi->vlan4k_enabled)
max = RTL8366RB_NUM_VIDS - 1;
--
2.31.1
next prev parent reply other threads:[~2021-09-13 15:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:42 [PATCH net-next 0/8] RTL8366(RB) cleanups part 1 Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 1/8] net: dsa: rtl8366rb: Support bridge offloading Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 2/8] net: dsa: rtl8366: Drop custom VLAN set-up Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 3/8] net: dsa: rtl8366rb: Rewrite weird VLAN filering enablement Linus Walleij
2021-09-13 17:29 ` Florian Fainelli
2021-09-13 14:42 ` [PATCH net-next 4/8] net: dsa: rtl8366rb: Always treat VLAN 0 as untagged Linus Walleij
2021-09-13 15:45 ` Vladimir Oltean
2021-09-13 14:42 ` [PATCH net-next 5/8] net: dsa: rtl8366: Disable "4K" VLANs Linus Walleij
2021-09-13 15:34 ` Vladimir Oltean
2021-09-13 23:20 ` Linus Walleij
2021-09-14 6:29 ` DENG Qingfang
2021-09-14 13:12 ` Linus Walleij
2021-09-13 14:42 ` Linus Walleij [this message]
2021-09-13 17:22 ` [PATCH net-next 6/8] net: dsa: rtl8366rb: Fix off-by-one bug Vladimir Oltean
2021-09-13 14:42 ` [PATCH net-next 7/8] net: dsa: rtl8366: Fix a bug in deleting VLANs Linus Walleij
2021-09-13 17:34 ` Florian Fainelli
2021-09-13 14:43 ` [PATCH net-next 8/8] net: dsa: rtl8366: Drop and depromote pointless prints Linus Walleij
2021-09-13 17:35 ` Florian Fainelli
2021-09-13 17:38 ` Vladimir Oltean
2021-09-13 18:13 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913144300.1265143-7-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.