From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
netdev@vger.kernel.org, "Mauri Sandberg" <sandberg@mailfence.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"DENG Qingfang" <dqfext@gmail.com>
Subject: Re: [PATCH net-next 8/8] net: dsa: rtl8366: Drop and depromote pointless prints
Date: Mon, 13 Sep 2021 11:13:18 -0700 [thread overview]
Message-ID: <89a84601-7103-d77d-23a6-2ec8d2f4dfc2@gmail.com> (raw)
In-Reply-To: <20210913173810.lrzuzan5vp7l7b4u@skbuf>
On 9/13/2021 10:38 AM, Vladimir Oltean wrote:
> On Mon, Sep 13, 2021 at 10:35:53AM -0700, Florian Fainelli wrote:
>> On 9/13/2021 7:43 AM, Linus Walleij wrote:
>>> We don't need a message for every VLAN association, dbg
>>> is fine. The message about adding the DSA or CPU
>>> port to a VLAN is directly misleading, this is perfectly
>>> fine.
>>>
>>> Cc: Vladimir Oltean <olteanv@gmail.com>
>>> Cc: Mauri Sandberg <sandberg@mailfence.com>
>>> Cc: Alvin Šipraga <alsi@bang-olufsen.dk>
>>> Cc: Florian Fainelli <f.fainelli@gmail.com>
>>> Cc: DENG Qingfang <dqfext@gmail.com>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>> Maybe at some point we should think about moving that kind of debugging
>> messages towards the DSA core, and just leave drivers with debug prints that
>> track an internal state not visible to the DSA framework.
>
> I have some trace points on the bridge driver and in DSA for FDB
> entries, maybe something along those lines?
Yes trace points would work really well, thanks!
--
Florian
prev parent reply other threads:[~2021-09-13 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:42 [PATCH net-next 0/8] RTL8366(RB) cleanups part 1 Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 1/8] net: dsa: rtl8366rb: Support bridge offloading Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 2/8] net: dsa: rtl8366: Drop custom VLAN set-up Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 3/8] net: dsa: rtl8366rb: Rewrite weird VLAN filering enablement Linus Walleij
2021-09-13 17:29 ` Florian Fainelli
2021-09-13 14:42 ` [PATCH net-next 4/8] net: dsa: rtl8366rb: Always treat VLAN 0 as untagged Linus Walleij
2021-09-13 15:45 ` Vladimir Oltean
2021-09-13 14:42 ` [PATCH net-next 5/8] net: dsa: rtl8366: Disable "4K" VLANs Linus Walleij
2021-09-13 15:34 ` Vladimir Oltean
2021-09-13 23:20 ` Linus Walleij
2021-09-14 6:29 ` DENG Qingfang
2021-09-14 13:12 ` Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 6/8] net: dsa: rtl8366rb: Fix off-by-one bug Linus Walleij
2021-09-13 17:22 ` Vladimir Oltean
2021-09-13 14:42 ` [PATCH net-next 7/8] net: dsa: rtl8366: Fix a bug in deleting VLANs Linus Walleij
2021-09-13 17:34 ` Florian Fainelli
2021-09-13 14:43 ` [PATCH net-next 8/8] net: dsa: rtl8366: Drop and depromote pointless prints Linus Walleij
2021-09-13 17:35 ` Florian Fainelli
2021-09-13 17:38 ` Vladimir Oltean
2021-09-13 18:13 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89a84601-7103-d77d-23a6-2ec8d2f4dfc2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.