From: Jouni Malinen <jouni@codeaurora.org> To: Kalle Valo <kvalo@codeaurora.org> Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Baochen Qiang <bqiang@codeaurora.org>, Jouni Malinen <jouni@codeaurora.org> Subject: [PATCH 2/3] ath11k: Move pdev debugfs creation ahead Date: Mon, 13 Sep 2021 21:09:01 +0300 [thread overview] Message-ID: <20210913180902.193874-3-jouni@codeaurora.org> (raw) In-Reply-To: <20210913180902.193874-1-jouni@codeaurora.org> From: Baochen Qiang <bqiang@codeaurora.org> The sram dump debugfs interface has to be put under pdev directory located under /sys/kernel/debug/ath11k/<pdev name>. Currently pdev directory is created after firmware is ready, this is too late for sram dump. Suppose that if errors happen and ath11k fails to reach firmware ready, we have no way to dump sram content to debug cause the interface has not been created yet. So move it ahead. Also move pdev debugfs destroy to ath11k_core_soc_destroy as a mirror. Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 Signed-off-by: Baochen Qiang <bqiang@codeaurora.org> Signed-off-by: Jouni Malinen <jouni@codeaurora.org> --- drivers/net/wireless/ath/ath11k/core.c | 23 +++++++++++++---------- drivers/net/wireless/ath/ath11k/debugfs.c | 21 +++++++++++++++------ drivers/net/wireless/ath/ath11k/debugfs.h | 9 +++++++++ 3 files changed, 37 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index 9f2c9795767e..59fa0ff06dff 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -701,14 +701,22 @@ static int ath11k_core_soc_create(struct ath11k_base *ab) goto err_qmi_deinit; } + ret = ath11k_debugfs_pdev_create(ab); + if (ret) { + ath11k_err(ab, "failed to create core pdev debugfs: %d\n", ret); + goto err_debugfs_reg; + } + ret = ath11k_hif_power_up(ab); if (ret) { ath11k_err(ab, "failed to power up :%d\n", ret); - goto err_debugfs_reg; + goto err_pdev_debug; } return 0; +err_pdev_debug: + ath11k_debugfs_pdev_destroy(ab); err_debugfs_reg: ath11k_debugfs_soc_destroy(ab); err_qmi_deinit: @@ -718,6 +726,7 @@ static int ath11k_core_soc_create(struct ath11k_base *ab) static void ath11k_core_soc_destroy(struct ath11k_base *ab) { + ath11k_debugfs_pdev_destroy(ab); ath11k_debugfs_soc_destroy(ab); ath11k_dp_free(ab); ath11k_reg_free(ab); @@ -728,16 +737,13 @@ static int ath11k_core_pdev_create(struct ath11k_base *ab) { int ret; - ret = ath11k_debugfs_pdev_create(ab); - if (ret) { - ath11k_err(ab, "failed to create core pdev debugfs: %d\n", ret); - return ret; - } + ath11k_debugfs_crash_trigger_create(ab); + ath11k_debugfs_dp_stats_create(ab); ret = ath11k_mac_register(ab); if (ret) { ath11k_err(ab, "failed register the radio with mac80211: %d\n", ret); - goto err_pdev_debug; + return ret; } ret = ath11k_dp_pdev_alloc(ab); @@ -767,8 +773,6 @@ static int ath11k_core_pdev_create(struct ath11k_base *ab) ath11k_dp_pdev_free(ab); err_mac_unregister: ath11k_mac_unregister(ab); -err_pdev_debug: - ath11k_debugfs_pdev_destroy(ab); return ret; } @@ -780,7 +784,6 @@ static void ath11k_core_pdev_destroy(struct ath11k_base *ab) ath11k_mac_unregister(ab); ath11k_hif_irq_disable(ab); ath11k_dp_pdev_free(ab); - ath11k_debugfs_pdev_destroy(ab); } static int ath11k_core_start(struct ath11k_base *ab, diff --git a/drivers/net/wireless/ath/ath11k/debugfs.c b/drivers/net/wireless/ath/ath11k/debugfs.c index 17f0bbbac7ae..cdc492421807 100644 --- a/drivers/net/wireless/ath/ath11k/debugfs.c +++ b/drivers/net/wireless/ath/ath11k/debugfs.c @@ -831,20 +831,29 @@ static const struct file_operations fops_soc_dp_stats = { .llseek = default_llseek, }; -int ath11k_debugfs_pdev_create(struct ath11k_base *ab) +void ath11k_debugfs_crash_trigger_create(struct ath11k_base *ab) { if (test_bit(ATH11K_FLAG_REGISTERED, &ab->dev_flags)) - return 0; - - ab->debugfs_soc = debugfs_create_dir(ab->hw_params.name, ab->debugfs_ath11k); - if (IS_ERR(ab->debugfs_soc)) - return PTR_ERR(ab->debugfs_soc); + return; debugfs_create_file("simulate_fw_crash", 0600, ab->debugfs_soc, ab, &fops_simulate_fw_crash); +} + +void ath11k_debugfs_dp_stats_create(struct ath11k_base *ab) +{ + if (test_bit(ATH11K_FLAG_REGISTERED, &ab->dev_flags)) + return; debugfs_create_file("soc_dp_stats", 0600, ab->debugfs_soc, ab, &fops_soc_dp_stats); +} + +int ath11k_debugfs_pdev_create(struct ath11k_base *ab) +{ + ab->debugfs_soc = debugfs_create_dir(ab->hw_params.name, ab->debugfs_ath11k); + if (IS_ERR(ab->debugfs_soc)) + return PTR_ERR(ab->debugfs_soc); return 0; } diff --git a/drivers/net/wireless/ath/ath11k/debugfs.h b/drivers/net/wireless/ath/ath11k/debugfs.h index e5346af71f24..47b96848cf0a 100644 --- a/drivers/net/wireless/ath/ath11k/debugfs.h +++ b/drivers/net/wireless/ath/ath11k/debugfs.h @@ -145,6 +145,8 @@ static inline int ath11k_debugfs_rx_filter(struct ath11k *ar) return ar->debug.rx_filter; } +void ath11k_debugfs_crash_trigger_create(struct ath11k_base *ab); +void ath11k_debugfs_dp_stats_create(struct ath11k_base *ab); #else static inline int ath11k_debugfs_soc_create(struct ath11k_base *ab) { @@ -212,6 +214,13 @@ static inline int ath11k_debugfs_rx_filter(struct ath11k *ar) return 0; } +static inline void ath11k_debugfs_crash_trigger_create(struct ath11k_base *ab) +{ +} + +static inline void ath11k_debugfs_dp_stats_create(struct ath11k_base *ab) +{ +} #endif /* CONFIG_MAC80211_DEBUGFS*/ #endif /* _ATH11K_DEBUGFS_H_ */ -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jouni Malinen <jouni@codeaurora.org> To: Kalle Valo <kvalo@codeaurora.org> Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Baochen Qiang <bqiang@codeaurora.org>, Jouni Malinen <jouni@codeaurora.org> Subject: [PATCH 2/3] ath11k: Move pdev debugfs creation ahead Date: Mon, 13 Sep 2021 21:09:01 +0300 [thread overview] Message-ID: <20210913180902.193874-3-jouni@codeaurora.org> (raw) In-Reply-To: <20210913180902.193874-1-jouni@codeaurora.org> From: Baochen Qiang <bqiang@codeaurora.org> The sram dump debugfs interface has to be put under pdev directory located under /sys/kernel/debug/ath11k/<pdev name>. Currently pdev directory is created after firmware is ready, this is too late for sram dump. Suppose that if errors happen and ath11k fails to reach firmware ready, we have no way to dump sram content to debug cause the interface has not been created yet. So move it ahead. Also move pdev debugfs destroy to ath11k_core_soc_destroy as a mirror. Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 Signed-off-by: Baochen Qiang <bqiang@codeaurora.org> Signed-off-by: Jouni Malinen <jouni@codeaurora.org> --- drivers/net/wireless/ath/ath11k/core.c | 23 +++++++++++++---------- drivers/net/wireless/ath/ath11k/debugfs.c | 21 +++++++++++++++------ drivers/net/wireless/ath/ath11k/debugfs.h | 9 +++++++++ 3 files changed, 37 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index 9f2c9795767e..59fa0ff06dff 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -701,14 +701,22 @@ static int ath11k_core_soc_create(struct ath11k_base *ab) goto err_qmi_deinit; } + ret = ath11k_debugfs_pdev_create(ab); + if (ret) { + ath11k_err(ab, "failed to create core pdev debugfs: %d\n", ret); + goto err_debugfs_reg; + } + ret = ath11k_hif_power_up(ab); if (ret) { ath11k_err(ab, "failed to power up :%d\n", ret); - goto err_debugfs_reg; + goto err_pdev_debug; } return 0; +err_pdev_debug: + ath11k_debugfs_pdev_destroy(ab); err_debugfs_reg: ath11k_debugfs_soc_destroy(ab); err_qmi_deinit: @@ -718,6 +726,7 @@ static int ath11k_core_soc_create(struct ath11k_base *ab) static void ath11k_core_soc_destroy(struct ath11k_base *ab) { + ath11k_debugfs_pdev_destroy(ab); ath11k_debugfs_soc_destroy(ab); ath11k_dp_free(ab); ath11k_reg_free(ab); @@ -728,16 +737,13 @@ static int ath11k_core_pdev_create(struct ath11k_base *ab) { int ret; - ret = ath11k_debugfs_pdev_create(ab); - if (ret) { - ath11k_err(ab, "failed to create core pdev debugfs: %d\n", ret); - return ret; - } + ath11k_debugfs_crash_trigger_create(ab); + ath11k_debugfs_dp_stats_create(ab); ret = ath11k_mac_register(ab); if (ret) { ath11k_err(ab, "failed register the radio with mac80211: %d\n", ret); - goto err_pdev_debug; + return ret; } ret = ath11k_dp_pdev_alloc(ab); @@ -767,8 +773,6 @@ static int ath11k_core_pdev_create(struct ath11k_base *ab) ath11k_dp_pdev_free(ab); err_mac_unregister: ath11k_mac_unregister(ab); -err_pdev_debug: - ath11k_debugfs_pdev_destroy(ab); return ret; } @@ -780,7 +784,6 @@ static void ath11k_core_pdev_destroy(struct ath11k_base *ab) ath11k_mac_unregister(ab); ath11k_hif_irq_disable(ab); ath11k_dp_pdev_free(ab); - ath11k_debugfs_pdev_destroy(ab); } static int ath11k_core_start(struct ath11k_base *ab, diff --git a/drivers/net/wireless/ath/ath11k/debugfs.c b/drivers/net/wireless/ath/ath11k/debugfs.c index 17f0bbbac7ae..cdc492421807 100644 --- a/drivers/net/wireless/ath/ath11k/debugfs.c +++ b/drivers/net/wireless/ath/ath11k/debugfs.c @@ -831,20 +831,29 @@ static const struct file_operations fops_soc_dp_stats = { .llseek = default_llseek, }; -int ath11k_debugfs_pdev_create(struct ath11k_base *ab) +void ath11k_debugfs_crash_trigger_create(struct ath11k_base *ab) { if (test_bit(ATH11K_FLAG_REGISTERED, &ab->dev_flags)) - return 0; - - ab->debugfs_soc = debugfs_create_dir(ab->hw_params.name, ab->debugfs_ath11k); - if (IS_ERR(ab->debugfs_soc)) - return PTR_ERR(ab->debugfs_soc); + return; debugfs_create_file("simulate_fw_crash", 0600, ab->debugfs_soc, ab, &fops_simulate_fw_crash); +} + +void ath11k_debugfs_dp_stats_create(struct ath11k_base *ab) +{ + if (test_bit(ATH11K_FLAG_REGISTERED, &ab->dev_flags)) + return; debugfs_create_file("soc_dp_stats", 0600, ab->debugfs_soc, ab, &fops_soc_dp_stats); +} + +int ath11k_debugfs_pdev_create(struct ath11k_base *ab) +{ + ab->debugfs_soc = debugfs_create_dir(ab->hw_params.name, ab->debugfs_ath11k); + if (IS_ERR(ab->debugfs_soc)) + return PTR_ERR(ab->debugfs_soc); return 0; } diff --git a/drivers/net/wireless/ath/ath11k/debugfs.h b/drivers/net/wireless/ath/ath11k/debugfs.h index e5346af71f24..47b96848cf0a 100644 --- a/drivers/net/wireless/ath/ath11k/debugfs.h +++ b/drivers/net/wireless/ath/ath11k/debugfs.h @@ -145,6 +145,8 @@ static inline int ath11k_debugfs_rx_filter(struct ath11k *ar) return ar->debug.rx_filter; } +void ath11k_debugfs_crash_trigger_create(struct ath11k_base *ab); +void ath11k_debugfs_dp_stats_create(struct ath11k_base *ab); #else static inline int ath11k_debugfs_soc_create(struct ath11k_base *ab) { @@ -212,6 +214,13 @@ static inline int ath11k_debugfs_rx_filter(struct ath11k *ar) return 0; } +static inline void ath11k_debugfs_crash_trigger_create(struct ath11k_base *ab) +{ +} + +static inline void ath11k_debugfs_dp_stats_create(struct ath11k_base *ab) +{ +} #endif /* CONFIG_MAC80211_DEBUGFS*/ #endif /* _ATH11K_DEBUGFS_H_ */ -- 2.25.1 -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-09-13 18:09 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-13 18:08 [PATCH 0/3] ath11k: Add support for sram dump Jouni Malinen 2021-09-13 18:08 ` Jouni Malinen 2021-09-13 18:09 ` [PATCH 1/3] ath11k: Split PCI write/read functions Jouni Malinen 2021-09-13 18:09 ` Jouni Malinen 2021-09-14 8:36 ` Kalle Valo 2021-09-14 8:36 ` Kalle Valo 2021-09-13 18:09 ` Jouni Malinen [this message] 2021-09-13 18:09 ` [PATCH 2/3] ath11k: Move pdev debugfs creation ahead Jouni Malinen 2021-12-07 17:47 ` Kalle Valo 2021-12-07 17:47 ` Kalle Valo 2021-12-08 1:34 ` Baochen Qiang 2021-12-08 1:34 ` Baochen Qiang 2021-09-13 18:09 ` [PATCH 3/3] ath11k: Implement sram dump interface Jouni Malinen 2021-09-13 18:09 ` Jouni Malinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210913180902.193874-3-jouni@codeaurora.org \ --to=jouni@codeaurora.org \ --cc=ath11k@lists.infradead.org \ --cc=bqiang@codeaurora.org \ --cc=kvalo@codeaurora.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.