All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix
@ 2021-09-14  9:27 ` Christophe Branchereau
  0 siblings, 0 replies; 5+ messages in thread
From: Christophe Branchereau @ 2021-09-14  9:27 UTC (permalink / raw)
  Cc: paul, Christophe Branchereau, Thierry Reding, Sam Ravnborg,
	David Airlie, Daniel Vetter, dri-devel, linux-kernel

The previous parameters caused an unbalanced yellow tint.

Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
---
 drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
index 2d8794d495d0..3d8a9ab47cae 100644
--- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
+++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
@@ -146,8 +146,8 @@ static const struct reg_sequence y030xx067a_init_sequence[] = {
 	{ 0x09, REG09_SUB_BRIGHT_R(0x20) },
 	{ 0x0a, REG0A_SUB_BRIGHT_B(0x20) },
 	{ 0x0b, REG0B_HD_FREERUN | REG0B_VD_FREERUN },
-	{ 0x0c, REG0C_CONTRAST_R(0x10) },
-	{ 0x0d, REG0D_CONTRAST_G(0x10) },
+	{ 0x0c, REG0C_CONTRAST_R(0x00) },
+	{ 0x0d, REG0D_CONTRAST_G(0x00) },
 	{ 0x0e, REG0E_CONTRAST_B(0x10) },
 	{ 0x0f, 0 },
 	{ 0x10, REG10_BRIGHT(0x7f) },
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix
@ 2021-09-14  9:27 ` Christophe Branchereau
  0 siblings, 0 replies; 5+ messages in thread
From: Christophe Branchereau @ 2021-09-14  9:27 UTC (permalink / raw)
  Cc: paul, Christophe Branchereau, Thierry Reding, Sam Ravnborg,
	David Airlie, Daniel Vetter, dri-devel, linux-kernel

The previous parameters caused an unbalanced yellow tint.

Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
---
 drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
index 2d8794d495d0..3d8a9ab47cae 100644
--- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
+++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
@@ -146,8 +146,8 @@ static const struct reg_sequence y030xx067a_init_sequence[] = {
 	{ 0x09, REG09_SUB_BRIGHT_R(0x20) },
 	{ 0x0a, REG0A_SUB_BRIGHT_B(0x20) },
 	{ 0x0b, REG0B_HD_FREERUN | REG0B_VD_FREERUN },
-	{ 0x0c, REG0C_CONTRAST_R(0x10) },
-	{ 0x0d, REG0D_CONTRAST_G(0x10) },
+	{ 0x0c, REG0C_CONTRAST_R(0x00) },
+	{ 0x0d, REG0D_CONTRAST_G(0x00) },
 	{ 0x0e, REG0E_CONTRAST_B(0x10) },
 	{ 0x0f, 0 },
 	{ 0x10, REG10_BRIGHT(0x7f) },
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix
  2021-09-14  9:27 ` Christophe Branchereau
  (?)
@ 2021-09-14 18:14 ` Paul Cercueil
  -1 siblings, 0 replies; 5+ messages in thread
From: Paul Cercueil @ 2021-09-14 18:14 UTC (permalink / raw)
  To: Christophe Branchereau
  Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	dri-devel, linux-kernel

Hi Christophe,

Le mar., sept. 14 2021 at 11:27:16 +0200, Christophe Branchereau 
<cbranchereau@gmail.com> a écrit :
> The previous parameters caused an unbalanced yellow tint.
> 
> Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c 
> b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
> index 2d8794d495d0..3d8a9ab47cae 100644
> --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
> +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
> @@ -146,8 +146,8 @@ static const struct reg_sequence 
> y030xx067a_init_sequence[] = {
>  	{ 0x09, REG09_SUB_BRIGHT_R(0x20) },
>  	{ 0x0a, REG0A_SUB_BRIGHT_B(0x20) },
>  	{ 0x0b, REG0B_HD_FREERUN | REG0B_VD_FREERUN },
> -	{ 0x0c, REG0C_CONTRAST_R(0x10) },
> -	{ 0x0d, REG0D_CONTRAST_G(0x10) },
> +	{ 0x0c, REG0C_CONTRAST_R(0x00) },
> +	{ 0x0d, REG0D_CONTRAST_G(0x00) },
>  	{ 0x0e, REG0E_CONTRAST_B(0x10) },
>  	{ 0x0f, 0 },
>  	{ 0x10, REG10_BRIGHT(0x7f) },
> --
> 2.33.0
> 



^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix
  2021-09-14  9:27 ` Christophe Branchereau
  (?)
  (?)
@ 2021-09-23 20:17 ` Sam Ravnborg
  2021-09-23 22:33   ` Paul Cercueil
  -1 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2021-09-23 20:17 UTC (permalink / raw)
  To: Christophe Branchereau
  Cc: paul, Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
	linux-kernel

Hi Christophe, Paul,
On Tue, Sep 14, 2021 at 11:27:16AM +0200, Christophe Branchereau wrote:
> The previous parameters caused an unbalanced yellow tint.
> 
> Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>

with the subject fixed the patch is:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Paul - I assume you will apply this as you wrote on irc.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
> index 2d8794d495d0..3d8a9ab47cae 100644
> --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
> +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
> @@ -146,8 +146,8 @@ static const struct reg_sequence y030xx067a_init_sequence[] = {
>  	{ 0x09, REG09_SUB_BRIGHT_R(0x20) },
>  	{ 0x0a, REG0A_SUB_BRIGHT_B(0x20) },
>  	{ 0x0b, REG0B_HD_FREERUN | REG0B_VD_FREERUN },
> -	{ 0x0c, REG0C_CONTRAST_R(0x10) },
> -	{ 0x0d, REG0D_CONTRAST_G(0x10) },
> +	{ 0x0c, REG0C_CONTRAST_R(0x00) },
> +	{ 0x0d, REG0D_CONTRAST_G(0x00) },
>  	{ 0x0e, REG0E_CONTRAST_B(0x10) },
>  	{ 0x0f, 0 },
>  	{ 0x10, REG10_BRIGHT(0x7f) },
> -- 
> 2.33.0

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix
  2021-09-23 20:17 ` Sam Ravnborg
@ 2021-09-23 22:33   ` Paul Cercueil
  0 siblings, 0 replies; 5+ messages in thread
From: Paul Cercueil @ 2021-09-23 22:33 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Christophe Branchereau, Thierry Reding, David Airlie,
	Daniel Vetter, dri-devel, linux-kernel

Hi,

Le jeu., sept. 23 2021 at 22:17:51 +0200, Sam Ravnborg 
<sam@ravnborg.org> a écrit :
> Hi Christophe, Paul,
> On Tue, Sep 14, 2021 at 11:27:16AM +0200, Christophe Branchereau 
> wrote:
>>  The previous parameters caused an unbalanced yellow tint.
>> 
>>  Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
> 
> with the subject fixed the patch is:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> Paul - I assume you will apply this as you wrote on irc.

I added:
Fixes: 7467389bdafb ("drm/panel: Add ABT Y030XX067A 3.0" 320x480 panel")

I also fixed the subject (case and punctuation), and pushed to 
drm-misc-fixes.

Thanks!

Cheers,
-Paul

> 
> 	Sam
> 
>>  ---
>>   drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>>  diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c 
>> b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
>>  index 2d8794d495d0..3d8a9ab47cae 100644
>>  --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
>>  +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
>>  @@ -146,8 +146,8 @@ static const struct reg_sequence 
>> y030xx067a_init_sequence[] = {
>>   	{ 0x09, REG09_SUB_BRIGHT_R(0x20) },
>>   	{ 0x0a, REG0A_SUB_BRIGHT_B(0x20) },
>>   	{ 0x0b, REG0B_HD_FREERUN | REG0B_VD_FREERUN },
>>  -	{ 0x0c, REG0C_CONTRAST_R(0x10) },
>>  -	{ 0x0d, REG0D_CONTRAST_G(0x10) },
>>  +	{ 0x0c, REG0C_CONTRAST_R(0x00) },
>>  +	{ 0x0d, REG0D_CONTRAST_G(0x00) },
>>   	{ 0x0e, REG0E_CONTRAST_B(0x10) },
>>   	{ 0x0f, 0 },
>>   	{ 0x10, REG10_BRIGHT(0x7f) },
>>  --
>>  2.33.0



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-23 22:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14  9:27 [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix Christophe Branchereau
2021-09-14  9:27 ` Christophe Branchereau
2021-09-14 18:14 ` Paul Cercueil
2021-09-23 20:17 ` Sam Ravnborg
2021-09-23 22:33   ` Paul Cercueil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.