From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] scripts/checkpatch.pl: Ignore TST_* in constant checks
Date: Tue, 14 Sep 2021 12:01:58 +0200 [thread overview]
Message-ID: <20210914100158.744-1-chrubis@suse.cz> (raw)
Message-ID: <20210914100158.jelJtwcplhoxif2q8lF2e_otkm7Rvgx9NrZLyf3B5NE@z> (raw)
The checkpatch.pl thinks that TST_RET etc are constants because it
treats everything that is uppercase as a constant and hence complains at
following code:
if (TST_RET != tc->exp_errno)
tst_res(TFAIL, "...");
In this case both sides of the comparsion are variables and the code
is as it should be.
So this commit disables the check for 'yoda comparsion' for constants if
the identifier on the left starts with TST_.
Reported-by: Martin Doucha <mdoucha@suse.cz>
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
scripts/checkpatch.pl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 88cb294dc..87572b2f4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5462,7 +5462,9 @@ sub process {
my $comp = $3;
my $to = $4;
my $newcomp = $comp;
- if ($lead !~ /(?:$Operators|\.)\s*$/ &&
+
+ if ($const !~ /^\QTST_/ &&
+ $lead !~ /(?:$Operators|\.)\s*$/ &&
$to !~ /^(?:Constant|[A-Z_][A-Z0-9_]*)$/ &&
WARN("CONSTANT_COMPARISON",
"Comparisons should place the constant on the right side of the test\n" . $herecurr) &&
--
2.32.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2021-09-14 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 10:01 Cyril Hrubis [this message]
2021-09-14 10:01 ` [LTP] [PATCH] scripts/checkpatch.pl: Ignore TST_* in constant checks Cyril Hrubis
2021-09-14 12:44 ` Petr Vorel
2021-09-14 12:44 ` Petr Vorel
2021-09-14 13:16 ` Cyril Hrubis
2021-09-14 13:16 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914100158.744-1-chrubis@suse.cz \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.