* [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory
@ 2021-09-14 16:17 Fabrice Fontaine
2021-09-14 16:17 ` [Buildroot] [PATCH 2/2] package/x11r7/xapp_xeyes: add xlib_libXi mandatory dependency Fabrice Fontaine
2021-09-14 19:52 ` [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-09-14 16:17 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Fabrice Fontaine
xrender is optional, not mandatory since its addition in version 1.0.99:
https://gitlab.freedesktop.org/xorg/app/xeyes/-/commit/5e825a140f4022b88dd7a1a20a9a01b653f1a95c
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/x11r7/xapp_xeyes/Config.in | 1 -
package/x11r7/xapp_xeyes/xapp_xeyes.mk | 9 ++++++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/package/x11r7/xapp_xeyes/Config.in b/package/x11r7/xapp_xeyes/Config.in
index 5cf7f6c052..a7b77375fd 100644
--- a/package/x11r7/xapp_xeyes/Config.in
+++ b/package/x11r7/xapp_xeyes/Config.in
@@ -3,7 +3,6 @@ config BR2_PACKAGE_XAPP_XEYES
select BR2_PACKAGE_XLIB_LIBX11
select BR2_PACKAGE_XLIB_LIBXEXT
select BR2_PACKAGE_XLIB_LIBXMU
- select BR2_PACKAGE_XLIB_LIBXRENDER
select BR2_PACKAGE_XLIB_LIBXT
help
X.Org xeyes application
diff --git a/package/x11r7/xapp_xeyes/xapp_xeyes.mk b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
index 11eea802d5..a127e28ea7 100644
--- a/package/x11r7/xapp_xeyes/xapp_xeyes.mk
+++ b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
@@ -9,6 +9,13 @@ XAPP_XEYES_SOURCE = xeyes-$(XAPP_XEYES_VERSION).tar.bz2
XAPP_XEYES_SITE = https://xorg.freedesktop.org/archive/individual/app
XAPP_XEYES_LICENSE = MIT
XAPP_XEYES_LICENSE_FILES = COPYING
-XAPP_XEYES_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXmu xlib_libXrender xlib_libXt
+XAPP_XEYES_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXmu xlib_libXt
+
+ifeq ($(BR2_PACKAGE_XLIB_LIBXRENDER),y)
+XAPP_XEYES_DEPENDENCIES += xlib_libXrender
+XAPP_XEYES_CONF_OPTS += --with-xrender
+else
+XAPP_XEYES_CONF_OPTS += --without-xrender
+endif
$(eval $(autotools-package))
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/x11r7/xapp_xeyes: add xlib_libXi mandatory dependency
2021-09-14 16:17 [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory Fabrice Fontaine
@ 2021-09-14 16:17 ` Fabrice Fontaine
2021-09-14 19:54 ` Yann E. MORIN
2021-09-14 19:52 ` [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2021-09-14 16:17 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Fabrice Fontaine
Build fails since commit c47ebe7aeb70015614ff1d477dc1a71e8c161425
because xlib_libXi is a mandatory dependency since version 1.2.0 and
https://gitlab.freedesktop.org/xorg/app/xeyes/-/commit/420c2d8517246c9e422739cadb7acb29e35a3bed:
configure: error: Package requirements (xi >= 1.7 x11 xt xext xmu xproto >= 7.0.17) were not met:
Package 'xi', required by 'virtual:world', not found
Fixes:
- http://autobuild.buildroot.org/results/896f45fb9eadcd235aeab096db479ee0aa5d0860
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/x11r7/xapp_xeyes/Config.in | 1 +
package/x11r7/xapp_xeyes/xapp_xeyes.mk | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/x11r7/xapp_xeyes/Config.in b/package/x11r7/xapp_xeyes/Config.in
index a7b77375fd..268bc5807e 100644
--- a/package/x11r7/xapp_xeyes/Config.in
+++ b/package/x11r7/xapp_xeyes/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_XAPP_XEYES
bool "xeyes"
select BR2_PACKAGE_XLIB_LIBX11
select BR2_PACKAGE_XLIB_LIBXEXT
+ select BR2_PACKAGE_XLIB_LIBXI
select BR2_PACKAGE_XLIB_LIBXMU
select BR2_PACKAGE_XLIB_LIBXT
help
diff --git a/package/x11r7/xapp_xeyes/xapp_xeyes.mk b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
index a127e28ea7..68df8c9ab0 100644
--- a/package/x11r7/xapp_xeyes/xapp_xeyes.mk
+++ b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
@@ -9,7 +9,8 @@ XAPP_XEYES_SOURCE = xeyes-$(XAPP_XEYES_VERSION).tar.bz2
XAPP_XEYES_SITE = https://xorg.freedesktop.org/archive/individual/app
XAPP_XEYES_LICENSE = MIT
XAPP_XEYES_LICENSE_FILES = COPYING
-XAPP_XEYES_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXmu xlib_libXt
+XAPP_XEYES_DEPENDENCIES = \
+ xlib_libX11 xlib_libXext xlib_libXi xlib_libXmu xlib_libXt
ifeq ($(BR2_PACKAGE_XLIB_LIBXRENDER),y)
XAPP_XEYES_DEPENDENCIES += xlib_libXrender
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory
2021-09-14 16:17 [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory Fabrice Fontaine
2021-09-14 16:17 ` [Buildroot] [PATCH 2/2] package/x11r7/xapp_xeyes: add xlib_libXi mandatory dependency Fabrice Fontaine
@ 2021-09-14 19:52 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-09-14 19:52 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, buildroot
Fabrice, All,
On 2021-09-14 18:17 +0200, Fabrice Fontaine spake thusly:
> xrender is optional, not mandatory since its addition in version 1.0.99:
> https://gitlab.freedesktop.org/xorg/app/xeyes/-/commit/5e825a140f4022b88dd7a1a20a9a01b653f1a95c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/x11r7/xapp_xeyes/Config.in | 1 -
> package/x11r7/xapp_xeyes/xapp_xeyes.mk | 9 ++++++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/package/x11r7/xapp_xeyes/Config.in b/package/x11r7/xapp_xeyes/Config.in
> index 5cf7f6c052..a7b77375fd 100644
> --- a/package/x11r7/xapp_xeyes/Config.in
> +++ b/package/x11r7/xapp_xeyes/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_XAPP_XEYES
> select BR2_PACKAGE_XLIB_LIBX11
> select BR2_PACKAGE_XLIB_LIBXEXT
> select BR2_PACKAGE_XLIB_LIBXMU
> - select BR2_PACKAGE_XLIB_LIBXRENDER
> select BR2_PACKAGE_XLIB_LIBXT
> help
> X.Org xeyes application
> diff --git a/package/x11r7/xapp_xeyes/xapp_xeyes.mk b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
> index 11eea802d5..a127e28ea7 100644
> --- a/package/x11r7/xapp_xeyes/xapp_xeyes.mk
> +++ b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
> @@ -9,6 +9,13 @@ XAPP_XEYES_SOURCE = xeyes-$(XAPP_XEYES_VERSION).tar.bz2
> XAPP_XEYES_SITE = https://xorg.freedesktop.org/archive/individual/app
> XAPP_XEYES_LICENSE = MIT
> XAPP_XEYES_LICENSE_FILES = COPYING
> -XAPP_XEYES_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXmu xlib_libXrender xlib_libXt
> +XAPP_XEYES_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXmu xlib_libXt
> +
> +ifeq ($(BR2_PACKAGE_XLIB_LIBXRENDER),y)
> +XAPP_XEYES_DEPENDENCIES += xlib_libXrender
> +XAPP_XEYES_CONF_OPTS += --with-xrender
> +else
> +XAPP_XEYES_CONF_OPTS += --without-xrender
> +endif
>
> $(eval $(autotools-package))
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/x11r7/xapp_xeyes: add xlib_libXi mandatory dependency
2021-09-14 16:17 ` [Buildroot] [PATCH 2/2] package/x11r7/xapp_xeyes: add xlib_libXi mandatory dependency Fabrice Fontaine
@ 2021-09-14 19:54 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-09-14 19:54 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, buildroot
Fabrice, All,
On 2021-09-14 18:17 +0200, Fabrice Fontaine spake thusly:
> Build fails since commit c47ebe7aeb70015614ff1d477dc1a71e8c161425
> because xlib_libXi is a mandatory dependency since version 1.2.0 and
> https://gitlab.freedesktop.org/xorg/app/xeyes/-/commit/420c2d8517246c9e422739cadb7acb29e35a3bed:
>
> configure: error: Package requirements (xi >= 1.7 x11 xt xext xmu xproto >= 7.0.17) were not met:
>
> Package 'xi', required by 'virtual:world', not found
>
> Fixes:
> - http://autobuild.buildroot.org/results/896f45fb9eadcd235aeab096db479ee0aa5d0860
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/x11r7/xapp_xeyes/Config.in | 1 +
> package/x11r7/xapp_xeyes/xapp_xeyes.mk | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/x11r7/xapp_xeyes/Config.in b/package/x11r7/xapp_xeyes/Config.in
> index a7b77375fd..268bc5807e 100644
> --- a/package/x11r7/xapp_xeyes/Config.in
> +++ b/package/x11r7/xapp_xeyes/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_XAPP_XEYES
> bool "xeyes"
> select BR2_PACKAGE_XLIB_LIBX11
> select BR2_PACKAGE_XLIB_LIBXEXT
> + select BR2_PACKAGE_XLIB_LIBXI
> select BR2_PACKAGE_XLIB_LIBXMU
> select BR2_PACKAGE_XLIB_LIBXT
> help
> diff --git a/package/x11r7/xapp_xeyes/xapp_xeyes.mk b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
> index a127e28ea7..68df8c9ab0 100644
> --- a/package/x11r7/xapp_xeyes/xapp_xeyes.mk
> +++ b/package/x11r7/xapp_xeyes/xapp_xeyes.mk
> @@ -9,7 +9,8 @@ XAPP_XEYES_SOURCE = xeyes-$(XAPP_XEYES_VERSION).tar.bz2
> XAPP_XEYES_SITE = https://xorg.freedesktop.org/archive/individual/app
> XAPP_XEYES_LICENSE = MIT
> XAPP_XEYES_LICENSE_FILES = COPYING
> -XAPP_XEYES_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXmu xlib_libXt
> +XAPP_XEYES_DEPENDENCIES = \
> + xlib_libX11 xlib_libXext xlib_libXi xlib_libXmu xlib_libXt
When a list does not fit on a single line, I prefer that each item is on
their own line:
XAPP_XEYES_DEPENDENCIES = \
xlib_libX11 \
xlib_libXext \
xlib_libXi \
xlib_libXmu \
xlib_libXt
Applied to master with the above change, thanks.
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_XLIB_LIBXRENDER),y)
> XAPP_XEYES_DEPENDENCIES += xlib_libXrender
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-14 19:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 16:17 [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory Fabrice Fontaine
2021-09-14 16:17 ` [Buildroot] [PATCH 2/2] package/x11r7/xapp_xeyes: add xlib_libXi mandatory dependency Fabrice Fontaine
2021-09-14 19:54 ` Yann E. MORIN
2021-09-14 19:52 ` [Buildroot] [PATCH 1/2] package/x11r7/xapp_xeyes: xrender is optional, not mandatory Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.