* [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 7:42 ` Cai Huoqing
0 siblings, 0 replies; 9+ messages in thread
From: Cai Huoqing @ 2021-09-01 7:42 UTC (permalink / raw)
To: caihuoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Neil Armstrong, linux-mtd, linux-arm-kernel, linux-oxnas,
linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/mtd/nand/raw/oxnas_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
index f44947043e5a..cd112d45e0b5 100644
--- a/drivers/mtd/nand/raw/oxnas_nand.c
+++ b/drivers/mtd/nand/raw/oxnas_nand.c
@@ -79,7 +79,6 @@ static int oxnas_nand_probe(struct platform_device *pdev)
struct oxnas_nand_ctrl *oxnas;
struct nand_chip *chip;
struct mtd_info *mtd;
- struct resource *res;
int count = 0;
int err = 0;
int i;
@@ -92,8 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
nand_controller_init(&oxnas->base);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- oxnas->io_base = devm_ioremap_resource(&pdev->dev, res);
+ oxnas->io_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(oxnas->io_base))
return PTR_ERR(oxnas->io_base);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 7:42 ` Cai Huoqing
0 siblings, 0 replies; 9+ messages in thread
From: Cai Huoqing @ 2021-09-01 7:42 UTC (permalink / raw)
To: caihuoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Neil Armstrong, linux-mtd, linux-arm-kernel, linux-oxnas,
linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/mtd/nand/raw/oxnas_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
index f44947043e5a..cd112d45e0b5 100644
--- a/drivers/mtd/nand/raw/oxnas_nand.c
+++ b/drivers/mtd/nand/raw/oxnas_nand.c
@@ -79,7 +79,6 @@ static int oxnas_nand_probe(struct platform_device *pdev)
struct oxnas_nand_ctrl *oxnas;
struct nand_chip *chip;
struct mtd_info *mtd;
- struct resource *res;
int count = 0;
int err = 0;
int i;
@@ -92,8 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
nand_controller_init(&oxnas->base);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- oxnas->io_base = devm_ioremap_resource(&pdev->dev, res);
+ oxnas->io_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(oxnas->io_base))
return PTR_ERR(oxnas->io_base);
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 7:42 ` Cai Huoqing
(?)
@ 2021-09-01 8:14 ` Neil Armstrong
-1 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2021-09-01 8:14 UTC (permalink / raw)
To: Cai Huoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, linux-arm-kernel, linux-oxnas, linux-kernel
On 01/09/2021 09:42, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/mtd/nand/raw/oxnas_nand.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
> index f44947043e5a..cd112d45e0b5 100644
> --- a/drivers/mtd/nand/raw/oxnas_nand.c
> +++ b/drivers/mtd/nand/raw/oxnas_nand.c
> @@ -79,7 +79,6 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> struct oxnas_nand_ctrl *oxnas;
> struct nand_chip *chip;
> struct mtd_info *mtd;
> - struct resource *res;
> int count = 0;
> int err = 0;
> int i;
> @@ -92,8 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
>
> nand_controller_init(&oxnas->base);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - oxnas->io_base = devm_ioremap_resource(&pdev->dev, res);
> + oxnas->io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(oxnas->io_base))
> return PTR_ERR(oxnas->io_base);
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 8:14 ` Neil Armstrong
0 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2021-09-01 8:14 UTC (permalink / raw)
To: Cai Huoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, linux-arm-kernel, linux-oxnas, linux-kernel
On 01/09/2021 09:42, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/mtd/nand/raw/oxnas_nand.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
> index f44947043e5a..cd112d45e0b5 100644
> --- a/drivers/mtd/nand/raw/oxnas_nand.c
> +++ b/drivers/mtd/nand/raw/oxnas_nand.c
> @@ -79,7 +79,6 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> struct oxnas_nand_ctrl *oxnas;
> struct nand_chip *chip;
> struct mtd_info *mtd;
> - struct resource *res;
> int count = 0;
> int err = 0;
> int i;
> @@ -92,8 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
>
> nand_controller_init(&oxnas->base);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - oxnas->io_base = devm_ioremap_resource(&pdev->dev, res);
> + oxnas->io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(oxnas->io_base))
> return PTR_ERR(oxnas->io_base);
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 8:14 ` Neil Armstrong
0 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2021-09-01 8:14 UTC (permalink / raw)
To: Cai Huoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, linux-arm-kernel, linux-oxnas, linux-kernel
On 01/09/2021 09:42, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/mtd/nand/raw/oxnas_nand.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
> index f44947043e5a..cd112d45e0b5 100644
> --- a/drivers/mtd/nand/raw/oxnas_nand.c
> +++ b/drivers/mtd/nand/raw/oxnas_nand.c
> @@ -79,7 +79,6 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> struct oxnas_nand_ctrl *oxnas;
> struct nand_chip *chip;
> struct mtd_info *mtd;
> - struct resource *res;
> int count = 0;
> int err = 0;
> int i;
> @@ -92,8 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
>
> nand_controller_init(&oxnas->base);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - oxnas->io_base = devm_ioremap_resource(&pdev->dev, res);
> + oxnas->io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(oxnas->io_base))
> return PTR_ERR(oxnas->io_base);
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 7:42 ` Cai Huoqing
(?)
@ 2021-09-14 17:39 ` Miquel Raynal
-1 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2021-09-14 17:39 UTC (permalink / raw)
To: Cai Huoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Neil Armstrong, linux-mtd, linux-arm-kernel, linux-oxnas,
linux-kernel
On Wed, 2021-09-01 at 07:42:07 UTC, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-14 17:39 ` Miquel Raynal
0 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2021-09-14 17:39 UTC (permalink / raw)
To: Cai Huoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Neil Armstrong, linux-mtd, linux-arm-kernel, linux-oxnas,
linux-kernel
On Wed, 2021-09-01 at 07:42:07 UTC, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-14 17:39 ` Miquel Raynal
0 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2021-09-14 17:39 UTC (permalink / raw)
To: Cai Huoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Neil Armstrong, linux-mtd, linux-arm-kernel, linux-oxnas,
linux-kernel
On Wed, 2021-09-01 at 07:42:07 UTC, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread