* [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
@ 2021-09-15 10:47 ` roucaries.bastien
0 siblings, 0 replies; 9+ messages in thread
From: roucaries.bastien @ 2021-09-15 10:47 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Chen-Yu Tsai
Cc: devicetree, linux-kernel, linux-arm-kernel, Salvatore Bonaccorso,
Bastien Roucariès
From: Bastien Roucariès <rouca@debian.org>
Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
wrong setting.
Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.
Signed-off-by: Bastien Roucariès <rouca@debian.org>
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index 8077f1716fbc..ecb91fb899ff 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
@ 2021-09-15 10:47 ` roucaries.bastien
0 siblings, 0 replies; 9+ messages in thread
From: roucaries.bastien @ 2021-09-15 10:47 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Chen-Yu Tsai
Cc: devicetree, linux-kernel, linux-arm-kernel, Salvatore Bonaccorso,
Bastien Roucariès
From: Bastien Roucariès <rouca@debian.org>
Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
wrong setting.
Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.
Signed-off-by: Bastien Roucariès <rouca@debian.org>
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index 8077f1716fbc..ecb91fb899ff 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.33.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
2021-09-16 11:03 ` Maxime Ripard
(?)
@ 2021-09-18 10:48 ` Bastien Roucariès
-1 siblings, 0 replies; 9+ messages in thread
From: Bastien Roucariès @ 2021-09-18 10:48 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Chen-Yu Tsai, Chen-Yu Tsai, devicetree, linux-kernel,
linux-arm-kernel, Salvatore Bonaccorso, Maxime Ripard
[-- Attachment #1: Type: text/plain, Size: 960 bytes --]
Le jeudi 16 septembre 2021, 11:03:05 UTC Maxime Ripard a écrit :
> Hi,
>
> On Thu, Sep 16, 2021 at 08:17:21AM +0000, roucaries.bastien@gmail.com wrote:
> > From: Bastien Roucariès <rouca@debian.org>
> >
> > Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > config") sets the RX/TX delay according to the phy-mode property in the
> > device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is
> > the wrong setting.
> >
> > Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> > Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> > the Ethernet working again on this board.
> >
> > Signed-off-by: Bastien Roucariès <rouca@debian.org>
>
> It's the third time you've sent it since yesterday, what are the
> differences and which one am I supposed to apply?
apply the first, my infra is falky sorry for the three messages send
Bastien
>
> Maxime
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
2021-09-16 8:17 ` roucaries.bastien
@ 2021-09-16 11:03 ` Maxime Ripard
-1 siblings, 0 replies; 9+ messages in thread
From: Maxime Ripard @ 2021-09-16 11:03 UTC (permalink / raw)
To: roucaries.bastien
Cc: Chen-Yu Tsai, Chen-Yu Tsai, devicetree, linux-kernel,
linux-arm-kernel, Salvatore Bonaccorso, Bastien Roucariès
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
Hi,
On Thu, Sep 16, 2021 at 08:17:21AM +0000, roucaries.bastien@gmail.com wrote:
> From: Bastien Roucariès <rouca@debian.org>
>
> Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") sets the RX/TX delay according to the phy-mode property in the
> device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
> wrong setting.
>
> Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> the Ethernet working again on this board.
>
> Signed-off-by: Bastien Roucariès <rouca@debian.org>
It's the third time you've sent it since yesterday, what are the
differences and which one am I supposed to apply?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
@ 2021-09-16 11:03 ` Maxime Ripard
0 siblings, 0 replies; 9+ messages in thread
From: Maxime Ripard @ 2021-09-16 11:03 UTC (permalink / raw)
To: roucaries.bastien
Cc: Chen-Yu Tsai, Chen-Yu Tsai, devicetree, linux-kernel,
linux-arm-kernel, Salvatore Bonaccorso, Bastien Roucariès
[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]
Hi,
On Thu, Sep 16, 2021 at 08:17:21AM +0000, roucaries.bastien@gmail.com wrote:
> From: Bastien Roucariès <rouca@debian.org>
>
> Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") sets the RX/TX delay according to the phy-mode property in the
> device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
> wrong setting.
>
> Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> the Ethernet working again on this board.
>
> Signed-off-by: Bastien Roucariès <rouca@debian.org>
It's the third time you've sent it since yesterday, what are the
differences and which one am I supposed to apply?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
@ 2021-09-16 8:17 ` roucaries.bastien
0 siblings, 0 replies; 9+ messages in thread
From: roucaries.bastien @ 2021-09-16 8:17 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Chen-Yu Tsai
Cc: devicetree, linux-kernel, linux-arm-kernel, Salvatore Bonaccorso,
Bastien Roucariès
From: Bastien Roucariès <rouca@debian.org>
Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
wrong setting.
Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.
Signed-off-by: Bastien Roucariès <rouca@debian.org>
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index 8077f1716fbc..ecb91fb899ff 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
@ 2021-09-16 8:17 ` roucaries.bastien
0 siblings, 0 replies; 9+ messages in thread
From: roucaries.bastien @ 2021-09-16 8:17 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Chen-Yu Tsai
Cc: devicetree, linux-kernel, linux-arm-kernel, Salvatore Bonaccorso,
Bastien Roucariès
From: Bastien Roucariès <rouca@debian.org>
Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
wrong setting.
Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.
Signed-off-by: Bastien Roucariès <rouca@debian.org>
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index 8077f1716fbc..ecb91fb899ff 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.33.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
@ 2021-09-15 10:41 ` Bastien Roucariès
0 siblings, 0 replies; 9+ messages in thread
From: Bastien Roucariès @ 2021-09-15 10:41 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Chen-Yu Tsai
Cc: devicetree, linux-kernel, linux-arm-kernel, Salvatore Bonaccorso,
Bastien Roucariès
Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
wrong setting.
Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.
Signed-off-by: Bastien Roucariès <rouca@debian.org>
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index 8077f1716fbc..ecb91fb899ff 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
@ 2021-09-15 10:41 ` Bastien Roucariès
0 siblings, 0 replies; 9+ messages in thread
From: Bastien Roucariès @ 2021-09-15 10:41 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Chen-Yu Tsai
Cc: devicetree, linux-kernel, linux-arm-kernel, Salvatore Bonaccorso,
Bastien Roucariès
Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
wrong setting.
Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.
Signed-off-by: Bastien Roucariès <rouca@debian.org>
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index 8077f1716fbc..ecb91fb899ff 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.33.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-09-18 10:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 10:47 [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode roucaries.bastien
2021-09-15 10:47 ` roucaries.bastien
-- strict thread matches above, loose matches on Subject: below --
2021-09-16 8:17 roucaries.bastien
2021-09-16 8:17 ` roucaries.bastien
2021-09-16 11:03 ` Maxime Ripard
2021-09-16 11:03 ` Maxime Ripard
2021-09-18 10:48 ` Bastien Roucariès
2021-09-15 10:41 Bastien Roucariès
2021-09-15 10:41 ` Bastien Roucariès
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.