From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> To: unlisted-recipients:; (no To-header on input) Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>, Robert Beckett <bob.beckett@collabora.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list), laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, kiril.bicevski@collabora.com, Nas Chung <nas.chung@chipsnmedia.com>, lafley.kim@chipsnmedia.com, scott.woo@chipsnmedia.com, olivier.crete@collabora.com Subject: [PATCH 4/6] staging: wave5: Add TODO file Date: Wed, 15 Sep 2021 18:23:22 +0200 [thread overview] Message-ID: <20210915162324.25513-5-dafna.hirschfeld@collabora.com> (raw) In-Reply-To: <20210915162324.25513-1-dafna.hirschfeld@collabora.com> Add a TODO file listing all that is need for destaging. Signed-off-by: Robert Beckett <bob.beckett@collabora.com> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- drivers/staging/media/wave5/TODO | 42 ++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 drivers/staging/media/wave5/TODO diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO new file mode 100644 index 000000000000..7e94e8dcedcf --- /dev/null +++ b/drivers/staging/media/wave5/TODO @@ -0,0 +1,42 @@ +* Test on real silicon once available + + This driver has so far been tested on pre-silicon FPGA and on the beta BeagleV + board which uses the StarFive JH7100 beta SoC. + + Testing on FPGA shows it working fine, though the FPGA uses polled interrupts + and copied buffers between the host and it's on board RAM. + + Testing on BeagleV shows buffer corruption that is currently attributed to a + known silicon issue in the SoC that makes the cache coherent interconnect not + so coherent. + This can likely be solved when the riscv non-coherent dma support lands and + provide optional v4l2 non-contiguous allocator, though it remains to be seen + whether support non-coherent use cases will be useful in real world hw. + + Until we can test and resolve any issues on final silicon (due 2H 2021) + this driver should remain in staging. + +* Handle interrupts better + + Currently the interrupt handling uses an unusual design employing a kfifo to + transfer irq status to irq thread. This was done as a work around for dropped + interrupts seen with IRQF_ONESHOT based handling. + + This needs further investigation and fixing properly, with the aid of + C&M and StarFive engineers. + +* Fix early end of stream handling + + When using a gstreamer pipeline like this: + gst-launch-1.0 filesrc location=<file> ! parsebin ! h264parse ! v4l2h264dec ! jpegenc ! identity eos-after=3 ! multifilesink location=%05d.jpeg + i.e. forced eos after 3 buffers + the pipeline stalls on exit waiting for end of job. + We need to add some form of early exit detection, instead of the current + behaviour of only considering a job finish on PIC_END. + +* Support more formats + + The current frontend v4l2 layer only supports V4L2_PIX_FMT_HEVC and + V4L2_PIX_FMT_H264. + The backend logic supports other formats, so we should wire up the support + for further bitsream formats. -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>, Robert Beckett <bob.beckett@collabora.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list), laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, kiril.bicevski@collabora.com, Nas Chung <nas.chung@chipsnmedia.com>, lafley.kim@chipsnmedia.com, scott.woo@chipsnmedia.com, olivier.crete@collabora.com Subject: [PATCH 4/6] staging: wave5: Add TODO file Date: Wed, 15 Sep 2021 18:23:22 +0200 [thread overview] Message-ID: <20210915162324.25513-5-dafna.hirschfeld@collabora.com> (raw) In-Reply-To: <20210915162324.25513-1-dafna.hirschfeld@collabora.com> Add a TODO file listing all that is need for destaging. Signed-off-by: Robert Beckett <bob.beckett@collabora.com> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- drivers/staging/media/wave5/TODO | 42 ++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 drivers/staging/media/wave5/TODO diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO new file mode 100644 index 000000000000..7e94e8dcedcf --- /dev/null +++ b/drivers/staging/media/wave5/TODO @@ -0,0 +1,42 @@ +* Test on real silicon once available + + This driver has so far been tested on pre-silicon FPGA and on the beta BeagleV + board which uses the StarFive JH7100 beta SoC. + + Testing on FPGA shows it working fine, though the FPGA uses polled interrupts + and copied buffers between the host and it's on board RAM. + + Testing on BeagleV shows buffer corruption that is currently attributed to a + known silicon issue in the SoC that makes the cache coherent interconnect not + so coherent. + This can likely be solved when the riscv non-coherent dma support lands and + provide optional v4l2 non-contiguous allocator, though it remains to be seen + whether support non-coherent use cases will be useful in real world hw. + + Until we can test and resolve any issues on final silicon (due 2H 2021) + this driver should remain in staging. + +* Handle interrupts better + + Currently the interrupt handling uses an unusual design employing a kfifo to + transfer irq status to irq thread. This was done as a work around for dropped + interrupts seen with IRQF_ONESHOT based handling. + + This needs further investigation and fixing properly, with the aid of + C&M and StarFive engineers. + +* Fix early end of stream handling + + When using a gstreamer pipeline like this: + gst-launch-1.0 filesrc location=<file> ! parsebin ! h264parse ! v4l2h264dec ! jpegenc ! identity eos-after=3 ! multifilesink location=%05d.jpeg + i.e. forced eos after 3 buffers + the pipeline stalls on exit waiting for end of job. + We need to add some form of early exit detection, instead of the current + behaviour of only considering a job finish on PIC_END. + +* Support more formats + + The current frontend v4l2 layer only supports V4L2_PIX_FMT_HEVC and + V4L2_PIX_FMT_H264. + The backend logic supports other formats, so we should wire up the support + for further bitsream formats. -- 2.17.1
next prev parent reply other threads:[~2021-09-15 16:24 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-15 16:23 [PATCH 0/6] staging: media: wave5: add wave5 codec driver Dafna Hirschfeld 2021-09-15 16:23 ` Dafna Hirschfeld 2021-09-15 16:23 ` [PATCH 1/6] staging: media: wave5: Add vpuapi layer Dafna Hirschfeld 2021-09-15 16:23 ` Dafna Hirschfeld 2021-09-16 11:10 ` Dan Carpenter 2021-09-16 11:10 ` Dan Carpenter 2021-09-15 16:23 ` [PATCH 2/6] staging: media: wave5: Add the vdi layer Dafna Hirschfeld 2021-09-15 16:23 ` Dafna Hirschfeld 2021-09-16 5:05 ` Ezequiel Garcia 2021-09-16 5:05 ` Ezequiel Garcia 2021-09-15 16:23 ` [PATCH 3/6] staging: media: wave5: Add the v4l2 layer Dafna Hirschfeld 2021-09-15 16:23 ` Dafna Hirschfeld 2021-09-16 4:50 ` Ezequiel Garcia 2021-09-16 4:50 ` Ezequiel Garcia 2021-09-16 13:14 ` Nicolas Dufresne 2021-09-16 13:14 ` Nicolas Dufresne 2021-09-16 12:48 ` kernel test robot 2021-09-16 12:48 ` kernel test robot 2021-09-15 16:23 ` Dafna Hirschfeld [this message] 2021-09-15 16:23 ` [PATCH 4/6] staging: wave5: Add TODO file Dafna Hirschfeld 2021-09-15 16:23 ` [PATCH 5/6] dt-bindings: media: staging: wave5: add yaml devicetree bindings Dafna Hirschfeld 2021-09-15 16:23 ` Dafna Hirschfeld 2021-09-15 16:23 ` [PATCH 6/6] media: wave5: Add wave5 driver to maintainers file Dafna Hirschfeld 2021-09-15 16:23 ` Dafna Hirschfeld 2021-09-16 12:38 ` [PATCH 0/6] staging: media: wave5: add wave5 codec driver Daniel Palmer 2021-09-16 12:38 ` Daniel Palmer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210915162324.25513-5-dafna.hirschfeld@collabora.com \ --to=dafna.hirschfeld@collabora.com \ --cc=bob.beckett@collabora.com \ --cc=dafna3@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=hverkuil@xs4all.nl \ --cc=kernel@collabora.com \ --cc=kiril.bicevski@collabora.com \ --cc=lafley.kim@chipsnmedia.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=mchehab@kernel.org \ --cc=nas.chung@chipsnmedia.com \ --cc=olivier.crete@collabora.com \ --cc=scott.woo@chipsnmedia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.