All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: linux-rockchip@lists.infradead.org
Cc: Heiko Stuebner <heiko@sntech.de>,
	ivan@ivan.computer, punitagrawal@gmail.com,
	Michael Riesch <michael.riesch@wolfvision.net>
Subject: [RFC PATCH 0/3] net: stmmac: dwmac-rk: use stmmac helper functions and clean up
Date: Wed, 15 Sep 2021 19:02:52 +0200	[thread overview]
Message-ID: <20210915170255.30561-1-michael.riesch@wolfvision.net> (raw)

Hi all,

This series aims to clean up the dwmac-rk glue driver by
making the stmmac core responsible for clock and power management.
The dwmac-rk specific code is passed to the core via callbacks.
The patches have been tested successfully on a RK3568 EVB1.

With any luck, the patches fix the Ethernet regression on different
RK3399 boards, which has been introduced recently in v5.14 -- but
don't be disappointed if that is not the case :-)

The series is marked as RFC since the handling of the (internal) phy
is not quite clear yet. Should rk_gmac_{init,exit} still consider
device_may_wakeup at some point? Should the glue driver power on/off
the external phy in the first place? Or will the stmmac core take
care of it?

Also, I am sending this RFC to linux-rockchip exclusively on purpose
as I would like to see some test results on other boards before
proceeding.

As an addition, the usage of clk_bulk_* functions is envisaged but
not yet implemented due to time constraints.

Looking forward to your comments!

Best regards,
Michael

Michael Riesch (3):
  net: stmmac: dwmac-rk: use stmmac helper functions for pm ops and
    remove
  net: stmmac: dwmac-rk: clean up includes
  net: stmmac: dwmac-rk: use stmmac helper functions for clock
    management

 .../net/ethernet/stmicro/stmmac/dwmac-rk.c    | 117 +++++-------------
 1 file changed, 32 insertions(+), 85 deletions(-)

-- 
2.17.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

             reply	other threads:[~2021-09-15 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 17:02 Michael Riesch [this message]
2021-09-15 17:02 ` [RFC PATCH 1/3] net: stmmac: dwmac-rk: use stmmac helper functions for pm ops and remove Michael Riesch
2021-09-21 14:23   ` Heiko Stuebner
2021-09-15 17:02 ` [RFC PATCH 2/3] net: stmmac: dwmac-rk: clean up includes Michael Riesch
2021-09-21 14:34   ` Heiko Stuebner
2021-09-15 17:02 ` [RFC PATCH 3/3] net: stmmac: dwmac-rk: use stmmac helper functions for clock management Michael Riesch
2021-09-15 23:29 ` [RFC PATCH 0/3] net: stmmac: dwmac-rk: use stmmac helper functions and clean up Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210915170255.30561-1-michael.riesch@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=heiko@sntech.de \
    --cc=ivan@ivan.computer \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=punitagrawal@gmail.com \
    --subject='Re: [RFC PATCH 0/3] net: stmmac: dwmac-rk: use stmmac helper functions and clean up' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.