* [PATCH] drm/tegra: plane: Improve use of dev_err_probe()
@ 2021-09-16 7:37 Cai Huoqing
2023-04-04 12:14 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Cai Huoqing @ 2021-09-16 7:37 UTC (permalink / raw)
To: caihuoqing
Cc: Thierry Reding, David Airlie, Daniel Vetter, Jonathan Hunter,
dri-devel, linux-tegra, linux-kernel
Return dev_err_probe() directly, because the return value of
dev_err_probe() is the appropriate error code, and it can
reduce code size, simplify the code.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/gpu/drm/tegra/plane.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/tegra/plane.c b/drivers/gpu/drm/tegra/plane.c
index e00ec3f40ec8..e373411b1f0b 100644
--- a/drivers/gpu/drm/tegra/plane.c
+++ b/drivers/gpu/drm/tegra/plane.c
@@ -744,21 +744,17 @@ int tegra_plane_interconnect_init(struct tegra_plane *plane)
plane->icc_mem = devm_of_icc_get(dev, icc_name);
err = PTR_ERR_OR_ZERO(plane->icc_mem);
- if (err) {
- dev_err_probe(dev, err, "failed to get %s interconnect\n",
- icc_name);
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err, "failed to get %s interconnect\n",
+ icc_name);
/* plane B on T20/30 has a dedicated memory client for a 6-tap vertical filter */
if (plane->index == 1 && dc->soc->has_win_b_vfilter_mem_client) {
plane->icc_mem_vfilter = devm_of_icc_get(dev, "winb-vfilter");
err = PTR_ERR_OR_ZERO(plane->icc_mem_vfilter);
- if (err) {
- dev_err_probe(dev, err, "failed to get %s interconnect\n",
- "winb-vfilter");
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err, "failed to get %s interconnect\n",
+ "winb-vfilter");
}
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/tegra: plane: Improve use of dev_err_probe()
2021-09-16 7:37 [PATCH] drm/tegra: plane: Improve use of dev_err_probe() Cai Huoqing
@ 2023-04-04 12:14 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2023-04-04 12:14 UTC (permalink / raw)
To: Cai Huoqing
Cc: David Airlie, linux-kernel, dri-devel, Jonathan Hunter,
Thierry Reding, linux-tegra
From: Thierry Reding <treding@nvidia.com>
On Thu, 16 Sep 2021 15:37:21 +0800, Cai Huoqing wrote:
> Return dev_err_probe() directly, because the return value of
> dev_err_probe() is the appropriate error code, and it can
> reduce code size, simplify the code.
>
>
Applied, thanks!
[1/1] drm/tegra: plane: Improve use of dev_err_probe()
commit: d94e2de7bdb19ae76d9deb541999cff171e14931
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/tegra: plane: Improve use of dev_err_probe()
@ 2023-04-04 12:14 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2023-04-04 12:14 UTC (permalink / raw)
To: Cai Huoqing
Cc: Daniel Vetter, Thierry Reding, Jonathan Hunter, linux-tegra,
dri-devel, David Airlie, linux-kernel
From: Thierry Reding <treding@nvidia.com>
On Thu, 16 Sep 2021 15:37:21 +0800, Cai Huoqing wrote:
> Return dev_err_probe() directly, because the return value of
> dev_err_probe() is the appropriate error code, and it can
> reduce code size, simplify the code.
>
>
Applied, thanks!
[1/1] drm/tegra: plane: Improve use of dev_err_probe()
commit: d94e2de7bdb19ae76d9deb541999cff171e14931
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-04 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 7:37 [PATCH] drm/tegra: plane: Improve use of dev_err_probe() Cai Huoqing
2023-04-04 12:14 ` Thierry Reding
2023-04-04 12:14 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.