All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] fs: btrfs: avoid superfluous messages
@ 2021-09-16  8:02 Heinrich Schuchardt
  2021-09-16 12:01 ` Marek Behún
  0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-09-16  8:02 UTC (permalink / raw)
  To: Marek Behun, Qu Wenruo; +Cc: linux-btrfs, u-boot, Heinrich Schuchardt

Output like the following is quite irritating:

    => bootefi hello
    Scanning disk mmc2.blk...
    No valid Btrfs found
    Bad magic number for SquashFS image.
    ** Unrecognized filesystem type **
    Scanning disk mmc1.blk...
    No valid Btrfs found
    Bad magic number for SquashFS image.
    ** Unrecognized filesystem type **
    Scanning disk mmc0.blk...
    No valid Btrfs found
    Bad magic number for SquashFS image.
    ** Unrecognized filesystem type **

It is expected that most partitions don't contain a Btrfs. This is only
worth a debug message.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 fs/btrfs/disk-io.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 12f9579fcf..7a4fb0d259 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0+
 #include <common.h>
 #include <fs_internal.h>
+#include <log.h>
 #include <uuid.h>
 #include <memalign.h>
 #include "kernel-shared/btrfs_tree.h"
@@ -918,7 +919,7 @@ static int btrfs_scan_fs_devices(struct blk_desc *desc,
 
 	ret = btrfs_scan_one_device(desc, part, fs_devices, &total_devs);
 	if (ret) {
-		fprintf(stderr, "No valid Btrfs found\n");
+		log_debug("No valid Btrfs found\n");
 		return ret;
 	}
 	return 0;
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] fs: btrfs: avoid superfluous messages
  2021-09-16  8:02 [PATCH 1/1] fs: btrfs: avoid superfluous messages Heinrich Schuchardt
@ 2021-09-16 12:01 ` Marek Behún
  2021-09-16 13:34   ` Tom Rini
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Behún @ 2021-09-16 12:01 UTC (permalink / raw)
  To: Heinrich Schuchardt, Simon Glass, Tom Rini; +Cc: Qu Wenruo, linux-btrfs, u-boot

On Thu, 16 Sep 2021 10:02:45 +0200
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:

Heinrich, Simon already sent patch
https://lore.kernel.org/u-boot/20210818214022.4.I3eb71025472bbb050bcf9a0a192dde1b6c07fa7f@changeid/

Tom, could you apply Simon's version?

Marek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] fs: btrfs: avoid superfluous messages
  2021-09-16 12:01 ` Marek Behún
@ 2021-09-16 13:34   ` Tom Rini
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-09-16 13:34 UTC (permalink / raw)
  To: Marek Behún
  Cc: Heinrich Schuchardt, Simon Glass, Qu Wenruo, linux-btrfs, u-boot

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On Thu, Sep 16, 2021 at 02:01:28PM +0200, Marek Behún wrote:

> On Thu, 16 Sep 2021 10:02:45 +0200
> Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
> 
> Heinrich, Simon already sent patch
> https://lore.kernel.org/u-boot/20210818214022.4.I3eb71025472bbb050bcf9a0a192dde1b6c07fa7f@changeid/
> 
> Tom, could you apply Simon's version?

Yes, I should probably do another round of -next patches today and I'll
grab that series.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-16 13:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16  8:02 [PATCH 1/1] fs: btrfs: avoid superfluous messages Heinrich Schuchardt
2021-09-16 12:01 ` Marek Behún
2021-09-16 13:34   ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.