* [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf
@ 2021-09-12 20:07 Fabrice Fontaine
2021-09-12 21:09 ` Giulio Benetti
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Fabrice Fontaine @ 2021-09-12 20:07 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Simon Dawson, Fabrice Fontaine
autoreconf (and so AM_ICONV) is not needed since commit
2df32e0d4437b422175089edf1917219656fccef
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/minicom/minicom.mk | 3 ---
1 file changed, 3 deletions(-)
diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk
index b81ee52120..5cd1d6b8b8 100644
--- a/package/minicom/minicom.mk
+++ b/package/minicom/minicom.mk
@@ -11,12 +11,9 @@ MINICOM_SITE = \
MINICOM_LICENSE = GPL-2.0+
MINICOM_LICENSE_FILES = COPYING
MINICOM_CPE_ID_VENDOR = minicom_project
-MINICOM_AUTORECONF = YES
MINICOM_DEPENDENCIES = ncurses $(if $(BR2_ENABLE_LOCALE),,libiconv) \
$(TARGET_NLS_DEPENDENCIES) host-pkgconf
-# add host-gettext for AM_ICONV macro
-MINICOM_DEPENDENCIES += host-gettext
MINICOM_CONF_OPTS = \
--enable-dfl-port=/dev/ttyS1 \
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf
2021-09-12 20:07 [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf Fabrice Fontaine
@ 2021-09-12 21:09 ` Giulio Benetti
2021-09-12 21:11 ` Giulio Benetti
2021-09-18 20:34 ` Yann E. MORIN
2021-09-29 19:59 ` Peter Korsgaard
2 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2021-09-12 21:09 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Simon Dawson
Hi Fabrice,
On 9/12/21 10:07 PM, Fabrice Fontaine wrote:
> autoreconf (and so AM_ICONV) is not needed since commit
> 2df32e0d4437b422175089edf1917219656fccef
Can you specify the upstream commit instead of the Buildroot one in
commit log?
Except that:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Best regards
--
Giulio Benetti
Benetti Engineering sas
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/minicom/minicom.mk | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk
> index b81ee52120..5cd1d6b8b8 100644
> --- a/package/minicom/minicom.mk
> +++ b/package/minicom/minicom.mk
> @@ -11,12 +11,9 @@ MINICOM_SITE = \
> MINICOM_LICENSE = GPL-2.0+
> MINICOM_LICENSE_FILES = COPYING
> MINICOM_CPE_ID_VENDOR = minicom_project
> -MINICOM_AUTORECONF = YES
>
> MINICOM_DEPENDENCIES = ncurses $(if $(BR2_ENABLE_LOCALE),,libiconv) \
> $(TARGET_NLS_DEPENDENCIES) host-pkgconf
> -# add host-gettext for AM_ICONV macro
> -MINICOM_DEPENDENCIES += host-gettext
>
> MINICOM_CONF_OPTS = \
> --enable-dfl-port=/dev/ttyS1 \
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf
2021-09-12 21:09 ` Giulio Benetti
@ 2021-09-12 21:11 ` Giulio Benetti
2021-09-12 21:33 ` Fabrice Fontaine
0 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2021-09-12 21:11 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Simon Dawson
On 9/12/21 11:09 PM, Giulio Benetti wrote:
> Hi Fabrice,
>
> On 9/12/21 10:07 PM, Fabrice Fontaine wrote:
>> autoreconf (and so AM_ICONV) is not needed since commit
>> 2df32e0d4437b422175089edf1917219656fccef
>
> Can you specify the upstream commit instead of the Buildroot one in
> commit log?
Ah yeah, with a link too.
Thanks a lot
--
Giulio Benetti
Benetti Engineering sas
>
> Except that:
>
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>
> Best regards
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf
2021-09-12 21:11 ` Giulio Benetti
@ 2021-09-12 21:33 ` Fabrice Fontaine
2021-09-12 21:40 ` Giulio Benetti
0 siblings, 1 reply; 7+ messages in thread
From: Fabrice Fontaine @ 2021-09-12 21:33 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Simon Dawson, Buildroot Mailing List
Hi Giulio,
Le dim. 12 sept. 2021 à 23:11, Giulio Benetti
<giulio.benetti@benettiengineering.com> a écrit :
>
> On 9/12/21 11:09 PM, Giulio Benetti wrote:
> > Hi Fabrice,
> >
> > On 9/12/21 10:07 PM, Fabrice Fontaine wrote:
> >> autoreconf (and so AM_ICONV) is not needed since commit
> >> 2df32e0d4437b422175089edf1917219656fccef
> >
> > Can you specify the upstream commit instead of the Buildroot one in
> > commit log?
There is no upstream commit, we can drop autoreconf, because we're
using the official tarball which provides a configure script since
buildroot commit 2df32e0d4437b422175089edf1917219656fccef.
>
> Ah yeah, with a link too.
>
> Thanks a lot
>
> --
> Giulio Benetti
> Benetti Engineering sas
>
> >
> > Except that:
> >
> > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> >
> > Best regards
> >
>
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf
2021-09-12 21:33 ` Fabrice Fontaine
@ 2021-09-12 21:40 ` Giulio Benetti
0 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2021-09-12 21:40 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Simon Dawson, Buildroot Mailing List
Hi Fabrice,
On 9/12/21 11:33 PM, Fabrice Fontaine wrote:
> Hi Giulio,
>
> Le dim. 12 sept. 2021 à 23:11, Giulio Benetti
> <giulio.benetti@benettiengineering.com> a écrit :
>>
>> On 9/12/21 11:09 PM, Giulio Benetti wrote:
>>> Hi Fabrice,
>>>
>>> On 9/12/21 10:07 PM, Fabrice Fontaine wrote:
>>>> autoreconf (and so AM_ICONV) is not needed since commit
>>>> 2df32e0d4437b422175089edf1917219656fccef
>>>
>>> Can you specify the upstream commit instead of the Buildroot one in
>>> commit log?
> There is no upstream commit, we can drop autoreconf, because we're
> using the official tarball which provides a configure script since
> buildroot commit 2df32e0d4437b422175089edf1917219656fccef.
Ah, pardon, you're right, it's the tarball and it contains configure
script already generated, so no upstream commit. Fine.
Thank you and
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Kind regards
--
Giulio Benetti
Benetti Engineering sas
>>
>> Ah yeah, with a link too.
>>
>> Thanks a lot
>>
>> --
>> Giulio Benetti
>> Benetti Engineering sas
>>
>>>
>>> Except that:
>>>
>>> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>>
>>> Best regards
>>>
>>
> Best Regards,
>
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf
2021-09-12 20:07 [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf Fabrice Fontaine
2021-09-12 21:09 ` Giulio Benetti
@ 2021-09-18 20:34 ` Yann E. MORIN
2021-09-29 19:59 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2021-09-18 20:34 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Giulio Benetti, Simon Dawson, buildroot
Fabrice, All,
On 2021-09-12 22:07 +0200, Fabrice Fontaine spake thusly:
> autoreconf (and so AM_ICONV) is not needed since commit
> 2df32e0d4437b422175089edf1917219656fccef
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/minicom/minicom.mk | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk
> index b81ee52120..5cd1d6b8b8 100644
> --- a/package/minicom/minicom.mk
> +++ b/package/minicom/minicom.mk
> @@ -11,12 +11,9 @@ MINICOM_SITE = \
> MINICOM_LICENSE = GPL-2.0+
> MINICOM_LICENSE_FILES = COPYING
> MINICOM_CPE_ID_VENDOR = minicom_project
> -MINICOM_AUTORECONF = YES
>
> MINICOM_DEPENDENCIES = ncurses $(if $(BR2_ENABLE_LOCALE),,libiconv) \
> $(TARGET_NLS_DEPENDENCIES) host-pkgconf
> -# add host-gettext for AM_ICONV macro
> -MINICOM_DEPENDENCIES += host-gettext
>
> MINICOM_CONF_OPTS = \
> --enable-dfl-port=/dev/ttyS1 \
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf
2021-09-12 20:07 [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf Fabrice Fontaine
2021-09-12 21:09 ` Giulio Benetti
2021-09-18 20:34 ` Yann E. MORIN
@ 2021-09-29 19:59 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2021-09-29 19:59 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Giulio Benetti, Simon Dawson, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> autoreconf (and so AM_ICONV) is not needed since commit
> 2df32e0d4437b422175089edf1917219656fccef
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-29 20:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-12 20:07 [Buildroot] [PATCH 1/1] package/minicom: drop autoreconf Fabrice Fontaine
2021-09-12 21:09 ` Giulio Benetti
2021-09-12 21:11 ` Giulio Benetti
2021-09-12 21:33 ` Fabrice Fontaine
2021-09-12 21:40 ` Giulio Benetti
2021-09-18 20:34 ` Yann E. MORIN
2021-09-29 19:59 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.