All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64
@ 2021-09-12 23:08 Giulio Benetti
  2021-09-12 23:55 ` Giulio Benetti
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Giulio Benetti @ 2021-09-12 23:08 UTC (permalink / raw)
  To: buildroot; +Cc: Pierre Floury, Giulio Benetti

Trace-cmd needs -fPIC for Sparc64 platform otherwise it fails on linking,
so add -fPIC to CFLAGS when building for such platform.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/trace-cmd/trace-cmd.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/trace-cmd/trace-cmd.mk b/package/trace-cmd/trace-cmd.mk
index cd3fcb9755..bc431e5dd2 100644
--- a/package/trace-cmd/trace-cmd.mk
+++ b/package/trace-cmd/trace-cmd.mk
@@ -31,6 +31,11 @@ endif
 # redefining it on the command line causes build problems.
 TRACE_CMD_CFLAGS = $(filter-out -D_LARGEFILE64_SOURCE,$(TARGET_CFLAGS))
 
+# Sparc64 needs -fPIC
+ifeq ($(BR2_sparc64),y)
+TRACE_CMD_CFLAGS += -fPIC
+endif
+
 # trace-cmd use CPPFLAGS to add some extra flags.
 # But like for CFLAGS, $(TARGET_CPPFLAGS) contains _LARGEFILE64_SOURCE
 # that causes build problems.
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64
  2021-09-12 23:08 [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64 Giulio Benetti
@ 2021-09-12 23:55 ` Giulio Benetti
  2021-09-18 20:41 ` Yann E. MORIN
  2021-10-04 11:00 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Giulio Benetti @ 2021-09-12 23:55 UTC (permalink / raw)
  To: buildroot; +Cc: Pierre Floury

On 9/13/21 1:08 AM, Giulio Benetti wrote:
> Trace-cmd needs -fPIC for Sparc64 platform otherwise it fails on linking,
> so add -fPIC to CFLAGS when building for such platform.
> 

Fixes:
http://autobuild.buildroot.net/results/c59/c596f6308b7f4d44d9ba009ed0c395396fc72f47/

I've forgotten this ^^^, can you please add/reword it while applying 
patch? Otherwise let me know and I'll send a v2.

Thank you
Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/trace-cmd/trace-cmd.mk | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/package/trace-cmd/trace-cmd.mk b/package/trace-cmd/trace-cmd.mk
> index cd3fcb9755..bc431e5dd2 100644
> --- a/package/trace-cmd/trace-cmd.mk
> +++ b/package/trace-cmd/trace-cmd.mk
> @@ -31,6 +31,11 @@ endif
>   # redefining it on the command line causes build problems.
>   TRACE_CMD_CFLAGS = $(filter-out -D_LARGEFILE64_SOURCE,$(TARGET_CFLAGS))
>   
> +# Sparc64 needs -fPIC
> +ifeq ($(BR2_sparc64),y)
> +TRACE_CMD_CFLAGS += -fPIC
> +endif
> +
>   # trace-cmd use CPPFLAGS to add some extra flags.
>   # But like for CFLAGS, $(TARGET_CPPFLAGS) contains _LARGEFILE64_SOURCE
>   # that causes build problems.
> 

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64
  2021-09-12 23:08 [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64 Giulio Benetti
  2021-09-12 23:55 ` Giulio Benetti
@ 2021-09-18 20:41 ` Yann E. MORIN
  2021-10-04 11:00 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-09-18 20:41 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Pierre Floury, buildroot

Giulio, All,

On 2021-09-13 01:08 +0200, Giulio Benetti spake thusly:
> Trace-cmd needs -fPIC for Sparc64 platform otherwise it fails on linking,
> so add -fPIC to CFLAGS when building for such platform.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Applied to master with the autobuiild reference added to the commit
log, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/trace-cmd/trace-cmd.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/trace-cmd/trace-cmd.mk b/package/trace-cmd/trace-cmd.mk
> index cd3fcb9755..bc431e5dd2 100644
> --- a/package/trace-cmd/trace-cmd.mk
> +++ b/package/trace-cmd/trace-cmd.mk
> @@ -31,6 +31,11 @@ endif
>  # redefining it on the command line causes build problems.
>  TRACE_CMD_CFLAGS = $(filter-out -D_LARGEFILE64_SOURCE,$(TARGET_CFLAGS))
>  
> +# Sparc64 needs -fPIC
> +ifeq ($(BR2_sparc64),y)
> +TRACE_CMD_CFLAGS += -fPIC
> +endif
> +
>  # trace-cmd use CPPFLAGS to add some extra flags.
>  # But like for CFLAGS, $(TARGET_CPPFLAGS) contains _LARGEFILE64_SOURCE
>  # that causes build problems.
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64
  2021-09-12 23:08 [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64 Giulio Benetti
  2021-09-12 23:55 ` Giulio Benetti
  2021-09-18 20:41 ` Yann E. MORIN
@ 2021-10-04 11:00 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2021-10-04 11:00 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Pierre Floury, buildroot

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Trace-cmd needs -fPIC for Sparc64 platform otherwise it fails on linking,
 > so add -fPIC to CFLAGS when building for such platform.

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-04 11:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-12 23:08 [Buildroot] [PATCH] package/trace-cmd: fix build for Sparc64 Giulio Benetti
2021-09-12 23:55 ` Giulio Benetti
2021-09-18 20:41 ` Yann E. MORIN
2021-10-04 11:00 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.