All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] arm64: DT: qcom: msm8998: Provide missing "xo" and "sleep_clk" to GCC
@ 2021-09-18 14:35 Marijn Suijten
  2021-09-18 23:06 ` Marijn Suijten
  0 siblings, 1 reply; 2+ messages in thread
From: Marijn Suijten @ 2021-09-18 14:35 UTC (permalink / raw)
  To: phone-devel, Rob Herring
  Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
	Konrad Dybcio, Martin Botka, Jami Kettunen, Marijn Suijten,
	Stephen Boyd, Andy Gross, Bjorn Andersson, linux-arm-msm,
	devicetree, linux-kernel

In a future patch the GCC driver will stop requesting this xo clock by
its global "xo" name, in favour of of having an explicit phandle here in
the DT.  Aside from that this clock in addition to the mandatory
"sleep_clk" were never passed despite being required by the relevant
dt-bindings.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
Resending to directly address Rob Herring in the To: field and add
Stephen Boyd to cc whom already queued the clk driver part in clk-next.

 arch/arm64/boot/dts/qcom/msm8998.dtsi | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index e9d3ce29937c..05ac5172fcba 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -117,7 +117,7 @@ xo: xo-board {
 			clock-output-names = "xo_board";
 		};
 
-		sleep_clk {
+		sleep_clk: sleep-clk {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
 			clock-frequency = <32764>;
@@ -855,6 +855,9 @@ gcc: clock-controller@100000 {
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;
 			reg = <0x00100000 0xb0000>;
+
+			clock-names = "xo", "sleep_clk";
+			clocks = <&xo>, <&sleep_clk>;
 		};
 
 		rpm_msg_ram: memory@778000 {
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RESEND PATCH] arm64: DT: qcom: msm8998: Provide missing "xo" and "sleep_clk" to GCC
  2021-09-18 14:35 [RESEND PATCH] arm64: DT: qcom: msm8998: Provide missing "xo" and "sleep_clk" to GCC Marijn Suijten
@ 2021-09-18 23:06 ` Marijn Suijten
  0 siblings, 0 replies; 2+ messages in thread
From: Marijn Suijten @ 2021-09-18 23:06 UTC (permalink / raw)
  To: phone-devel, Rob Herring
  Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
	Konrad Dybcio, Martin Botka, Jami Kettunen, Stephen Boyd,
	Andy Gross, Bjorn Andersson, linux-arm-msm, devicetree,
	linux-kernel

On 2021-09-18 16:35:02, Marijn Suijten wrote:
> In a future patch the GCC driver will stop requesting this xo clock by
> its global "xo" name, in favour of of having an explicit phandle here in
> the DT.  Aside from that this clock in addition to the mandatory
> "sleep_clk" were never passed despite being required by the relevant
> dt-bindings.
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> Resending to directly address Rob Herring in the To: field and add
> Stephen Boyd to cc whom already queued the clk driver part in clk-next.

Apologies for the re-send noise; this patch is already going in through
the qcom tree:
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=2c2f64ae36d97c1ec756ed781640f7951f7bac42

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-18 23:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-18 14:35 [RESEND PATCH] arm64: DT: qcom: msm8998: Provide missing "xo" and "sleep_clk" to GCC Marijn Suijten
2021-09-18 23:06 ` Marijn Suijten

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.