[RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

[RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

[Richard Purdie]

This is a controversial change which removes the recursive dependencies
from the do_build target of packaging tasks of recipes.

Currently this means when you "bitbake <image>" or "bitbake <recipe>",
the packaging tasks run for all packaging backends enabled for all recipes
in the dependency chain. The same therefore then applies to images.

We don't actually need that, it is a convinience thing. Removing it
massively simplifies the task graph and causes much fewer tasks to execute
in many common scenarios. It also means less sstate is fetched for
example when building an image.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/package_deb.bbclass | 2 --
 meta/classes/package_ipk.bbclass | 2 --
 meta/classes/package_rpm.bbclass | 2 --
 3 files changed, 6 deletions(-)

diff --git a/meta/classes/package_deb.bbclass b/meta/classes/package_deb.bbclass
index eca43e17876..8f0eadbcd2e 100644
--- a/meta/classes/package_deb.bbclass
+++ b/meta/classes/package_deb.bbclass
@@ -320,5 +320,3 @@ addtask package_write_deb after do_packagedata do_package
 
 PACKAGEINDEXDEPS += "dpkg-native:do_populate_sysroot"
 PACKAGEINDEXDEPS += "apt-native:do_populate_sysroot"
-
-do_build[recrdeptask] += "do_package_write_deb"
diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
index c3b53854e8b..756744279e1 100644
--- a/meta/classes/package_ipk.bbclass
+++ b/meta/classes/package_ipk.bbclass
@@ -278,5 +278,3 @@ addtask package_write_ipk after do_packagedata do_package
 
 PACKAGEINDEXDEPS += "opkg-utils-native:do_populate_sysroot"
 PACKAGEINDEXDEPS += "opkg-native:do_populate_sysroot"
-
-do_build[recrdeptask] += "do_package_write_ipk"
diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
index 88d861c0e75..9f415b234de 100644
--- a/meta/classes/package_rpm.bbclass
+++ b/meta/classes/package_rpm.bbclass
@@ -752,5 +752,3 @@ addtask package_write_rpm after do_packagedata do_package
 
 PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
 PACKAGEINDEXDEPS += "createrepo-c-native:do_populate_sysroot"
-
-do_build[recrdeptask] += "do_package_write_rpm"
-- 
2.32.0

Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

[Joshua Watt]

On Sun, Sep 19, 2021 at 5:57 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> This is a controversial change which removes the recursive dependencies
> from the do_build target of packaging tasks of recipes.
>
> Currently this means when you "bitbake <image>" or "bitbake <recipe>",
> the packaging tasks run for all packaging backends enabled for all recipes
> in the dependency chain. The same therefore then applies to images.
>
> We don't actually need that, it is a convinience thing. Removing it
> massively simplifies the task graph and causes much fewer tasks to execute
> in many common scenarios. It also means less sstate is fetched for
> example when building an image.

Faster builds in the common cases seems like a great idea!

If someone really needs the old behavior, is there a mechanism to do
the equivalent to what it was doing?

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/package_deb.bbclass | 2 --
>  meta/classes/package_ipk.bbclass | 2 --
>  meta/classes/package_rpm.bbclass | 2 --
>  3 files changed, 6 deletions(-)
>
> diff --git a/meta/classes/package_deb.bbclass b/meta/classes/package_deb.bbclass
> index eca43e17876..8f0eadbcd2e 100644
> --- a/meta/classes/package_deb.bbclass
> +++ b/meta/classes/package_deb.bbclass
> @@ -320,5 +320,3 @@ addtask package_write_deb after do_packagedata do_package
>
>  PACKAGEINDEXDEPS += "dpkg-native:do_populate_sysroot"
>  PACKAGEINDEXDEPS += "apt-native:do_populate_sysroot"
> -
> -do_build[recrdeptask] += "do_package_write_deb"
> diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
> index c3b53854e8b..756744279e1 100644
> --- a/meta/classes/package_ipk.bbclass
> +++ b/meta/classes/package_ipk.bbclass
> @@ -278,5 +278,3 @@ addtask package_write_ipk after do_packagedata do_package
>
>  PACKAGEINDEXDEPS += "opkg-utils-native:do_populate_sysroot"
>  PACKAGEINDEXDEPS += "opkg-native:do_populate_sysroot"
> -
> -do_build[recrdeptask] += "do_package_write_ipk"
> diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
> index 88d861c0e75..9f415b234de 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -752,5 +752,3 @@ addtask package_write_rpm after do_packagedata do_package
>
>  PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
>  PACKAGEINDEXDEPS += "createrepo-c-native:do_populate_sysroot"
> -
> -do_build[recrdeptask] += "do_package_write_rpm"
> --
> 2.32.0
>
>
> 
>

Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

[Richard Purdie]

On Mon, 2021-09-20 at 08:27 -0500, Joshua Watt wrote:
> On Sun, Sep 19, 2021 at 5:57 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > This is a controversial change which removes the recursive dependencies
> > from the do_build target of packaging tasks of recipes.
> > 
> > Currently this means when you "bitbake <image>" or "bitbake <recipe>",
> > the packaging tasks run for all packaging backends enabled for all recipes
> > in the dependency chain. The same therefore then applies to images.
> > 
> > We don't actually need that, it is a convinience thing. Removing it
> > massively simplifies the task graph and causes much fewer tasks to execute
> > in many common scenarios. It also means less sstate is fetched for
> > example when building an image.
> 
> Faster builds in the common cases seems like a great idea!
> 
> If someone really needs the old behavior, is there a mechanism to do
> the equivalent to what it was doing?

In this context, "bitbake XXX --runall build" would be equivalent to the current
"bitbake XXX".

Cheers,

Richard

Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

[Saul Wold]

On 9/20/21 6:54 AM, Richard Purdie wrote:
> On Mon, 2021-09-20 at 08:27 -0500, Joshua Watt wrote:
>> On Sun, Sep 19, 2021 at 5:57 AM Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>>>
>>> This is a controversial change which removes the recursive dependencies
>>> from the do_build target of packaging tasks of recipes.
>>>
>>> Currently this means when you "bitbake <image>" or "bitbake <recipe>",
>>> the packaging tasks run for all packaging backends enabled for all recipes
>>> in the dependency chain. The same therefore then applies to images.
>>>
>>> We don't actually need that, it is a convinience thing. Removing it
>>> massively simplifies the task graph and causes much fewer tasks to execute
>>> in many common scenarios. It also means less sstate is fetched for
>>> example when building an image.
>>
>> Faster builds in the common cases seems like a great idea!
>>
>> If someone really needs the old behavior, is there a mechanism to do
>> the equivalent to what it was doing?
> 
> In this context, "bitbake XXX --runall build" would be equivalent to the current
> "bitbake XXX".
> 
This is good, since it can be used to catch packaging issues when not 
all packages formats are getting built.  Will this be the default for 
the Autobuilder?  That would ensure packaging issues are caught?

The --runall should be required for anyone doing updates to ensure that 
all package formats are being generated correctly for the update.

Sau!

> Cheers,
> 
> Richard
> 
> 
> 
> 
> 

-- 
Sau!