Re: [PATCH] build: Fix compiler maybe-uninitialized warnings

[Daniel Wagner <wagi@monom.org>]

Hi Emmanuel,

On Mon, Sep 13, 2021 at 07:45:19AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> > > -             provision_service_wifi(config, service, network,
> > > -                                                     ssid, ssid_len);
> > > +             provision_service_wifi(config, service, network);
> 
> > Could you split this into cleanup patch with a commit message?
> In fact, all my modifications are fixes of maybe-uninitialized warnings.

My compiler doesn't report them (gcc11). What compiler do you use and
what are the compile flags?

> In this case, ssid is not initialized.
> I thought title was explicit enough, what can I had in my comment?

Something like

"""
config: Remove unused arguments from provision_service_wifi()


gcc-10 complains with:

  ...

Remove the ssid and ssid_len argument from provision_service() as they
are not used.
"""

I know it's pretty obvious right now, but having ten commits in a row
with 'fix foo' and 'fix bar' without any explanation makes any 'git
blame' 'git log' operation really painful in two months from now. Been
there done that.

BTW, I tried to trigger the warnings and I was not able to. Now I am
trying to fix up clang compile errors...

Daniel