All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willian Rampazzo <willianr@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>
Subject: [PATCH 1/6] Acceptance Tests: add standard clean up at test tearDown()
Date: Mon, 20 Sep 2021 17:49:27 -0300	[thread overview]
Message-ID: <20210920204932.94132-2-willianr@redhat.com> (raw)
In-Reply-To: <20210920204932.94132-1-willianr@redhat.com>

From: Cleber Rosa <crosa@redhat.com>

The avocado.Test class, used as the basis of the avocado_qemu.Test
class, performs a clean of temporary directories up as part of its own
tearDown() implementation.

But the avocado_qemu.Test class is currently missing the same clean
up, as it implemented its own tearDown() method without resorting to
the upper class behavior.

This brings avocado_qemu.Test behavior in sync with the standard
avocado.Test behavior and prevents temporary directories from
cluttering the test results directory (unless instructed to do so with
Avocado's "--keep-tmp" option).

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
[willianr: respin to new Python super format]
Signed-off-by: Willian Rampazzo <willianr@redhat.com>

---
v2
  - adjust super call to conform with PEP3135
---
 tests/acceptance/avocado_qemu/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index 2c4fef3e14..d9e1b32aa1 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -276,6 +276,7 @@ def tearDown(self):
         for vm in self._vms.values():
             vm.shutdown()
         self._sd = None
+        super().tearDown()
 
     def fetch_asset(self, name,
                     asset_hash=None, algorithm=None,
-- 
2.31.1



  reply	other threads:[~2021-09-20 20:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 20:49 [PATCH 0/6] avocado_qemu: small fixes and tweaks Willian Rampazzo
2021-09-20 20:49 ` Willian Rampazzo [this message]
2021-09-20 20:49 ` [PATCH 2/6] avocado_qemu: standardize supper() call following PEP3135 Willian Rampazzo
2021-09-20 20:55   ` Willian Rampazzo
2021-09-20 20:49 ` [PATCH 3/6] avocado_qemu: fix import module based on isort Willian Rampazzo
2021-09-20 20:49 ` [PATCH 4/6] avocado_qemu: tweak ssh connect method Willian Rampazzo
2021-09-27 14:12   ` Philippe Mathieu-Daudé
2021-09-27 14:39     ` Willian Rampazzo
2021-09-20 20:49 ` [PATCH 5/6] avocado_qemu: explicitly return None to avoid R1710 Willian Rampazzo
2021-09-20 20:49 ` [PATCH 6/6] avocado_qemu: fix inheritance order on LinuxTest class Willian Rampazzo
2021-09-27 14:13 ` [PATCH 0/6] avocado_qemu: small fixes and tweaks Philippe Mathieu-Daudé
2021-09-27 16:41 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920204932.94132-2-willianr@redhat.com \
    --to=willianr@redhat.com \
    --cc=crosa@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.