All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willian Rampazzo <willianr@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>
Subject: [PATCH 5/6] avocado_qemu: explicitly return None to avoid R1710
Date: Mon, 20 Sep 2021 17:49:31 -0300	[thread overview]
Message-ID: <20210920204932.94132-6-willianr@redhat.com> (raw)
In-Reply-To: <20210920204932.94132-1-willianr@redhat.com>

The linter is complaining the `pick_default_qemu_bin` is not explicitly
returning None. Fix it to explicitly return None and avoid R1710
inconsistent-return-statements.

Signed-off-by: Willian Rampazzo <willianr@redhat.com>
---
 tests/acceptance/avocado_qemu/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index c3613f9262..35318ce2a9 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -72,6 +72,7 @@ def pick_default_qemu_bin(arch=None):
                                               qemu_bin_relative_path)
     if is_readable_executable_file(qemu_bin_from_bld_dir_path):
         return qemu_bin_from_bld_dir_path
+    return None
 
 
 def _console_interaction(test, success_message, failure_message,
-- 
2.31.1



  parent reply	other threads:[~2021-09-20 20:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 20:49 [PATCH 0/6] avocado_qemu: small fixes and tweaks Willian Rampazzo
2021-09-20 20:49 ` [PATCH 1/6] Acceptance Tests: add standard clean up at test tearDown() Willian Rampazzo
2021-09-20 20:49 ` [PATCH 2/6] avocado_qemu: standardize supper() call following PEP3135 Willian Rampazzo
2021-09-20 20:55   ` Willian Rampazzo
2021-09-20 20:49 ` [PATCH 3/6] avocado_qemu: fix import module based on isort Willian Rampazzo
2021-09-20 20:49 ` [PATCH 4/6] avocado_qemu: tweak ssh connect method Willian Rampazzo
2021-09-27 14:12   ` Philippe Mathieu-Daudé
2021-09-27 14:39     ` Willian Rampazzo
2021-09-20 20:49 ` Willian Rampazzo [this message]
2021-09-20 20:49 ` [PATCH 6/6] avocado_qemu: fix inheritance order on LinuxTest class Willian Rampazzo
2021-09-27 14:13 ` [PATCH 0/6] avocado_qemu: small fixes and tweaks Philippe Mathieu-Daudé
2021-09-27 16:41 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920204932.94132-6-willianr@redhat.com \
    --to=willianr@redhat.com \
    --cc=crosa@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.