* [PATCH net] net: dsa: fix dsa_tree_setup error path
@ 2021-09-20 22:49 Vladimir Oltean
2021-09-21 10:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Oltean @ 2021-09-20 22:49 UTC (permalink / raw)
To: netdev
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski
Since the blamed commit, dsa_tree_teardown_switches() was split into two
smaller functions, dsa_tree_teardown_switches and dsa_tree_teardown_ports.
However, the error path of dsa_tree_setup stopped calling dsa_tree_teardown_ports.
Fixes: a57d8c217aad ("net: dsa: flush switchdev workqueue before tearing down CPU/DSA ports")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
net/dsa/dsa2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index f14897d9b31d..f54639a3a822 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -1089,6 +1089,7 @@ static int dsa_tree_setup(struct dsa_switch_tree *dst)
teardown_master:
dsa_tree_teardown_master(dst);
teardown_switches:
+ dsa_tree_teardown_ports(dst);
dsa_tree_teardown_switches(dst);
teardown_cpu_ports:
dsa_tree_teardown_cpu_ports(dst);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: dsa: fix dsa_tree_setup error path
2021-09-20 22:49 [PATCH net] net: dsa: fix dsa_tree_setup error path Vladimir Oltean
@ 2021-09-21 10:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-21 10:10 UTC (permalink / raw)
To: Vladimir Oltean
Cc: netdev, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 21 Sep 2021 01:49:18 +0300 you wrote:
> Since the blamed commit, dsa_tree_teardown_switches() was split into two
> smaller functions, dsa_tree_teardown_switches and dsa_tree_teardown_ports.
>
> However, the error path of dsa_tree_setup stopped calling dsa_tree_teardown_ports.
>
> Fixes: a57d8c217aad ("net: dsa: flush switchdev workqueue before tearing down CPU/DSA ports")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> [...]
Here is the summary with links:
- [net] net: dsa: fix dsa_tree_setup error path
https://git.kernel.org/netdev/net/c/e5845aa0eadd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-21 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 22:49 [PATCH net] net: dsa: fix dsa_tree_setup error path Vladimir Oltean
2021-09-21 10:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.