* [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF
@ 2021-09-22 8:58 Wolfram Sang
2021-09-23 8:55 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wolfram Sang @ 2021-09-22 8:58 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Krzysztof Kozlowski,
Rob Herring, Sergei Shtylyov, devicetree
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
.../devicetree/bindings/memory-controllers/renesas,rpc-if.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
index 990489fdd2ac..b15992ad3613 100644
--- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
@@ -33,6 +33,7 @@ properties:
- renesas,r8a77970-rpc-if # R-Car V3M
- renesas,r8a77980-rpc-if # R-Car V3H
- renesas,r8a77995-rpc-if # R-Car D3
+ - renesas,r8a779a0-rpc-if # R-Car V3U
- const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
reg:
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF
2021-09-22 8:58 [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF Wolfram Sang
@ 2021-09-23 8:55 ` Geert Uytterhoeven
2021-09-24 11:16 ` Krzysztof Kozlowski
2021-09-24 12:01 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-09-23 8:55 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux Kernel Mailing List, Linux-Renesas, Krzysztof Kozlowski,
Rob Herring, Sergei Shtylyov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Wed, Sep 22, 2021 at 10:59 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF
2021-09-22 8:58 [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF Wolfram Sang
2021-09-23 8:55 ` Geert Uytterhoeven
@ 2021-09-24 11:16 ` Krzysztof Kozlowski
2021-09-24 11:55 ` Geert Uytterhoeven
2021-09-24 12:01 ` Krzysztof Kozlowski
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 11:16 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: linux-renesas-soc, Rob Herring, Sergei Shtylyov, devicetree
On 22/09/2021 10:58, Wolfram Sang wrote:
Please write a short sentence after commit title.
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> .../devicetree/bindings/memory-controllers/renesas,rpc-if.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> index 990489fdd2ac..b15992ad3613 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> @@ -33,6 +33,7 @@ properties:
> - renesas,r8a77970-rpc-if # R-Car V3M
> - renesas,r8a77980-rpc-if # R-Car V3H
> - renesas,r8a77995-rpc-if # R-Car D3
> + - renesas,r8a779a0-rpc-if # R-Car V3U
> - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
Where is the driver or DTS using these compatibles? The bindings can
come even without users, but are you sure this is what you want?
Changing them later, if ever needed, will be more difficult.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF
2021-09-24 11:16 ` Krzysztof Kozlowski
@ 2021-09-24 11:55 ` Geert Uytterhoeven
2021-09-24 11:59 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-09-24 11:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wolfram Sang, Linux Kernel Mailing List, Linux-Renesas,
Rob Herring, Sergei Shtylyov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Krzysztof,
On Fri, Sep 24, 2021 at 1:48 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
> On 22/09/2021 10:58, Wolfram Sang wrote:
> > --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > @@ -33,6 +33,7 @@ properties:
> > - renesas,r8a77970-rpc-if # R-Car V3M
> > - renesas,r8a77980-rpc-if # R-Car V3H
> > - renesas,r8a77995-rpc-if # R-Car D3
> > + - renesas,r8a779a0-rpc-if # R-Car V3U
> > - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
>
> Where is the driver or DTS using these compatibles? The bindings can
> come even without users, but are you sure this is what you want?
> Changing them later, if ever needed, will be more difficult.
Driver:
drivers/memory/renesas-rpc-if.c: { .compatible =
"renesas,rcar-gen3-rpc-if", },
DTS:
[RFC PATCH 3/4] arm64: dts: renesas: r8a779a0: Add RPC node
https://lore.kernel.org/linux-renesas-soc/20210913065317.2297-4-wsa+renesas@sang-engineering.com/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF
2021-09-24 11:55 ` Geert Uytterhoeven
@ 2021-09-24 11:59 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 11:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Wolfram Sang, Linux Kernel Mailing List, Linux-Renesas,
Rob Herring, Sergei Shtylyov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On 24/09/2021 13:55, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Fri, Sep 24, 2021 at 1:48 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>> On 22/09/2021 10:58, Wolfram Sang wrote:
>>> --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
>>> @@ -33,6 +33,7 @@ properties:
>>> - renesas,r8a77970-rpc-if # R-Car V3M
>>> - renesas,r8a77980-rpc-if # R-Car V3H
>>> - renesas,r8a77995-rpc-if # R-Car D3
>>> + - renesas,r8a779a0-rpc-if # R-Car V3U
>>> - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
>>
>> Where is the driver or DTS using these compatibles? The bindings can
>> come even without users, but are you sure this is what you want?
>> Changing them later, if ever needed, will be more difficult.
>
> Driver:
> drivers/memory/renesas-rpc-if.c: { .compatible =
> "renesas,rcar-gen3-rpc-if", },
>
> DTS:
> [RFC PATCH 3/4] arm64: dts: renesas: r8a779a0: Add RPC node
> https://lore.kernel.org/linux-renesas-soc/20210913065317.2297-4-wsa+renesas@sang-engineering.com/
>
I see, thanks. It wasn't sent to main LKML so I did not find it in archives.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF
2021-09-22 8:58 [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF Wolfram Sang
2021-09-23 8:55 ` Geert Uytterhoeven
2021-09-24 11:16 ` Krzysztof Kozlowski
@ 2021-09-24 12:01 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 12:01 UTC (permalink / raw)
To: linux-kernel, Wolfram Sang
Cc: Krzysztof Kozlowski, Sergei Shtylyov, linux-renesas-soc,
devicetree, Rob Herring
On Wed, 22 Sep 2021 10:58:31 +0200, Wolfram Sang wrote:
>
Applied with added simple commit msg, thanks!
[1/1] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF
commit: 797f082738b10ff397c8d3b7804b747d766e62e6
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-24 12:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22 8:58 [PATCH] dt-bindings: rpc: renesas-rpc-if: Add support for the R8A779A0 RPC-IF Wolfram Sang
2021-09-23 8:55 ` Geert Uytterhoeven
2021-09-24 11:16 ` Krzysztof Kozlowski
2021-09-24 11:55 ` Geert Uytterhoeven
2021-09-24 11:59 ` Krzysztof Kozlowski
2021-09-24 12:01 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.