All of lore.kernel.org
 help / color / mirror / Atom feed
* Deploying new iterator interface for dma-buf
@ 2021-09-22  9:10 ` Christian König
  0 siblings, 0 replies; 88+ messages in thread
From: Christian König @ 2021-09-22  9:10 UTC (permalink / raw)
  To: linaro-mm-sig, dri-devel, linux-media, intel-gfx; +Cc: daniel, tvrtko.ursulin

Hi guys,

The version I've send out yesterday had a rather obvious coding error and I honestly forgot the cover letter.

This one here is better tested and will now hopefully not be torn apart from the CI system immediately.

I tried to address all review and documentation comments as best as I could, so I'm hoping that we can now considering pushing this.

Cheers,
Christian.



^ permalink raw reply	[flat|nested] 88+ messages in thread
* Deploying new iterator interface for dma-buf
@ 2021-10-05 11:37 Christian König
  0 siblings, 0 replies; 88+ messages in thread
From: Christian König @ 2021-10-05 11:37 UTC (permalink / raw)
  To: linaro-mm-sig, dri-devel, linux-media, intel-gfx; +Cc: daniel, tvrtko.ursulin

Hi guys,

a few more bug fixes, looks like the more selftests I add the more odies I find.

Assuming the CI tests now pass I will start pushing patches I've already got an rb for to drm-misc-next.

Please review and/or comment,
Christian.



^ permalink raw reply	[flat|nested] 88+ messages in thread
* Deploying new iterator interface for dma-buf
@ 2021-10-01 10:05 Christian König
  0 siblings, 0 replies; 88+ messages in thread
From: Christian König @ 2021-10-01 10:05 UTC (permalink / raw)
  To: linaro-mm-sig, dri-devel, linux-media, intel-gfx; +Cc: daniel, tvrtko.ursulin

Hi guys,

I've fixed up the lockdep splat in the new selftests found by the CI
systems and added another path for dma_resv_poll.

I know you guys are flooded, but can we get at least the first few patches
committed? The patches to change the individual drivers could also be pushed later on I think.

Thanks,
Christian.



^ permalink raw reply	[flat|nested] 88+ messages in thread
* Deploying new iterator interface for dma-buf
@ 2021-09-17 12:34 Christian König
  0 siblings, 0 replies; 88+ messages in thread
From: Christian König @ 2021-09-17 12:34 UTC (permalink / raw)
  To: linaro-mm-sig, dri-devel, linux-media, intel-gfx; +Cc: daniel

Hopefully the last round for this.

Added dma_resv_iter_begin/end as requested by Daniel. Fixed a bunch of
problems pointed out by the CI systems and found a few more myselve.

Please review and/or comment,
Christian.



^ permalink raw reply	[flat|nested] 88+ messages in thread
* Deploying new iterator interface for dma-buf
@ 2021-09-16 11:30 Christian König
  0 siblings, 0 replies; 88+ messages in thread
From: Christian König @ 2021-09-16 11:30 UTC (permalink / raw)
  To: linaro-mm-sig, dri-devel, linux-media, intel-gfx; +Cc: daniel, tvrtko.ursulin

Next round for that one here, maybe the CI systems are now more
gracefully with me :)

I'm pretty sure that a couple of those dma_resv_for_each_fence_unlocked
should actually be replaced with lock+dma_resv_for_each_fence, but that
needs more auditing.

Please review and comment.

Thanks,
Christian.



^ permalink raw reply	[flat|nested] 88+ messages in thread
* Deploying new iterator interface for dma-buf
@ 2021-09-13 13:16 Christian König
  0 siblings, 0 replies; 88+ messages in thread
From: Christian König @ 2021-09-13 13:16 UTC (permalink / raw)
  To: linaro-mm-sig, dri-devel, linux-media; +Cc: daniel, intel-gfx

Hi everybody,

we recently found that a good bunch of the RCU accesses to the dma_resv object are actually not correctly protected.

Those where fixed by either dropping the RCU approach and taking appropriate locks or using a central function to return the current fences as array and then work with that snapshot.

This set now tries to prevent adding any new broken code by rolling out two new interfaces to access the fences in a dma_resv object:

dma_resv_for_each_fence() - Iterator which should be used while holding the reservation lock.
dma_resv_for_each_fence_unlocked() - Iterator based on RCU which can be used without holding the reservation lock and automatic restart on concurrent modification.

While doing this we also move the decision which fences to use for write and read accesses into the dma_resv object which results in a quite nice code de-duplication and simplification.

The only two remaining users of the RCU shared fence interface are removing shared fences in amdkfd and debugfs code in qxl which will both be addresses in the next patch set.

Please review and/or comment,
Christian.



^ permalink raw reply	[flat|nested] 88+ messages in thread

end of thread, other threads:[~2021-10-05 11:37 UTC | newest]

Thread overview: 88+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22  9:10 Deploying new iterator interface for dma-buf Christian König
2021-09-22  9:10 ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4 Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22 14:36   ` Tvrtko Ursulin
2021-09-22 14:36     ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22 14:50     ` Christian König
2021-09-22 14:50       ` [Intel-gfx] " Christian König
2021-09-22 15:09       ` Tvrtko Ursulin
2021-09-22 15:09         ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22  9:10 ` [PATCH 02/26] dma-buf: add dma_resv_for_each_fence Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 03/26] dma-buf: use new iterator in dma_resv_copy_fences Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 04/26] dma-buf: use new iterator in dma_resv_get_fences v2 Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 05/26] dma-buf: use new iterator in dma_resv_wait_timeout Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 06/26] dma-buf: use new iterator in dma_resv_test_signaled Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 07/26] drm/ttm: use the new iterator in ttm_bo_flush_all_fences Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 08/26] drm/amdgpu: use the new iterator in amdgpu_sync_resv Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 09/26] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 10/26] drm/msm: use new iterator in msm_gem_describe Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 11/26] drm/radeon: use new iterator in radeon_sync_resv Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2 Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22 10:21   ` Tvrtko Ursulin
2021-09-22 10:21     ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22 11:46     ` Tvrtko Ursulin
2021-09-22 11:46       ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22 12:15       ` Christian König
2021-09-22 12:15         ` [Intel-gfx] " Christian König
2021-09-22 12:20         ` Tvrtko Ursulin
2021-09-22 12:20           ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22 12:22           ` Christian König
2021-09-22 12:22             ` [Intel-gfx] " Christian König
2021-09-22 14:31     ` Christian König
2021-09-22 14:31       ` [Intel-gfx] " Christian König
2021-09-22 14:39       ` Tvrtko Ursulin
2021-09-22 14:39         ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22  9:10 ` [PATCH 14/26] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3 Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object v2 Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22 10:34   ` Tvrtko Ursulin
2021-09-22 10:34     ` Tvrtko Ursulin
2021-09-22  9:10 ` [PATCH 16/26] drm/i915: use new iterator in i915_gem_object_wait_reservation Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 17/26] drm/i915: use new iterator in i915_gem_object_wait_priority Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22 10:27   ` Tvrtko Ursulin
2021-09-22 10:27     ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22 11:00     ` Christian König
2021-09-22 11:00       ` [Intel-gfx] " Christian König
2021-09-22 11:12       ` Tvrtko Ursulin
2021-09-22 11:12         ` [Intel-gfx] " Tvrtko Ursulin
2021-09-22  9:10 ` [PATCH 19/26] drm/i915: use new cursor in intel_prepare_plane_fb Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v3 Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 21/26] drm: use new iterator in drm_gem_plane_helper_prepare_fb Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 22/26] drm/nouveau: use the new iterator in nouveau_fence_sync Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 23/26] drm/nouveau: use the new interator in nv50_wndw_prepare_fb Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 24/26] drm/etnaviv: use new iterator in etnaviv_gem_describe Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 25/26] drm/etnaviv: replace dma_resv_get_excl_unlocked Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22  9:10 ` [PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked Christian König
2021-09-22  9:10   ` [Intel-gfx] " Christian König
2021-09-22 12:55 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4 Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-10-05 11:37 Deploying new iterator interface for dma-buf Christian König
2021-10-01 10:05 Christian König
2021-09-17 12:34 Christian König
2021-09-16 11:30 Christian König
2021-09-13 13:16 Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.