* [PATCH] leds: gpio: Always provide cdev->brightness_set_blocking()
@ 2021-09-22 17:21 Harald Seiler
2021-11-04 13:09 ` Harald Seiler
0 siblings, 1 reply; 2+ messages in thread
From: Harald Seiler @ 2021-09-22 17:21 UTC (permalink / raw)
To: Pavel Machek; +Cc: linux-leds, linux-kernel, Harald Seiler, Jacek Anaszewski
Even if the GPIO driver will never sleep, setting
cdev->brightness_set_blocking() makes sense so
led_set_brightness_sync() can be used with such LEDs.
Internally, both gpio_led_set_blocking() and gpio_led_set() call
the same implementation anyway.
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
Signed-off-by: Harald Seiler <hws@denx.de>
---
drivers/leds/leds-gpio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index b5d5e22d2d1e..bbe582e47607 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -79,11 +79,12 @@ static int create_gpio_led(const struct gpio_led *template,
int ret, state;
led_dat->cdev.default_trigger = template->default_trigger;
+ led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking;
+
led_dat->can_sleep = gpiod_cansleep(led_dat->gpiod);
if (!led_dat->can_sleep)
led_dat->cdev.brightness_set = gpio_led_set;
- else
- led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking;
+
led_dat->blinking = 0;
if (blink_set) {
led_dat->platform_gpio_blink_set = blink_set;
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: gpio: Always provide cdev->brightness_set_blocking()
2021-09-22 17:21 [PATCH] leds: gpio: Always provide cdev->brightness_set_blocking() Harald Seiler
@ 2021-11-04 13:09 ` Harald Seiler
0 siblings, 0 replies; 2+ messages in thread
From: Harald Seiler @ 2021-11-04 13:09 UTC (permalink / raw)
To: Pavel Machek; +Cc: linux-leds, linux-kernel, Jacek Anaszewski
Hi Pavel,
On Wed, 2021-09-22 at 19:21 +0200, Harald Seiler wrote:
> Even if the GPIO driver will never sleep, setting
> cdev->brightness_set_blocking() makes sense so
> led_set_brightness_sync() can be used with such LEDs.
>
> Internally, both gpio_led_set_blocking() and gpio_led_set() call
> the same implementation anyway.
>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Signed-off-by: Harald Seiler <hws@denx.de>
> ---
Any chance you can pick this up? This fix is needed to use gpio leds
with, for example, the tty trigger.
--
Harald
> drivers/leds/leds-gpio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index b5d5e22d2d1e..bbe582e47607 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -79,11 +79,12 @@ static int create_gpio_led(const struct gpio_led *template,
> int ret, state;
>
> led_dat->cdev.default_trigger = template->default_trigger;
> + led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking;
> +
> led_dat->can_sleep = gpiod_cansleep(led_dat->gpiod);
> if (!led_dat->can_sleep)
> led_dat->cdev.brightness_set = gpio_led_set;
> - else
> - led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking;
> +
> led_dat->blinking = 0;
> if (blink_set) {
> led_dat->platform_gpio_blink_set = blink_set;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-04 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22 17:21 [PATCH] leds: gpio: Always provide cdev->brightness_set_blocking() Harald Seiler
2021-11-04 13:09 ` Harald Seiler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.