* [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts @ 2021-09-22 19:43 ` Matthew Brost 0 siblings, 0 replies; 9+ messages in thread From: Matthew Brost @ 2021-09-22 19:43 UTC (permalink / raw) To: dri-devel, intel-gfx; +Cc: jason Set number of engines before attempting to create contexts so the function free_engines can clean up properly. Also check return of alloc_engines for NULL. v2: (Tvrtko) - Send as stand alone patch (John Harrison) - Check for alloc_engines returning NULL Cc: Jason Ekstrand <jason@jlekstrand.net> Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Signed-off-by: Matthew Brost <matthew.brost@intel.com> Cc: <stable@vger.kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index c2ab0e22db0a..9627c7aac6a3 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -898,6 +898,11 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, unsigned int n; e = alloc_engines(num_engines); + if (!e) { + return ERR_PTR(-ENOMEM); + } + e->num_engines = num_engines; + for (n = 0; n < num_engines; n++) { struct intel_context *ce; int ret; @@ -931,7 +936,6 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, goto free_engines; } } - e->num_engines = num_engines; return e; -- 2.32.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts @ 2021-09-22 19:43 ` Matthew Brost 0 siblings, 0 replies; 9+ messages in thread From: Matthew Brost @ 2021-09-22 19:43 UTC (permalink / raw) To: dri-devel, intel-gfx; +Cc: jason Set number of engines before attempting to create contexts so the function free_engines can clean up properly. Also check return of alloc_engines for NULL. v2: (Tvrtko) - Send as stand alone patch (John Harrison) - Check for alloc_engines returning NULL Cc: Jason Ekstrand <jason@jlekstrand.net> Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Signed-off-by: Matthew Brost <matthew.brost@intel.com> Cc: <stable@vger.kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index c2ab0e22db0a..9627c7aac6a3 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -898,6 +898,11 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, unsigned int n; e = alloc_engines(num_engines); + if (!e) { + return ERR_PTR(-ENOMEM); + } + e->num_engines = num_engines; + for (n = 0; n < num_engines; n++) { struct intel_context *ce; int ret; @@ -931,7 +936,6 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, goto free_engines; } } - e->num_engines = num_engines; return e; -- 2.32.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix bug in user proto-context creation that leaked contexts 2021-09-22 19:43 ` Matthew Brost (?) @ 2021-09-22 21:21 ` Patchwork -1 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2021-09-22 21:21 UTC (permalink / raw) To: Matthew Brost; +Cc: intel-gfx == Series Details == Series: drm/i915: Fix bug in user proto-context creation that leaked contexts URL : https://patchwork.freedesktop.org/series/94962/ State : warning == Summary == $ dim checkpatch origin/drm-tip fa5831f0711b drm/i915: Fix bug in user proto-context creation that leaked contexts -:30: WARNING:BRACES: braces {} are not necessary for single statement blocks #30: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:901: + if (!e) { + return ERR_PTR(-ENOMEM); + } total: 0 errors, 1 warnings, 0 checks, 18 lines checked ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix bug in user proto-context creation that leaked contexts 2021-09-22 19:43 ` Matthew Brost (?) (?) @ 2021-09-22 21:53 ` Patchwork -1 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2021-09-22 21:53 UTC (permalink / raw) To: Matthew Brost; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 2955 bytes --] == Series Details == Series: drm/i915: Fix bug in user proto-context creation that leaked contexts URL : https://patchwork.freedesktop.org/series/94962/ State : success == Summary == CI Bug Log - changes from CI_DRM_10629 -> Patchwork_21135 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/index.html Known issues ------------ Here are the changes found in Patchwork_21135 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s0: - fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html * igt@i915_selftest@live@gt_timelines: - fi-rkl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#4034]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-rkl-guc/igt@i915_selftest@live@gt_timelines.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/fi-rkl-guc/igt@i915_selftest@live@gt_timelines.html * igt@runner@aborted: - fi-rkl-guc: NOTRUN -> [FAIL][5] ([i915#3928]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/fi-rkl-guc/igt@runner@aborted.html #### Possible fixes #### * igt@i915_selftest@live@gt_heartbeat: - fi-kbl-r: [DMESG-FAIL][6] ([i915#2291] / [i915#541]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-kbl-r/igt@i915_selftest@live@gt_heartbeat.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/fi-kbl-r/igt@i915_selftest@live@gt_heartbeat.html [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928 [i915#4034]: https://gitlab.freedesktop.org/drm/intel/issues/4034 [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541 Participating hosts (42 -> 34) ------------------------------ Missing (8): fi-kbl-soraka fi-ilk-m540 bat-dg1-6 bat-dg1-5 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus bat-jsl-1 Build changes ------------- * Linux: CI_DRM_10629 -> Patchwork_21135 CI-20190529: 20190529 CI_DRM_10629: ce6974ec90355ddef78e6bc2221cb2296e5ba349 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6214: 13550e92c6c7bd825abb6c9b087d12a524b4674c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_21135: fa5831f0711b5ca53a2f4ee399726ac19da12204 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == fa5831f0711b drm/i915: Fix bug in user proto-context creation that leaked contexts == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/index.html [-- Attachment #2: Type: text/html, Size: 3637 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix bug in user proto-context creation that leaked contexts 2021-09-22 19:43 ` Matthew Brost ` (2 preceding siblings ...) (?) @ 2021-09-23 0:42 ` Patchwork -1 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2021-09-23 0:42 UTC (permalink / raw) To: Matthew Brost; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30292 bytes --] == Series Details == Series: drm/i915: Fix bug in user proto-context creation that leaked contexts URL : https://patchwork.freedesktop.org/series/94962/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10629_full -> Patchwork_21135_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_21135_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_21135_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_21135_full: ### IGT changes ### #### Possible regressions #### * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-skl: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html Known issues ------------ Here are the changes found in Patchwork_21135_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@engines-cleanup: - shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-snb5/igt@gem_ctx_persistence@engines-cleanup.html * igt@gem_eio@unwedge-stress: - shard-snb: NOTRUN -> [FAIL][4] ([i915#3354]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-snb7/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none@vecs0: - shard-kbl: NOTRUN -> [FAIL][5] ([i915#2842]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html - shard-apl: [PASS][6] -> [FAIL][7] ([i915#2842] / [i915#3468]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-apl2/igt@gem_exec_fair@basic-none@vecs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842]) +2 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-tglb2/igt@gem_exec_fair@basic-pace@bcs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-glk3/igt@gem_exec_fair@basic-throttle@rcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html - shard-iclb: [PASS][12] -> [FAIL][13] ([i915#2849]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271]) +213 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-snb2/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][15] ([i915#2658]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl7/igt@gem_pread@exhaustion.html * igt@gem_userptr_blits@coherency-unsync: - shard-tglb: NOTRUN -> [SKIP][16] ([i915#3297]) +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@gem_userptr_blits@coherency-unsync.html * igt@gem_userptr_blits@dmabuf-sync: - shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3323]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl7/igt@gem_userptr_blits@dmabuf-sync.html - shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3323]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl8/igt@gem_userptr_blits@dmabuf-sync.html * igt@gen9_exec_parse@allowed-all: - shard-tglb: NOTRUN -> [SKIP][19] ([i915#2856]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@gen9_exec_parse@allowed-all.html * igt@gen9_exec_parse@secure-batches: - shard-iclb: NOTRUN -> [SKIP][20] ([i915#2856]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb3/igt@gen9_exec_parse@secure-batches.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: - shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#1937]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-tglb: NOTRUN -> [WARN][22] ([i915#2681]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rpm@modeset-non-lpsp: - shard-tglb: NOTRUN -> [SKIP][23] ([fdo#111644] / [i915#1397] / [i915#2411]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@i915_pm_rpm@modeset-non-lpsp.html * igt@i915_pm_sseu@full-enable: - shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109288]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb5/igt@i915_pm_sseu@full-enable.html * igt@kms_atomic_transition@plane-all-modeset-transition-fencing: - shard-tglb: NOTRUN -> [SKIP][25] ([i915#1769]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html * igt@kms_big_fb@linear-32bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][26] ([fdo#111614]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb3/igt@kms_big_fb@linear-32bpp-rotate-270.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3777]) +3 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-skl: NOTRUN -> [FAIL][28] ([i915#3722]) +1 similar issue [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180: - shard-tglb: NOTRUN -> [SKIP][29] ([fdo#111615]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3777]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_joiner@2x-modeset: - shard-tglb: NOTRUN -> [SKIP][31] ([i915#2705]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb3/igt@kms_big_joiner@2x-modeset.html * igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886]) +4 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886]) +10 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl8/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][34] ([i915#3689] / [i915#3886]) +1 similar issue [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886]) +4 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl7/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][36] ([i915#3689]) +8 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html * igt@kms_color@pipe-a-ctm-0-75: - shard-skl: [PASS][37] -> [DMESG-WARN][38] ([i915#1982]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl8/igt@kms_color@pipe-a-ctm-0-75.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_color@pipe-d-ctm-max: - shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271]) +75 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_color@pipe-d-ctm-max.html * igt@kms_color_chamelium@pipe-a-ctm-0-25: - shard-snb: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +10 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-snb2/igt@kms_color_chamelium@pipe-a-ctm-0-25.html * igt@kms_color_chamelium@pipe-c-ctm-limited-range: - shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +10 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl1/igt@kms_color_chamelium@pipe-c-ctm-limited-range.html * igt@kms_color_chamelium@pipe-c-ctm-max: - shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +22 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl8/igt@kms_color_chamelium@pipe-c-ctm-max.html * igt@kms_color_chamelium@pipe-c-ctm-negative: - shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +8 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_color_chamelium@pipe-c-ctm-negative.html * igt@kms_color_chamelium@pipe-d-ctm-red-to-blue: - shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109284] / [fdo#111827]) +6 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html * igt@kms_content_protection@atomic-dpms: - shard-apl: NOTRUN -> [TIMEOUT][45] ([i915#1319]) +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl8/igt@kms_content_protection@atomic-dpms.html * igt@kms_content_protection@dp-mst-type-0: - shard-tglb: NOTRUN -> [SKIP][46] ([i915#3116]) +1 similar issue [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@kms_content_protection@dp-mst-type-0.html * igt@kms_content_protection@legacy: - shard-kbl: NOTRUN -> [TIMEOUT][47] ([i915#1319]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl1/igt@kms_content_protection@legacy.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-apl: [PASS][48] -> [DMESG-WARN][49] ([i915#180]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-b-cursor-max-size-offscreen: - shard-tglb: NOTRUN -> [SKIP][50] ([i915#3359]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-max-size-offscreen.html * igt@kms_cursor_crc@pipe-d-cursor-512x170-random: - shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109279] / [i915#3359]) +2 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_cursor_crc@pipe-d-cursor-512x170-random.html * igt@kms_flip@flip-vs-suspend@a-edp1: - shard-tglb: [PASS][52] -> [INCOMPLETE][53] ([i915#4173] / [i915#456]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-tglb1/igt@kms_flip@flip-vs-suspend@a-edp1.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb7/igt@kms_flip@flip-vs-suspend@a-edp1.html * igt@kms_flip@plain-flip-fb-recreate@b-edp1: - shard-skl: NOTRUN -> [FAIL][54] ([i915#2122]) +1 similar issue [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-blt: - shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111825]) +14 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu: - shard-kbl: NOTRUN -> [SKIP][56] ([fdo#109271]) +84 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#533]) +4 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl8/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence: - shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#533]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl9/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [PASS][59] -> [DMESG-WARN][60] ([i915#180]) +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][61] ([fdo#108145] / [i915#265]) +3 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: NOTRUN -> [FAIL][62] ([fdo#108145] / [i915#265]) +2 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: - shard-kbl: NOTRUN -> [FAIL][63] ([fdo#108145] / [i915#265]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html * igt@kms_plane_lowres@pipe-d-tiling-yf: - shard-tglb: NOTRUN -> [SKIP][64] ([fdo#112054]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb5/igt@kms_plane_lowres@pipe-d-tiling-yf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658]) +4 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#658]) +2 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-tglb: NOTRUN -> [SKIP][67] ([i915#2920]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#658]) +2 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-tglb: NOTRUN -> [FAIL][69] ([i915#132] / [i915#3467]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_psr@psr2_cursor_plane_onoff: - shard-iclb: [PASS][70] -> [SKIP][71] ([fdo#109441]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html * igt@kms_psr@psr2_primary_render: - shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109441]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb3/igt@kms_psr@psr2_primary_render.html * igt@kms_vblank@pipe-d-ts-continuation-idle: - shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271]) +251 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl6/igt@kms_vblank@pipe-d-ts-continuation-idle.html * igt@kms_vblank@pipe-d-wait-busy: - shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109278]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb3/igt@kms_vblank@pipe-d-wait-busy.html * igt@kms_vrr@flip-dpms: - shard-tglb: NOTRUN -> [SKIP][75] ([fdo#109502]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@kms_vrr@flip-dpms.html * igt@nouveau_crc@pipe-a-source-rg: - shard-tglb: NOTRUN -> [SKIP][76] ([i915#2530]) +2 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@nouveau_crc@pipe-a-source-rg.html * igt@perf@mi-rpc: - shard-tglb: NOTRUN -> [SKIP][77] ([fdo#109289]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@perf@mi-rpc.html * igt@prime_nv_api@i915_nv_import_vs_close: - shard-tglb: NOTRUN -> [SKIP][78] ([fdo#109291]) +2 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@prime_nv_api@i915_nv_import_vs_close.html * igt@prime_vgem@fence-flip-hang: - shard-tglb: NOTRUN -> [SKIP][79] ([fdo#109295]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb3/igt@prime_vgem@fence-flip-hang.html * igt@sysfs_clients@fair-1: - shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2994]) +4 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl7/igt@sysfs_clients@fair-1.html * igt@sysfs_clients@sema-25: - shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#2994]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl1/igt@sysfs_clients@sema-25.html - shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2994]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl2/igt@sysfs_clients@sema-25.html #### Possible fixes #### * igt@gem_eio@unwedge-stress: - shard-tglb: [TIMEOUT][83] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-tglb2/igt@gem_eio@unwedge-stress.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb1/igt@gem_eio@unwedge-stress.html - shard-iclb: [TIMEOUT][85] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb5/igt@gem_eio@unwedge-stress.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb5/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][87] ([i915#2842]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@i915_module_load@reload-with-fault-injection: - shard-skl: [DMESG-WARN][89] ([i915#1982]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl9/igt@i915_module_load@reload-with-fault-injection.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl6/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_backlight@fade_with_suspend: - shard-skl: [INCOMPLETE][91] ([i915#198]) -> [PASS][92] +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl10/igt@i915_pm_backlight@fade_with_suspend.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl3/igt@i915_pm_backlight@fade_with_suspend.html * igt@i915_pm_rpm@system-suspend: - shard-tglb: [INCOMPLETE][93] ([i915#2411] / [i915#456]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-tglb7/igt@i915_pm_rpm@system-suspend.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb6/igt@i915_pm_rpm@system-suspend.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-tglb: [INCOMPLETE][95] ([i915#456] / [i915#750]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-tglb5/igt@i915_suspend@fence-restore-tiled2untiled.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [FAIL][97] ([i915#2346]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [FAIL][99] ([i915#2346] / [i915#533]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +7 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html - shard-apl: [DMESG-WARN][103] ([i915#180]) -> [PASS][104] +2 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: - shard-tglb: [INCOMPLETE][105] ([i915#2411] / [i915#4173] / [i915#456]) -> [PASS][106] [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile: - shard-iclb: [SKIP][107] ([i915#3701]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: - shard-tglb: [INCOMPLETE][109] ([i915#2828] / [i915#456]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-tglb2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][111] ([fdo#108145] / [i915#265]) -> [PASS][112] +1 similar issue [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][113] ([fdo#109441]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb8/igt@kms_psr@psr2_cursor_render.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-skl: [INCOMPLETE][115] ([i915#198] / [i915#2828]) -> [PASS][116] [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl2/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl9/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@perf@polling-small-buf: - shard-skl: [FAIL][117] ([i915#1722]) -> [PASS][118] [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-skl2/igt@perf@polling-small-buf.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-skl10/igt@perf@polling-small-buf.html #### Warnings #### * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [FAIL][119] ([i915#2842]) -> [SKIP][120] ([fdo#109271]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [SKIP][121] ([fdo#109271]) -> [FAIL][122] ([i915#2842]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][123] ([i915#1804] / [i915#2684]) -> [WARN][124] ([i915#2684]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][125] ([i915#2684]) -> [WARN][126] ([i915#1804] / [i915#2684]) [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-iclb: [SKIP][127] ([i915#658]) -> [SKIP][128] ([i915#2920]) [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-iclb: [SKIP][129] ([i915#2920]) -> [SKIP][130] ([i915#658]) +1 similar issue [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@runner@aborted: - shard-kbl: ([FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#92]) -> ([FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl1/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl4/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl1/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl6/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl1/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl1/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/shard-kbl3/igt@runner@abor == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21135/index.html [-- Attachment #2: Type: text/html, Size: 33533 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts 2021-09-22 19:43 ` Matthew Brost ` (3 preceding siblings ...) (?) @ 2021-10-01 8:40 ` Tvrtko Ursulin 2021-10-01 15:48 ` Matthew Brost -1 siblings, 1 reply; 9+ messages in thread From: Tvrtko Ursulin @ 2021-10-01 8:40 UTC (permalink / raw) To: Matthew Brost, dri-devel, intel-gfx; +Cc: jason, Daniel Vetter + Daniel as reviewer and maybe merge, avoid falling through cracks at least. On 22/09/2021 20:43, Matthew Brost wrote: > Set number of engines before attempting to create contexts so the > function free_engines can clean up properly. Also check return of > alloc_engines for NULL. > > v2: > (Tvrtko) > - Send as stand alone patch > (John Harrison) > - Check for alloc_engines returning NULL > > Cc: Jason Ekstrand <jason@jlekstrand.net> > Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") > Signed-off-by: Matthew Brost <matthew.brost@intel.com> > Cc: <stable@vger.kernel.org> > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > index c2ab0e22db0a..9627c7aac6a3 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > @@ -898,6 +898,11 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, > unsigned int n; > > e = alloc_engines(num_engines); > + if (!e) { > + return ERR_PTR(-ENOMEM); > + } Ideally remove the braces and respin. > + e->num_engines = num_engines; Theoretically you could have put it next to "e->engines[n] = ce" assignment so the pattern is the same as in default_engines(). Kind of makes more sense that the number is not set before anything is created, but as it doesn't really matter since free_engines handles sparse arrays so there is argument to have a simpler single assignment as well. > + > for (n = 0; n < num_engines; n++) { > struct intel_context *ce; > int ret; > @@ -931,7 +936,6 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, > goto free_engines; > } > } > - e->num_engines = num_engines; > > return e; > > Fix looks good to me. I did not want to butt in but since more than a week has passed without it getting noticed: Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts 2021-10-01 8:40 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin @ 2021-10-01 15:48 ` Matthew Brost 2021-10-05 9:25 ` Tvrtko Ursulin 0 siblings, 1 reply; 9+ messages in thread From: Matthew Brost @ 2021-10-01 15:48 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: dri-devel, intel-gfx, jason, Daniel Vetter On Fri, Oct 01, 2021 at 09:40:19AM +0100, Tvrtko Ursulin wrote: > > + Daniel as reviewer and maybe merge, avoid falling through cracks at least. > Ty, working on push rights myself. > On 22/09/2021 20:43, Matthew Brost wrote: > > Set number of engines before attempting to create contexts so the > > function free_engines can clean up properly. Also check return of > > alloc_engines for NULL. > > > > v2: > > (Tvrtko) > > - Send as stand alone patch > > (John Harrison) > > - Check for alloc_engines returning NULL > > > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") > > Signed-off-by: Matthew Brost <matthew.brost@intel.com> > > Cc: <stable@vger.kernel.org> > > --- > > drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > > index c2ab0e22db0a..9627c7aac6a3 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > > @@ -898,6 +898,11 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, > > unsigned int n; > > e = alloc_engines(num_engines); > > + if (!e) { > > + return ERR_PTR(-ENOMEM); > > + } > > Ideally remove the braces and respin. > Yep, checkpatch didn't like this. Will respin. > > + e->num_engines = num_engines; > > Theoretically you could have put it next to "e->engines[n] = ce" assignment > so the pattern is the same as in default_engines(). Kind of makes more sense > that the number is not set before anything is created, but as it doesn't > really matter since free_engines handles sparse arrays so there is argument > to have a simpler single assignment as well. > I like a single assignment, let's not overthink this. > > + > > for (n = 0; n < num_engines; n++) { > > struct intel_context *ce; > > int ret; > > @@ -931,7 +936,6 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, > > goto free_engines; > > } > > } > > - e->num_engines = num_engines; > > return e; > > > > Fix looks good to me. I did not want to butt in but since more than a week > has passed without it getting noticed: > Again, ty. Matt > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Regards, > > Tvrtko ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts 2021-10-01 15:48 ` Matthew Brost @ 2021-10-05 9:25 ` Tvrtko Ursulin 0 siblings, 0 replies; 9+ messages in thread From: Tvrtko Ursulin @ 2021-10-05 9:25 UTC (permalink / raw) To: Matthew Brost; +Cc: dri-devel, intel-gfx, jason, Daniel Vetter On 01/10/2021 16:48, Matthew Brost wrote: > On Fri, Oct 01, 2021 at 09:40:19AM +0100, Tvrtko Ursulin wrote: >> >> + Daniel as reviewer and maybe merge, avoid falling through cracks at least. >> > > Ty, working on push rights myself. I ended up pushing it myself to avoid having a potential crash in the driver for too long. Hope people will not mind. Regards, Tvrtko >> On 22/09/2021 20:43, Matthew Brost wrote: >>> Set number of engines before attempting to create contexts so the >>> function free_engines can clean up properly. Also check return of >>> alloc_engines for NULL. >>> >>> v2: >>> (Tvrtko) >>> - Send as stand alone patch >>> (John Harrison) >>> - Check for alloc_engines returning NULL >>> >>> Cc: Jason Ekstrand <jason@jlekstrand.net> >>> Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") >>> Signed-off-by: Matthew Brost <matthew.brost@intel.com> >>> Cc: <stable@vger.kernel.org> >>> --- >>> drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c >>> index c2ab0e22db0a..9627c7aac6a3 100644 >>> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c >>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c >>> @@ -898,6 +898,11 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, >>> unsigned int n; >>> e = alloc_engines(num_engines); >>> + if (!e) { >>> + return ERR_PTR(-ENOMEM); >>> + } >> >> Ideally remove the braces and respin. >> > > Yep, checkpatch didn't like this. Will respin. > >>> + e->num_engines = num_engines; >> >> Theoretically you could have put it next to "e->engines[n] = ce" assignment >> so the pattern is the same as in default_engines(). Kind of makes more sense >> that the number is not set before anything is created, but as it doesn't >> really matter since free_engines handles sparse arrays so there is argument >> to have a simpler single assignment as well. >> > > I like a single assignment, let's not overthink this. > >>> + >>> for (n = 0; n < num_engines; n++) { >>> struct intel_context *ce; >>> int ret; >>> @@ -931,7 +936,6 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, >>> goto free_engines; >>> } >>> } >>> - e->num_engines = num_engines; >>> return e; >>> >> >> Fix looks good to me. I did not want to butt in but since more than a week >> has passed without it getting noticed: >> > > Again, ty. > > Matt > >> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> >> Regards, >> >> Tvrtko ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts @ 2021-10-01 15:58 Matthew Brost 0 siblings, 0 replies; 9+ messages in thread From: Matthew Brost @ 2021-10-01 15:58 UTC (permalink / raw) To: intel-gfx, dri-devel Set number of engines before attempting to create contexts so the function free_engines can clean up properly. Also check return of alloc_engines for NULL. v2: (Tvrtko) - Send as stand alone patch (John Harrison) - Check for alloc_engines returning NULL v3: (Checkpatch / Tvrtko) - Remove braces around single line if statement Cc: Jason Ekstrand <jason@jlekstrand.net> Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Signed-off-by: Matthew Brost <matthew.brost@intel.com> Cc: <stable@vger.kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 8208fd5b72c3..8c7ea6e56262 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -898,6 +898,10 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, unsigned int n; e = alloc_engines(num_engines); + if (!e) + return ERR_PTR(-ENOMEM); + e->num_engines = num_engines; + for (n = 0; n < num_engines; n++) { struct intel_context *ce; int ret; @@ -931,7 +935,6 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx, goto free_engines; } } - e->num_engines = num_engines; return e; -- 2.32.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-10-05 9:26 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-09-22 19:43 [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts Matthew Brost 2021-09-22 19:43 ` Matthew Brost 2021-09-22 21:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-09-22 21:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-09-23 0:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-01 8:40 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2021-10-01 15:48 ` Matthew Brost 2021-10-05 9:25 ` Tvrtko Ursulin 2021-10-01 15:58 Matthew Brost
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.