All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] m68k: Add missing ENTRY entry in linker script
@ 2021-09-17 16:10 Tom Rini
  2021-09-23  2:09 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Rini @ 2021-09-17 16:10 UTC (permalink / raw)
  To: u-boot; +Cc: Huan Wang, Angelo Dureghello

Currently, there is no ENTRY() entry in the m68k linker script.
However, since they currently contain a version_string symbol, which
then overrides the default weak version_string symbol, the linker
decides we must keep start.o in the resulting link.  Add an ENTRY() line
so that the linker will know to keep this, even when version_string is
no longer provided in start.S

Cc: Huan Wang <alison.wang@nxp.com>
Cc: Angelo Dureghello <angelo@sysam.it>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 arch/m68k/cpu/u-boot.lds | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/m68k/cpu/u-boot.lds b/arch/m68k/cpu/u-boot.lds
index 64cf2ff5ef97..affb2d937464 100644
--- a/arch/m68k/cpu/u-boot.lds
+++ b/arch/m68k/cpu/u-boot.lds
@@ -9,6 +9,7 @@
 #include <config.h>
 
 OUTPUT_ARCH(m68k)
+ENTRY(_start)
 
 #ifndef LDS_BOARD_TEXT
 #define LDS_BOARD_TEXT
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] m68k: Add missing ENTRY entry in linker script
  2021-09-17 16:10 [PATCH] m68k: Add missing ENTRY entry in linker script Tom Rini
@ 2021-09-23  2:09 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2021-09-23  2:09 UTC (permalink / raw)
  To: u-boot; +Cc: Huan Wang, Angelo Dureghello

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On Fri, Sep 17, 2021 at 12:10:19PM -0400, Tom Rini wrote:

> Currently, there is no ENTRY() entry in the m68k linker script.
> However, since they currently contain a version_string symbol, which
> then overrides the default weak version_string symbol, the linker
> decides we must keep start.o in the resulting link.  Add an ENTRY() line
> so that the linker will know to keep this, even when version_string is
> no longer provided in start.S
> 
> Cc: Huan Wang <alison.wang@nxp.com>
> Cc: Angelo Dureghello <angelo@sysam.it>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-23  2:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 16:10 [PATCH] m68k: Add missing ENTRY entry in linker script Tom Rini
2021-09-23  2:09 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.