* [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT
@ 2021-09-13 6:19 Jackie Liu
2021-09-22 2:29 ` Jackie Liu
2021-09-23 9:35 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Jackie Liu @ 2021-09-13 6:19 UTC (permalink / raw)
To: tsbogend; +Cc: chenhuacai, linux-mips, liu.yun
From: Jackie Liu <liuyun01@kylinos.cn>
mach/loongson64 fails to build when the FPU support is disabled:
arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration]
arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’
Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
Suggested-by: Huacai Chen <chenhuacai@kernel.org>
Reviewed-by: Huacai Chen <chenhuacai@kernel.org>
Reported-by: k2ci robot <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
v1->v2:
move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64
v2->v3:
add Huacai Chen <chenhc@lemote.com>'s suggest label.
v3->v4:
update Huacai Chen's email address.
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 24e374266fdc..aea3aa16a38e 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1408,6 +1408,7 @@ config CPU_LOONGSON64
select MIPS_ASID_BITS_VARIABLE
select MIPS_PGD_C0_CONTEXT
select MIPS_L1_CACHE_SHIFT_6
+ select MIPS_FP_SUPPORT
select GPIOLIB
select SWIOTLB
select HAVE_KVM
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT
2021-09-13 6:19 [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT Jackie Liu
@ 2021-09-22 2:29 ` Jackie Liu
2021-09-23 9:35 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Jackie Liu @ 2021-09-22 2:29 UTC (permalink / raw)
To: tsbogend; +Cc: chenhuacai, linux-mips
ping, would anyone take this patch?
在 2021/9/13 下午2:19, Jackie Liu 写道:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> mach/loongson64 fails to build when the FPU support is disabled:
>
> arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration]
> arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’
>
> Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
> Suggested-by: Huacai Chen <chenhuacai@kernel.org>
> Reviewed-by: Huacai Chen <chenhuacai@kernel.org>
> Reported-by: k2ci robot <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> v1->v2:
> move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64
>
> v2->v3:
> add Huacai Chen <chenhc@lemote.com>'s suggest label.
>
> v3->v4:
> update Huacai Chen's email address.
>
> arch/mips/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 24e374266fdc..aea3aa16a38e 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1408,6 +1408,7 @@ config CPU_LOONGSON64
> select MIPS_ASID_BITS_VARIABLE
> select MIPS_PGD_C0_CONTEXT
> select MIPS_L1_CACHE_SHIFT_6
> + select MIPS_FP_SUPPORT
> select GPIOLIB
> select SWIOTLB
> select HAVE_KVM
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT
2021-09-13 6:19 [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT Jackie Liu
2021-09-22 2:29 ` Jackie Liu
@ 2021-09-23 9:35 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2021-09-23 9:35 UTC (permalink / raw)
To: Jackie Liu; +Cc: chenhuacai, linux-mips
On Mon, Sep 13, 2021 at 02:19:08PM +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> mach/loongson64 fails to build when the FPU support is disabled:
>
> arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration]
> arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’
>
> Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
> Suggested-by: Huacai Chen <chenhuacai@kernel.org>
> Reviewed-by: Huacai Chen <chenhuacai@kernel.org>
> Reported-by: k2ci robot <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> v1->v2:
> move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64
>
> v2->v3:
> add Huacai Chen <chenhc@lemote.com>'s suggest label.
>
> v3->v4:
> update Huacai Chen's email address.
>
> arch/mips/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-23 9:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 6:19 [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT Jackie Liu
2021-09-22 2:29 ` Jackie Liu
2021-09-23 9:35 ` Thomas Bogendoerfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.