* [PATCH net 1/1] atlantic: Fix issue in the pm resume flow.
@ 2021-09-23 10:16 Sudarsana Reddy Kalluru
2021-09-23 12:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Sudarsana Reddy Kalluru @ 2021-09-23 10:16 UTC (permalink / raw)
To: davem; +Cc: netdev, irusskikh
After fixing hibernation resume flow, another usecase was found which
should be explicitly handled - resume when device is in "down" state.
Invoke aq_nic_init jointly with aq_nic_start only if ndev was already
up during suspend/hibernate. We still need to perform nic_deinit() if
caller requests for it, to handle the freeze/resume scenarios.
Fixes: 57f780f1c433 ("atlantic: Fix driver resume flow.")
Signed-off-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
index dee9ff74d6d6..d4b1976ee69b 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -413,13 +413,13 @@ static int atl_resume_common(struct device *dev, bool deep)
if (deep) {
/* Reinitialize Nic/Vecs objects */
aq_nic_deinit(nic, !nic->aq_hw->aq_nic_cfg->wol);
+ }
+ if (netif_running(nic->ndev)) {
ret = aq_nic_init(nic);
if (ret)
goto err_exit;
- }
- if (netif_running(nic->ndev)) {
ret = aq_nic_start(nic);
if (ret)
goto err_exit;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net 1/1] atlantic: Fix issue in the pm resume flow.
2021-09-23 10:16 [PATCH net 1/1] atlantic: Fix issue in the pm resume flow Sudarsana Reddy Kalluru
@ 2021-09-23 12:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-23 12:30 UTC (permalink / raw)
To: Sudarsana Reddy Kalluru; +Cc: davem, netdev, irusskikh
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 23 Sep 2021 03:16:05 -0700 you wrote:
> After fixing hibernation resume flow, another usecase was found which
> should be explicitly handled - resume when device is in "down" state.
> Invoke aq_nic_init jointly with aq_nic_start only if ndev was already
> up during suspend/hibernate. We still need to perform nic_deinit() if
> caller requests for it, to handle the freeze/resume scenarios.
>
> Fixes: 57f780f1c433 ("atlantic: Fix driver resume flow.")
> Signed-off-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
>
> [...]
Here is the summary with links:
- [net,1/1] atlantic: Fix issue in the pm resume flow.
https://git.kernel.org/netdev/net/c/4d88c339c423
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-23 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 10:16 [PATCH net 1/1] atlantic: Fix issue in the pm resume flow Sudarsana Reddy Kalluru
2021-09-23 12:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.