agetty.8.adoc: Replace /usr/lib with a variable?

agetty.8.adoc: Replace /usr/lib with a variable?

[Mario Blättermann]

Hello,

in agetty.8.adoc the file path /usr/lib/ is hardcoded. At least the
Mageia distribution (possibly others, too) uses /usr/lib64 for the
x86_64 version instead. Would it be better to use {libdir} and let
replace it on demand by a ./configure option? As far as I can
evaluate, this should work with an option in Makefile.am:

AM_CPPFLAGS = \
...
        -D_PATH_LIBDIR=\"${libdir}\"

Similarly, we could think about to replace all file paths in man pages
which are configurable during the installation.

Best Regards,
Mario

Re: agetty.8.adoc: Replace /usr/lib with a variable?

[Karel Zak]

On Tue, Sep 21, 2021 at 09:17:48PM +0200, Mario Blättermann wrote:
> in agetty.8.adoc the file path /usr/lib/ is hardcoded. At least the
> Mageia distribution (possibly others, too) uses /usr/lib64 for the
> x86_64 version instead. Would it be better to use {libdir} and let
> replace it on demand by a ./configure option? As far as I can
> evaluate, this should work with an option in Makefile.am:
> 
> AM_CPPFLAGS = \
> ...
>         -D_PATH_LIBDIR=\"${libdir}\"
> 
> Similarly, we could think about to replace all file paths in man pages
> which are configurable during the installation.

Yes, use variables is perfect solution, go ahead and send patch ;-)

For now there is a problem that we distribute in tarball already
generated man pages (to avoid dependence on asciidoctor for some
use-cases). Maybe all we need is to add some sed(1) call to "if
HAVE_MANPAGES" section to modify these man pages. I'll try to improve
it. Anyway, for .adoc files is this irrelevant issue.

 Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com