[PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on Dell XPS 15

[PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on Dell XPS 15

[Vladimir Zapolskiy]

There is a Killer AX1650 2x2 Wi-Fi 6 and Bluetooth 5.1 wireless adapter
found on Dell XPS 15 (9510) laptop, its configuration was present on
Linux v5.7, however accidentally it has been removed from the list of
supported devices, let's add it back.

The problem is manifested on driver initialization:

  Intel(R) Wireless WiFi driver for Linux
  iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
  iwlwifi: No config found for PCI dev 43f0/1651, rev=0x354, rfid=0x10a100
  iwlwifi: probe of 0000:00:14.3 failed with error -22

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213939
Fixes: 3f910a25839b ("iwlwifi: pcie: convert all AX101 devices to the device tables")
Cc: Julien Wajsberg <felash@gmail.com>
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
Changes from v1 to v2:
* moved the added lines in a way to preserve a numerical order by devid.

 drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 61b2797a34a8..3744c5e76519 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -547,6 +547,8 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
 	IWL_DEV_INFO(0x43F0, 0x0074, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0x43F0, 0x0078, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0x43F0, 0x007C, iwl_ax201_cfg_qu_hr, NULL),
+	IWL_DEV_INFO(0x43F0, 0x1651, killer1650s_2ax_cfg_qu_b0_hr_b0, NULL),
+	IWL_DEV_INFO(0x43F0, 0x1652, killer1650i_2ax_cfg_qu_b0_hr_b0, NULL),
 	IWL_DEV_INFO(0x43F0, 0x2074, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0x43F0, 0x4070, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0xA0F0, 0x0070, iwl_ax201_cfg_qu_hr, NULL),
-- 
2.33.0

Re: [PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on Dell XPS 15

[Kalle Valo]

Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> writes:

> There is a Killer AX1650 2x2 Wi-Fi 6 and Bluetooth 5.1 wireless adapter
> found on Dell XPS 15 (9510) laptop, its configuration was present on
> Linux v5.7, however accidentally it has been removed from the list of
> supported devices, let's add it back.
>
> The problem is manifested on driver initialization:
>
>   Intel(R) Wireless WiFi driver for Linux
>   iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
>   iwlwifi: No config found for PCI dev 43f0/1651, rev=0x354, rfid=0x10a100
>   iwlwifi: probe of 0000:00:14.3 failed with error -22
>
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213939
> Fixes: 3f910a25839b ("iwlwifi: pcie: convert all AX101 devices to the device tables")
> Cc: Julien Wajsberg <felash@gmail.com>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

Luca, can I take this to wireless-drivers? Ack?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on Dell XPS 15

[Coelho, Luciano]

On Thu, 2021-09-23 at 17:38 +0300, Vladimir Zapolskiy wrote:
> There is a Killer AX1650 2x2 Wi-Fi 6 and Bluetooth 5.1 wireless adapter
> found on Dell XPS 15 (9510) laptop, its configuration was present on
> Linux v5.7, however accidentally it has been removed from the list of
> supported devices, let's add it back.
> 
> The problem is manifested on driver initialization:
> 
>   Intel(R) Wireless WiFi driver for Linux
>   iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
>   iwlwifi: No config found for PCI dev 43f0/1651, rev=0x354, rfid=0x10a100
>   iwlwifi: probe of 0000:00:14.3 failed with error -22
> 
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213939
> Fixes: 3f910a25839b ("iwlwifi: pcie: convert all AX101 devices to the device tables")
> Cc: Julien Wajsberg <felash@gmail.com>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> Changes from v1 to v2:
> * moved the added lines in a way to preserve a numerical order by devid.
> 
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> index 61b2797a34a8..3744c5e76519 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -547,6 +547,8 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
>  	IWL_DEV_INFO(0x43F0, 0x0074, iwl_ax201_cfg_qu_hr, NULL),
>  	IWL_DEV_INFO(0x43F0, 0x0078, iwl_ax201_cfg_qu_hr, NULL),
>  	IWL_DEV_INFO(0x43F0, 0x007C, iwl_ax201_cfg_qu_hr, NULL),
> +	IWL_DEV_INFO(0x43F0, 0x1651, killer1650s_2ax_cfg_qu_b0_hr_b0, NULL),

Instead of NULL at the end, please use iwl_ax201_killer_1650s_name.

> +	IWL_DEV_INFO(0x43F0, 0x1652, killer1650i_2ax_cfg_qu_b0_hr_b0, NULL),

...and iwl_ax201_killer_1650i_name here.


--
Cheers,
Luca.

Re: [PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on Dell XPS 15

[Coelho, Luciano]

On Fri, 2021-09-24 at 10:46 +0300, Kalle Valo wrote:
> Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> writes:
> 
> > There is a Killer AX1650 2x2 Wi-Fi 6 and Bluetooth 5.1 wireless adapter
> > found on Dell XPS 15 (9510) laptop, its configuration was present on
> > Linux v5.7, however accidentally it has been removed from the list of
> > supported devices, let's add it back.
> > 
> > The problem is manifested on driver initialization:
> > 
> >   Intel(R) Wireless WiFi driver for Linux
> >   iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> >   iwlwifi: No config found for PCI dev 43f0/1651, rev=0x354, rfid=0x10a100
> >   iwlwifi: probe of 0000:00:14.3 failed with error -22
> > 
> > Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213939
> > Fixes: 3f910a25839b ("iwlwifi: pcie: convert all AX101 devices to the device tables")
> > Cc: Julien Wajsberg <felash@gmail.com>
> > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> 
> Luca, can I take this to wireless-drivers? Ack?

I sent a small comment, let's wait for v2?

--
Cheers,
Luca.

Re: [PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on Dell XPS 15

[Coelho, Luciano]

On Fri, 2021-09-24 at 11:49 +0300, Luciano Coelho wrote:
> On Fri, 2021-09-24 at 10:46 +0300, Kalle Valo wrote:
> > Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> writes:
> > 
> > > There is a Killer AX1650 2x2 Wi-Fi 6 and Bluetooth 5.1 wireless adapter
> > > found on Dell XPS 15 (9510) laptop, its configuration was present on
> > > Linux v5.7, however accidentally it has been removed from the list of
> > > supported devices, let's add it back.
> > > 
> > > The problem is manifested on driver initialization:
> > > 
> > >   Intel(R) Wireless WiFi driver for Linux
> > >   iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> > >   iwlwifi: No config found for PCI dev 43f0/1651, rev=0x354, rfid=0x10a100
> > >   iwlwifi: probe of 0000:00:14.3 failed with error -22
> > > 
> > > Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213939
> > > Fixes: 3f910a25839b ("iwlwifi: pcie: convert all AX101 devices to the device tables")
> > > Cc: Julien Wajsberg <felash@gmail.com>
> > > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> > 
> > Luca, can I take this to wireless-drivers? Ack?
> 
> I sent a small comment, let's wait for v2?

I meant v3, obviously. :)

--
Luca.