All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: c630: Move panel to aux-bus
@ 2021-09-24  2:52 Bjorn Andersson
  2021-09-26  6:07 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2021-09-24  2:52 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Shawn Guo, Steev Klimaszewski
  Cc: linux-arm-msm, devicetree, linux-kernel

With the newly introduced aux-bus under the TI SN65DSI86 the panel
node should be described as a child instead of a standalone node, move
it there.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 27 +++++++++----------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index bd22352b6c7a..4818ca6d820d 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -56,20 +56,6 @@ mode {
 		};
 	};
 
-	panel {
-		compatible = "boe,nv133fhm-n61";
-		no-hpd;
-		backlight = <&backlight>;
-
-		ports {
-			port {
-				panel_in_edp: endpoint {
-					remote-endpoint = <&sn65dsi86_out>;
-				};
-			};
-		};
-	};
-
 	/* Reserved memory changes for IPA */
 	reserved-memory {
 		wlan_msa_mem: memory@8c400000 {
@@ -441,6 +427,19 @@ sn65dsi86_out: endpoint {
 				};
 			};
 		};
+
+		aux-bus {
+			panel: panel {
+				compatible = "boe,nv133fhm-n61";
+				backlight = <&backlight>;
+
+				port {
+					panel_in_edp: endpoint {
+						remote-endpoint = <&sn65dsi86_out>;
+					};
+				};
+			};
+		};
 	};
 };
 
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: c630: Move panel to aux-bus
  2021-09-24  2:52 [PATCH] arm64: dts: qcom: c630: Move panel to aux-bus Bjorn Andersson
@ 2021-09-26  6:07 ` Shawn Guo
  2021-09-28 15:35   ` Bjorn Andersson
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2021-09-26  6:07 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, Rob Herring, Steev Klimaszewski, linux-arm-msm,
	devicetree, linux-kernel

On Thu, Sep 23, 2021 at 09:52:55PM -0500, Bjorn Andersson wrote:
> With the newly introduced aux-bus under the TI SN65DSI86 the panel
> node should be described as a child instead of a standalone node, move
> it there.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 27 +++++++++----------
>  1 file changed, 13 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index bd22352b6c7a..4818ca6d820d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -56,20 +56,6 @@ mode {
>  		};
>  	};
>  
> -	panel {
> -		compatible = "boe,nv133fhm-n61";
> -		no-hpd;
> -		backlight = <&backlight>;

There is some prerequisite change for this patch?  I do not find this
backlight node on v5.15-rc, neither linux-next.

Shawn

> -
> -		ports {
> -			port {
> -				panel_in_edp: endpoint {
> -					remote-endpoint = <&sn65dsi86_out>;
> -				};
> -			};
> -		};
> -	};
> -
>  	/* Reserved memory changes for IPA */
>  	reserved-memory {
>  		wlan_msa_mem: memory@8c400000 {
> @@ -441,6 +427,19 @@ sn65dsi86_out: endpoint {
>  				};
>  			};
>  		};
> +
> +		aux-bus {
> +			panel: panel {
> +				compatible = "boe,nv133fhm-n61";
> +				backlight = <&backlight>;
> +
> +				port {
> +					panel_in_edp: endpoint {
> +						remote-endpoint = <&sn65dsi86_out>;
> +					};
> +				};
> +			};
> +		};
>  	};
>  };
>  
> -- 
> 2.32.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: c630: Move panel to aux-bus
  2021-09-26  6:07 ` Shawn Guo
@ 2021-09-28 15:35   ` Bjorn Andersson
  0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-09-28 15:35 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Andy Gross, Rob Herring, Steev Klimaszewski, linux-arm-msm,
	devicetree, linux-kernel

On Sun 26 Sep 01:07 CDT 2021, Shawn Guo wrote:

> On Thu, Sep 23, 2021 at 09:52:55PM -0500, Bjorn Andersson wrote:
> > With the newly introduced aux-bus under the TI SN65DSI86 the panel
> > node should be described as a child instead of a standalone node, move
> > it there.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 27 +++++++++----------
> >  1 file changed, 13 insertions(+), 14 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > index bd22352b6c7a..4818ca6d820d 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > @@ -56,20 +56,6 @@ mode {
> >  		};
> >  	};
> >  
> > -	panel {
> > -		compatible = "boe,nv133fhm-n61";
> > -		no-hpd;
> > -		backlight = <&backlight>;
> 
> There is some prerequisite change for this patch?  I do not find this
> backlight node on v5.15-rc, neither linux-next.
> 

Seems I had this and the backlight addition patch in the wrong order in
my local tree. Let's see if we can land the backlight support and then
I'll repost this.

Thanks,
Bjorn

> Shawn
> 
> > -
> > -		ports {
> > -			port {
> > -				panel_in_edp: endpoint {
> > -					remote-endpoint = <&sn65dsi86_out>;
> > -				};
> > -			};
> > -		};
> > -	};
> > -
> >  	/* Reserved memory changes for IPA */
> >  	reserved-memory {
> >  		wlan_msa_mem: memory@8c400000 {
> > @@ -441,6 +427,19 @@ sn65dsi86_out: endpoint {
> >  				};
> >  			};
> >  		};
> > +
> > +		aux-bus {
> > +			panel: panel {
> > +				compatible = "boe,nv133fhm-n61";
> > +				backlight = <&backlight>;
> > +
> > +				port {
> > +					panel_in_edp: endpoint {
> > +						remote-endpoint = <&sn65dsi86_out>;
> > +					};
> > +				};
> > +			};
> > +		};
> >  	};
> >  };
> >  
> > -- 
> > 2.32.0
> > 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-28 15:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24  2:52 [PATCH] arm64: dts: qcom: c630: Move panel to aux-bus Bjorn Andersson
2021-09-26  6:07 ` Shawn Guo
2021-09-28 15:35   ` Bjorn Andersson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.