[Buildroot] [PATCH] boot/syslinux: add missing python dependency

[Buildroot] [PATCH] boot/syslinux: add missing python dependency

[Romain Naour]

Syslinux use some python scripts during the build and they
are using python interpreter by default. It fail to build
when there is no python interpreter on the host.

[...]/syslinux-6.03/com32/cmenu/menugen.py
make[6]: python: No such file or directory

Since Syslinux 5.00, we can override the python interpreter
used during the build:

https://repo.or.cz/syslinux.git/commitdiff/4dec62ce9c2c0d170f21b3ae2d7c618eb7a30c05

Add the	missing	host-python3 dependency and override
it in SYSLINUX_BUILD_CMDS.

Fixes:
https://gitlab.com/kubu93/buildroot/-/jobs/1614446766

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 boot/syslinux/syslinux.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/boot/syslinux/syslinux.mk b/boot/syslinux/syslinux.mk
index 67bc69254e..77bacca9a3 100644
--- a/boot/syslinux/syslinux.mk
+++ b/boot/syslinux/syslinux.mk
@@ -14,7 +14,12 @@ SYSLINUX_LICENSE_FILES = COPYING
 SYSLINUX_INSTALL_IMAGES = YES
 
 # host-util-linux needed to provide libuuid when building host tools
-SYSLINUX_DEPENDENCIES = host-nasm host-upx util-linux host-util-linux
+SYSLINUX_DEPENDENCIES = \
+	host-nasm \
+	host-python3 \
+	host-upx \
+	host-util-linux \
+	util-linux \
 
 ifeq ($(BR2_TARGET_SYSLINUX_LEGACY_BIOS),y)
 SYSLINUX_TARGET += bios
@@ -59,6 +64,7 @@ define SYSLINUX_BUILD_CMDS
 		CC_FOR_BUILD="$(HOSTCC)" \
 		CFLAGS_FOR_BUILD="$(HOST_CFLAGS)" \
 		LDFLAGS_FOR_BUILD="$(HOST_LDFLAGS)" \
+		PYTHON=$(HOST_DIR)/bin/python3 \
 		$(SYSLINUX_EFI_ARGS) -C $(@D) $(SYSLINUX_TARGET)
 endef
 
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] boot/syslinux: add missing python dependency

[Yann E. MORIN]

Romain, All,

On 2021-09-23 23:28 +0200, Romain Naour spake thusly:
> Syslinux use some python scripts during the build and they
> are using python interpreter by default. It fail to build
> when there is no python interpreter on the host.
> 
> [...]/syslinux-6.03/com32/cmenu/menugen.py
> make[6]: python: No such file or directory
> 
> Since Syslinux 5.00, we can override the python interpreter
> used during the build:
> 
> https://repo.or.cz/syslinux.git/commitdiff/4dec62ce9c2c0d170f21b3ae2d7c618eb7a30c05
> 
> Add the	missing	host-python3 dependency and override
> it in SYSLINUX_BUILD_CMDS.
> 
> Fixes:
> https://gitlab.com/kubu93/buildroot/-/jobs/1614446766
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  boot/syslinux/syslinux.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/syslinux/syslinux.mk b/boot/syslinux/syslinux.mk
> index 67bc69254e..77bacca9a3 100644
> --- a/boot/syslinux/syslinux.mk
> +++ b/boot/syslinux/syslinux.mk
> @@ -14,7 +14,12 @@ SYSLINUX_LICENSE_FILES = COPYING
>  SYSLINUX_INSTALL_IMAGES = YES
>  
>  # host-util-linux needed to provide libuuid when building host tools
> -SYSLINUX_DEPENDENCIES = host-nasm host-upx util-linux host-util-linux
> +SYSLINUX_DEPENDENCIES = \
> +	host-nasm \
> +	host-python3 \
> +	host-upx \
> +	host-util-linux \
> +	util-linux \

    $ make check-package
    boot/syslinux/syslinux.mk:22: remove trailing backslash

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

>  ifeq ($(BR2_TARGET_SYSLINUX_LEGACY_BIOS),y)
>  SYSLINUX_TARGET += bios
> @@ -59,6 +64,7 @@ define SYSLINUX_BUILD_CMDS
>  		CC_FOR_BUILD="$(HOSTCC)" \
>  		CFLAGS_FOR_BUILD="$(HOST_CFLAGS)" \
>  		LDFLAGS_FOR_BUILD="$(HOST_LDFLAGS)" \
> +		PYTHON=$(HOST_DIR)/bin/python3 \
>  		$(SYSLINUX_EFI_ARGS) -C $(@D) $(SYSLINUX_TARGET)
>  endef
>  
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] boot/syslinux: add missing python dependency

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > Syslinux use some python scripts during the build and they
 > are using python interpreter by default. It fail to build
 > when there is no python interpreter on the host.

 > [...]/syslinux-6.03/com32/cmenu/menugen.py
 > make[6]: python: No such file or directory

 > Since Syslinux 5.00, we can override the python interpreter
 > used during the build:

 > https://repo.or.cz/syslinux.git/commitdiff/4dec62ce9c2c0d170f21b3ae2d7c618eb7a30c05

 > Add the	missing	host-python3 dependency and override
 > it in SYSLINUX_BUILD_CMDS.

 > Fixes:
 > https://gitlab.com/kubu93/buildroot/-/jobs/1614446766

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot