From: Tommaso Merciai <tomm.merciai@gmail.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: "Forest Bond" <forest@alittletooquiet.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Madhumitha Prabakaran" <madhumithabiw@gmail.com>,
"Yujia Qiao" <rapiz@foxmail.com>,
"Lucas Henneman" <lucas.henneman@linaro.org>,
"Marcos Antonio de Jesus Filho" <mdejesusfilho@gmail.com>,
"Edmundo Carmona Antoranz" <eantoranz@gmail.com>,
"Aldas Taraškevičius" <aldas60@gmail.com>,
"Deepak R Varma" <mh12gx2825@gmail.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6655: Replace camel case variable name
Date: Fri, 24 Sep 2021 23:12:17 +0200 [thread overview]
Message-ID: <20210924211217.GC10906@tom-desktop> (raw)
In-Reply-To: <4972337.8pBPQsAWaL@localhost.localdomain>
On Thu, Sep 23, 2021 at 09:54:12PM +0200, Fabio M. De Francesco wrote:
> On Thursday, September 23, 2021 12:07:49 AM CEST Tommaso Merciai wrote:
> > Work in progress: replace camel case variables
> >
> > PortOffset -> port_off_set
> >
> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> > ---
> > drivers/staging/vt6655/baseband.c | 6 +-
> > drivers/staging/vt6655/card.c | 88 ++++++++--------
> > drivers/staging/vt6655/channel.c | 10 +-
> > drivers/staging/vt6655/device.h | 2 +-
> > drivers/staging/vt6655/device_main.c | 144 +++++++++++++--------------
> > drivers/staging/vt6655/mac.c | 46 ++++-----
> > drivers/staging/vt6655/power.c | 24 ++---
> > drivers/staging/vt6655/rf.c | 12 +--
> > drivers/staging/vt6655/rxtx.c | 12 +--
> > 9 files changed, 172 insertions(+), 172 deletions(-)
>
> If you split "Offset" into "Off set", you convey the message that something
> is "Off the set". Probably that's not what you want to express.
>
> Regards,
>
> Fabio
Thanks, you're right. Resend V2.
Tommaso
>
>
next prev parent reply other threads:[~2021-09-24 21:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 22:07 [PATCH] Staging: vt6655: Replace camel case variable name Tommaso Merciai
2021-09-22 22:07 ` Tommaso Merciai
2021-09-23 19:54 ` Fabio M. De Francesco
2021-09-24 21:12 ` Tommaso Merciai [this message]
2021-09-22 22:13 [PATCH] staging: " Tommaso Merciai
2021-09-22 22:13 ` Tommaso Merciai
2021-09-22 22:29 Tommaso Merciai
2021-09-22 22:29 ` Tommaso Merciai
2021-09-22 22:35 Tommaso Merciai
2021-09-22 22:35 ` Tommaso Merciai
2021-09-22 22:51 Tommaso Merciai
2021-09-22 22:51 ` Tommaso Merciai
2021-09-22 23:12 ` Gustavo A. R. Silva
2021-09-24 21:09 ` Tommaso Merciai
2021-09-22 22:57 Tommaso Merciai
2021-09-22 22:57 ` Tommaso Merciai
2021-09-23 8:30 ` Dan Carpenter
2021-09-24 21:11 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924211217.GC10906@tom-desktop \
--to=tomm.merciai@gmail.com \
--cc=aldas60@gmail.com \
--cc=eantoranz@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.henneman@linaro.org \
--cc=madhumithabiw@gmail.com \
--cc=mdejesusfilho@gmail.com \
--cc=mh12gx2825@gmail.com \
--cc=rapiz@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.