From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: "Forest Bond" <forest@alittletooquiet.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Lucas Henneman" <lucas.henneman@linaro.org>,
"Madhumitha Prabakaran" <madhumithabiw@gmail.com>,
"Yujia Qiao" <rapiz@foxmail.com>,
"Marcos Antonio de Jesus Filho" <mdejesusfilho@gmail.com>,
"Edmundo Carmona Antoranz" <eantoranz@gmail.com>,
"Aldas Taraškevičius" <aldas60@gmail.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Deepak R Varma" <mh12gx2825@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Replace camel case variable name
Date: Wed, 22 Sep 2021 18:12:37 -0500 [thread overview]
Message-ID: <6695e45f-4530-ab39-923d-8347649762bb@embeddedor.com> (raw)
In-Reply-To: <20210922225138.668520-1-tomm.merciai@gmail.com>
On 9/22/21 17:51, Tommaso Merciai wrote:
> Work in progress: replace camel case variables
>
> PortOffset -> port_offset
>
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> ---
When someone gives you feedback and you have to respin your
patch, you should version the patches that you resend, and
mention what changed, here:
Changes in v2:
- Variable should be port_offset instead of port_off_set.
I encourage you to take a look at this:
https://kernelnewbies.org/Outreachyfirstpatch
It will be of great help if you are trying to land
your first patches. :)
--
Gustavo
next prev parent reply other threads:[~2021-09-22 23:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 22:51 [PATCH] staging: vt6655: Replace camel case variable name Tommaso Merciai
2021-09-22 22:51 ` Tommaso Merciai
2021-09-22 23:12 ` Gustavo A. R. Silva [this message]
2021-09-24 21:09 ` Tommaso Merciai
-- strict thread matches above, loose matches on Subject: below --
2021-09-22 22:57 Tommaso Merciai
2021-09-22 22:57 ` Tommaso Merciai
2021-09-23 8:30 ` Dan Carpenter
2021-09-24 21:11 ` Tommaso Merciai
2021-09-22 22:35 Tommaso Merciai
2021-09-22 22:35 ` Tommaso Merciai
2021-09-22 22:29 Tommaso Merciai
2021-09-22 22:29 ` Tommaso Merciai
2021-09-22 22:13 Tommaso Merciai
2021-09-22 22:13 ` Tommaso Merciai
2021-09-22 22:07 [PATCH] Staging: " Tommaso Merciai
2021-09-22 22:07 ` Tommaso Merciai
2021-09-23 19:54 ` Fabio M. De Francesco
2021-09-24 21:12 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6695e45f-4530-ab39-923d-8347649762bb@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=aldas60@gmail.com \
--cc=eantoranz@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.henneman@linaro.org \
--cc=madhumithabiw@gmail.com \
--cc=mdejesusfilho@gmail.com \
--cc=mh12gx2825@gmail.com \
--cc=rapiz@foxmail.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.