[PATCH] qla2xxx: Fix excessive messages during device logout

[PATCH] qla2xxx: Fix excessive messages during device logout

[Nilesh Javali]

From: Arun Easi <aeasi@marvell.com>

Disable default logging of some IO path messages which can be
turned back on by setting ql2xextended_error_logging.

Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index ece60267b971..b26f2699adb2 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req,
 	}
 
 	if (unlikely(logit))
-		ql_log(ql_log_warn, fcport->vha, 0x5060,
+		ql_log(ql_dbg_io, fcport->vha, 0x5060,
 		   "NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x  ox_id=%x\n",
 		   sp->name, sp->handle, comp_status,
 		   fd->transferred_length, le32_to_cpu(sts->residual_len),
@@ -3491,7 +3491,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
 
 out:
 	if (logit)
-		ql_log(ql_log_warn, fcport->vha, 0x3022,
+		ql_log(ql_dbg_io, fcport->vha, 0x3022,
 		       "FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n",
 		       comp_status, scsi_status, res, vha->host_no,
 		       cp->device->id, cp->device->lun, fcport->d_id.b.domain,
-- 
2.19.0.rc0

Re: [PATCH] qla2xxx: Fix excessive messages during device logout

[Ewan Milne]

Thanks for posting this.  Martin, can we get this in soon?  The
logging could be overwhelming.

Reviewed-by: Ewan D. Milne <emilne@redhat.com>

On Fri, Sep 24, 2021 at 11:52 PM Nilesh Javali <njavali@marvell.com> wrote:
>
> From: Arun Easi <aeasi@marvell.com>
>
> Disable default logging of some IO path messages which can be
> turned back on by setting ql2xextended_error_logging.
>
> Signed-off-by: Arun Easi <aeasi@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
>  drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index ece60267b971..b26f2699adb2 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req,
>         }
>
>         if (unlikely(logit))
> -               ql_log(ql_log_warn, fcport->vha, 0x5060,
> +               ql_log(ql_dbg_io, fcport->vha, 0x5060,
>                    "NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x  ox_id=%x\n",
>                    sp->name, sp->handle, comp_status,
>                    fd->transferred_length, le32_to_cpu(sts->residual_len),
> @@ -3491,7 +3491,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
>
>  out:
>         if (logit)
> -               ql_log(ql_log_warn, fcport->vha, 0x3022,
> +               ql_log(ql_dbg_io, fcport->vha, 0x3022,
>                        "FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n",
>                        comp_status, scsi_status, res, vha->host_no,
>                        cp->device->id, cp->device->lun, fcport->d_id.b.domain,
> --
> 2.19.0.rc0
>

Re: [PATCH] qla2xxx: Fix excessive messages during device logout

[Himanshu Madhani]

> On Sep 24, 2021, at 10:51 PM, Nilesh Javali <njavali@marvell.com> wrote:
> 
> From: Arun Easi <aeasi@marvell.com>
> 
> Disable default logging of some IO path messages which can be
> turned back on by setting ql2xextended_error_logging.
> 
> Signed-off-by: Arun Easi <aeasi@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index ece60267b971..b26f2699adb2 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req,
> 	}
> 
> 	if (unlikely(logit))
> -		ql_log(ql_log_warn, fcport->vha, 0x5060,
> +		ql_log(ql_dbg_io, fcport->vha, 0x5060,
> 		   "NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x  ox_id=%x\n",
> 		   sp->name, sp->handle, comp_status,
> 		   fd->transferred_length, le32_to_cpu(sts->residual_len),
> @@ -3491,7 +3491,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
> 
> out:
> 	if (logit)
> -		ql_log(ql_log_warn, fcport->vha, 0x3022,
> +		ql_log(ql_dbg_io, fcport->vha, 0x3022,
> 		       "FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n",
> 		       comp_status, scsi_status, res, vha->host_no,
> 		       cp->device->id, cp->device->lun, fcport->d_id.b.domain,
> -- 
> 2.19.0.rc0

Looks Good. Indeed a much needed fix. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix excessive messages during device logout

[Martin K. Petersen]

On Fri, 24 Sep 2021 20:51:54 -0700, Nilesh Javali wrote:

> From: Arun Easi <aeasi@marvell.com>
> 
> Disable default logging of some IO path messages which can be
> turned back on by setting ql2xextended_error_logging.
> 
> 

Applied to 5.15/scsi-fixes, thanks!

[1/1] qla2xxx: Fix excessive messages during device logout
      https://git.kernel.org/mkp/scsi/c/8e2d81c6b5be

-- 
Martin K. Petersen	Oracle Linux Engineering