* [f2fs-dev] [PATCH] f2fs: fix whint_mode mount option error
@ 2021-09-27 6:09 Fengnan Chang via Linux-f2fs-devel
2021-09-28 15:32 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Fengnan Chang via Linux-f2fs-devel @ 2021-09-27 6:09 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: tanghuan, Fengnan Chang, linux-f2fs-devel
When mount with whint_mode option, it doesn't work, Fix it.
Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
Reported-by: tanghuan <tanghuan@vivo.com>
Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
---
fs/f2fs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 78ebc306ee2b..86eeb019cc52 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
/* Not pass down write hints if the number of active logs is lesser
* than NR_CURSEG_PERSIST_TYPE.
*/
- if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
+ if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE)
F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
--
2.32.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix whint_mode mount option error
2021-09-27 6:09 [f2fs-dev] [PATCH] f2fs: fix whint_mode mount option error Fengnan Chang via Linux-f2fs-devel
@ 2021-09-28 15:32 ` Chao Yu
2021-09-28 19:08 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2021-09-28 15:32 UTC (permalink / raw)
To: Fengnan Chang, jaegeuk; +Cc: tanghuan, linux-f2fs-devel
On 2021/9/27 14:09, Fengnan Chang wrote:
> When mount with whint_mode option, it doesn't work, Fix it.
> Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
Thanks for the patch, it looks Keoseong Park has submitted the same
fix patch a little bit earlier....
I guess we need to select one of your patches, and merge Singed-off
and Reported tags from another one.
Thanks,
>
> Reported-by: tanghuan <tanghuan@vivo.com>
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> ---
> fs/f2fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 78ebc306ee2b..86eeb019cc52 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> /* Not pass down write hints if the number of active logs is lesser
> * than NR_CURSEG_PERSIST_TYPE.
> */
> - if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
> + if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE)
> F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
>
> if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix whint_mode mount option error
2021-09-28 15:32 ` Chao Yu
@ 2021-09-28 19:08 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2021-09-28 19:08 UTC (permalink / raw)
To: Chao Yu; +Cc: tanghuan, Fengnan Chang, linux-f2fs-devel
On 09/28, Chao Yu wrote:
> On 2021/9/27 14:09, Fengnan Chang wrote:
> > When mount with whint_mode option, it doesn't work, Fix it.
> > Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
>
> Thanks for the patch, it looks Keoseong Park has submitted the same
> fix patch a little bit earlier....
>
> I guess we need to select one of your patches, and merge Singed-off
> and Reported tags from another one.
Merged with SOB and Reported-by.
>
> Thanks,
>
> >
> > Reported-by: tanghuan <tanghuan@vivo.com>
> > Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> > ---
> > fs/f2fs/super.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 78ebc306ee2b..86eeb019cc52 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> > /* Not pass down write hints if the number of active logs is lesser
> > * than NR_CURSEG_PERSIST_TYPE.
> > */
> > - if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
> > + if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE)
> > F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
> > if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-28 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 6:09 [f2fs-dev] [PATCH] f2fs: fix whint_mode mount option error Fengnan Chang via Linux-f2fs-devel
2021-09-28 15:32 ` Chao Yu
2021-09-28 19:08 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.