From: Matthew Auld <matthew.auld@intel.com> To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Subject: [PATCH v5 12/13] drm/i915/ttm: use cached system pages when evicting lmem Date: Mon, 27 Sep 2021 12:41:13 +0100 [thread overview] Message-ID: <20210927114114.152310-12-matthew.auld@intel.com> (raw) In-Reply-To: <20210927114114.152310-1-matthew.auld@intel.com> This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 194e5f1deda8..46d57541c0b2 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -134,11 +134,11 @@ static enum ttm_caching i915_ttm_select_tt_caching(const struct drm_i915_gem_object *obj) { /* - * Objects only allowed in system get cached cpu-mappings. - * Other objects get WC mapping for now. Even if in system. + * Objects only allowed in system get cached cpu-mappings, or when + * evicting lmem-only buffers to system for swapping. Other objects get + * WC mapping for now. Even if in system. */ - if (obj->mm.region->type == INTEL_MEMORY_SYSTEM && - obj->mm.n_placements <= 1) + if (obj->mm.n_placements <= 1) return ttm_cached; return ttm_write_combined; -- 2.26.3
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.auld@intel.com> To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Subject: [Intel-gfx] [PATCH v5 12/13] drm/i915/ttm: use cached system pages when evicting lmem Date: Mon, 27 Sep 2021 12:41:13 +0100 [thread overview] Message-ID: <20210927114114.152310-12-matthew.auld@intel.com> (raw) In-Reply-To: <20210927114114.152310-1-matthew.auld@intel.com> This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 194e5f1deda8..46d57541c0b2 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -134,11 +134,11 @@ static enum ttm_caching i915_ttm_select_tt_caching(const struct drm_i915_gem_object *obj) { /* - * Objects only allowed in system get cached cpu-mappings. - * Other objects get WC mapping for now. Even if in system. + * Objects only allowed in system get cached cpu-mappings, or when + * evicting lmem-only buffers to system for swapping. Other objects get + * WC mapping for now. Even if in system. */ - if (obj->mm.region->type == INTEL_MEMORY_SYSTEM && - obj->mm.n_placements <= 1) + if (obj->mm.n_placements <= 1) return ttm_cached; return ttm_write_combined; -- 2.26.3
next prev parent reply other threads:[~2021-09-27 11:43 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-27 11:41 [PATCH v5 01/13] drm/ttm: stop calling tt_swapin in vm_access Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 02/13] drm/ttm: stop setting page->index for the ttm_tt Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 03/13] drm/ttm: move ttm_tt_{add, clear}_mapping into amdgpu Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 04/13] drm/ttm: remove TTM_PAGE_FLAG_NO_RETRY Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 05/13] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/ Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 06/13] drm/ttm: add some kernel-doc for TTM_TT_FLAG_* Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 07/13] drm/ttm: add TTM_TT_FLAG_EXTERNAL_MAPPABLE Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 08/13] drm/i915/gem: Break out some shmem backend utils Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-27 11:41 ` [PATCH v5 09/13] drm/i915/ttm: add tt shmem backend Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-29 11:07 ` Thomas Hellström 2021-09-29 11:07 ` [Intel-gfx] " Thomas Hellström 2021-10-05 2:05 ` Zeng, Oak 2021-10-05 2:05 ` Zeng, Oak 2021-10-05 13:48 ` Thomas Hellström 2021-10-05 14:23 ` Zeng, Oak 2021-10-05 14:23 ` Zeng, Oak 2021-10-05 17:07 ` Matthew Auld 2021-10-05 18:33 ` Zeng, Oak 2021-10-05 18:33 ` Zeng, Oak 2021-09-27 11:41 ` [PATCH v5 10/13] drm/i915: try to simplify make_{un}shrinkable Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-29 13:00 ` Thomas Hellström 2021-09-29 13:00 ` [Intel-gfx] " Thomas Hellström 2021-09-27 11:41 ` [PATCH v5 11/13] drm/i915/ttm: make evicted shmem pages visible to the shrinker Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-29 11:47 ` Thomas Hellström 2021-09-29 11:47 ` [Intel-gfx] " Thomas Hellström 2021-09-27 11:41 ` Matthew Auld [this message] 2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 12/13] drm/i915/ttm: use cached system pages when evicting lmem Matthew Auld 2021-09-29 11:54 ` Thomas Hellström 2021-09-29 11:54 ` [Intel-gfx] " Thomas Hellström 2021-09-30 10:04 ` Michel Dänzer 2021-09-30 10:04 ` [Intel-gfx] " Michel Dänzer 2021-09-30 12:27 ` Matthew Auld 2021-09-30 12:27 ` [Intel-gfx] " Matthew Auld 2021-09-30 12:55 ` Michel Dänzer 2021-09-30 12:55 ` [Intel-gfx] " Michel Dänzer 2021-09-27 11:41 ` [PATCH v5 13/13] drm/i915/ttm: enable shmem tt backend Matthew Auld 2021-09-27 11:41 ` [Intel-gfx] " Matthew Auld 2021-09-29 12:00 ` Thomas Hellström 2021-09-29 12:00 ` [Intel-gfx] " Thomas Hellström 2021-09-27 11:47 ` [PATCH v5 01/13] drm/ttm: stop calling tt_swapin in vm_access Christian König 2021-09-27 11:47 ` [Intel-gfx] " Christian König 2021-09-27 16:14 ` Matthew Auld 2021-09-29 12:01 ` Christian König 2021-09-29 13:45 ` Matthew Auld 2021-09-27 17:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,01/13] " Patchwork 2021-09-27 17:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-09-27 18:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-09-27 21:29 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-05 2:17 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v5,01/13] drm/ttm: stop calling tt_swapin in vm_access (rev2) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210927114114.152310-12-matthew.auld@intel.com \ --to=matthew.auld@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=thomas.hellstrom@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.