All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: igt-dev@lists.freedesktop.org, markyacoub@google.com
Cc: rodrigo.siqueira@amd.com
Subject: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
Date: Mon, 27 Sep 2021 12:07:00 -0400	[thread overview]
Message-ID: <20210927160700.1570885-1-aurabindo.pillai@amd.com> (raw)

[Why]
The rationale of the test does not hold true for AMD hardware. The
aperture size calculation has an upper bound check which is done through
i915 specific IOCTL. Hence this part of subtest must be moved
out of the platform agnostic tests. Moreover, AMD hardware
supports buffers larger than aperture size.

[How]
Skip the bo-too-big subtest unless its run on i915 as the test fails on
AMD, VKMS and VC4

Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
 tests/kms_flip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 54137871..20112de1 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
 	/* 256 MB is usually the maximum mappable aperture,
 	 * (make it 4x times that to ensure failure) */
 	if (o->flags & TEST_BO_TOOBIG) {
+		igt_skip_on(!is_i915_device(drm_fd));
 		bo_size = 4*gem_mappable_aperture_size(drm_fd);
 		igt_require(bo_size < gem_global_aperture_size(drm_fd));
 	}
-- 
2.30.2

             reply	other threads:[~2021-09-27 16:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 16:07 Aurabindo Pillai [this message]
2021-09-27 17:21 ` [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big Mark Yacoub
2021-09-27 17:28   ` Pillai, Aurabindo
2021-09-27 17:34     ` Mark Yacoub
2021-09-27 19:10       ` Pillai, Aurabindo
2021-09-27 19:12         ` Mark Yacoub
2021-09-27 19:23           ` Pillai, Aurabindo
2021-09-28  9:15         ` Petri Latvala
2021-09-28 13:35           ` Aurabindo Pillai
2021-09-28 13:53             ` Petri Latvala
2021-09-28 14:05               ` Aurabindo Pillai
2021-09-28 14:43                 ` Rodrigo Siqueira
2021-09-28 14:48                   ` Mark Yacoub
2021-09-28 15:17                     ` Petri Latvala
2021-09-28 15:23                       ` Mark Yacoub
2021-09-28 15:37                         ` Petri Latvala
2021-09-28 15:37                           ` Mark Yacoub
2021-09-27 17:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-27 20:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927160700.1570885-1-aurabindo.pillai@amd.com \
    --to=aurabindo.pillai@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=markyacoub@google.com \
    --cc=rodrigo.siqueira@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.