From: Mark Yacoub <markyacoub@chromium.org>
To: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>,
Petri Latvala <petri.latvala@intel.com>,
Development mailing list for IGT GPU Tools
<igt-dev@lists.freedesktop.org>,
Mark Yacoub <markyacoub@google.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
Date: Tue, 28 Sep 2021 10:48:17 -0400 [thread overview]
Message-ID: <CAJUqKUo5ehK7zFSGXehd6oWmsWJu3ku2v9PT_vx_4HCj1Ord6A@mail.gmail.com> (raw)
In-Reply-To: <20210928144347.iv3dxo4rmu7u42c7@outlook.office365.com>
On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
<Rodrigo.Siqueira@amd.com> wrote:
>
> Hi,
>
> I also tested it using vkms and vc4.
>
> I already applied the V1 in the upstream.
>
> Thanks
> Siqueira
>
> On 09/28, Aurabindo Pillai wrote:
> >
> > On 9/28/21 9:53 AM, Petri Latvala wrote:
> > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > > Skipping using the continue statement has the side effect of this
> > > > > > subtest being absent from the list of subtests, when running the
> > > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > > running system in any way.
Hi Petri, can you elaborate more on this. I'm curious to understand
what you mean. I'm slightly confused.
> > > > >
> > > > >
> > > > In that case, please discard v2. Is this version good enough ?
> > > >
> > >
> > > No objections with v1.
> > > Acked-by: Petri Latvala <petri.latvala@intel.com>
> >
> >
> > Thank you.
> >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
next prev parent reply other threads:[~2021-09-28 14:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 16:07 [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big Aurabindo Pillai
2021-09-27 17:21 ` Mark Yacoub
2021-09-27 17:28 ` Pillai, Aurabindo
2021-09-27 17:34 ` Mark Yacoub
2021-09-27 19:10 ` Pillai, Aurabindo
2021-09-27 19:12 ` Mark Yacoub
2021-09-27 19:23 ` Pillai, Aurabindo
2021-09-28 9:15 ` Petri Latvala
2021-09-28 13:35 ` Aurabindo Pillai
2021-09-28 13:53 ` Petri Latvala
2021-09-28 14:05 ` Aurabindo Pillai
2021-09-28 14:43 ` Rodrigo Siqueira
2021-09-28 14:48 ` Mark Yacoub [this message]
2021-09-28 15:17 ` Petri Latvala
2021-09-28 15:23 ` Mark Yacoub
2021-09-28 15:37 ` Petri Latvala
2021-09-28 15:37 ` Mark Yacoub
2021-09-27 17:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-27 20:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJUqKUo5ehK7zFSGXehd6oWmsWJu3ku2v9PT_vx_4HCj1Ord6A@mail.gmail.com \
--to=markyacoub@chromium.org \
--cc=Rodrigo.Siqueira@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=markyacoub@google.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.