[PATCH 1/3] util: surround MAC_STR array access with ()

[PATCH 1/3] util: surround MAC_STR array access with ()

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

This allows printing from pointer offsets, for example:

MAC_STR(buf + 10)
---
 src/util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util.h b/src/util.h
index ae640698..23353ddb 100644
--- a/src/util.h
+++ b/src/util.h
@@ -29,7 +29,7 @@
 #define align_len(len, boundary) (((len)+(boundary)-1) & ~((boundary)-1))
 
 #define MAC "%02x:%02x:%02x:%02x:%02x:%02x"
-#define MAC_STR(a) a[0], a[1], a[2], a[3], a[4], a[5]
+#define MAC_STR(a) (a)[0], (a)[1], (a)[2], (a)[3], (a)[4], (a)[5]
 
 const char *util_ssid_to_utf8(size_t len, const uint8_t *ssid);
 bool util_ssid_is_utf8(size_t len, const uint8_t *ssid);
-- 
2.31.1

Re: [PATCH 1/3] util: surround MAC_STR array access with ()

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hi James,

On 9/27/21 5:41 PM, James Prestwood wrote:
> This allows printing from pointer offsets, for example:
> 
> MAC_STR(buf + 10)
> ---
>   src/util.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

All applied, thanks.

Regards,
-Denis