[PATCH] block: print the current process in handle_bad_sector

[PATCH] block: print the current process in handle_bad_sector

[Christoph Hellwig]

Make the bad sector information a little more useful by printing
current->comm to identify the caller.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 5454db2fa263b..4c2a3db4bd336 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -636,8 +636,9 @@ static void handle_bad_sector(struct bio *bio, sector_t maxsector)
 {
 	char b[BDEVNAME_SIZE];
 
-	pr_info_ratelimited("attempt to access beyond end of device\n"
+	pr_info_ratelimited("%s: attempt to access beyond end of device\n"
 			    "%s: rw=%d, want=%llu, limit=%llu\n",
+			    current->comm,
 			    bio_devname(bio, b), bio->bi_opf,
 			    bio_end_sector(bio), maxsector);
 }
-- 
2.30.2

Re: [PATCH] block: print the current process in handle_bad_sector

[Damien Le Moal]

On 2021/09/28 14:27, Christoph Hellwig wrote:
> Make the bad sector information a little more useful by printing
> current->comm to identify the caller.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 5454db2fa263b..4c2a3db4bd336 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -636,8 +636,9 @@ static void handle_bad_sector(struct bio *bio, sector_t maxsector)
>  {
>  	char b[BDEVNAME_SIZE];
>  
> -	pr_info_ratelimited("attempt to access beyond end of device\n"
> +	pr_info_ratelimited("%s: attempt to access beyond end of device\n"
>  			    "%s: rw=%d, want=%llu, limit=%llu\n",
> +			    current->comm,
>  			    bio_devname(bio, b), bio->bi_opf,
>  			    bio_end_sector(bio), maxsector);
>  }

Looks good. A stack dump, while noisier, would be even more useful :)

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] block: print the current process in handle_bad_sector

[Chaitanya Kulkarni]

On 9/27/21 10:27 PM, Christoph Hellwig wrote:
> Make the bad sector information a little more useful by printing
> current->comm to identify the caller.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

Re: [PATCH] block: print the current process in handle_bad_sector

[Jens Axboe]

On 9/27/21 11:27 PM, Christoph Hellwig wrote:
> Make the bad sector information a little more useful by printing
> current->comm to identify the caller.

Applied, thanks.

-- 
Jens Axboe