All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, 0day robot <lkp@intel.com>
Subject: drivers/pinctrl/renesas/pinctrl-rzg2l.c:1048:19: warning: variable 'irq' is uninitialized when used here
Date: Tue, 28 Sep 2021 07:37:51 +0800	[thread overview]
Message-ID: <202109280744.nZycLrNL-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3488 bytes --]

tree:   https://github.com/0day-ci/linux/commits/Lad-Prabhakar/Renesas-RZ-G2L-IRQC-support/20210922-114225
head:   148cc816430df44e59684c9d9d841517efebdd02
commit: 87298d46797ed3e16804c5662b4338243d1548f4 pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO interrupt
date:   6 days ago
config: arm64-randconfig-r012-20210927 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/87298d46797ed3e16804c5662b4338243d1548f4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lad-Prabhakar/Renesas-RZ-G2L-IRQC-support/20210922-114225
        git checkout 87298d46797ed3e16804c5662b4338243d1548f4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/renesas/pinctrl-rzg2l.c:1048:19: warning: variable 'irq' is uninitialized when used here [-Wuninitialized]
           chip_data->irq = irq;
                            ^~~
   drivers/pinctrl/renesas/pinctrl-rzg2l.c:1029:9: note: initialize the variable 'irq' to silence this warning
           int irq, ret;
                  ^
                   = 0
   1 warning generated.


vim +/irq +1048 drivers/pinctrl/renesas/pinctrl-rzg2l.c

  1019	
  1020	static int rzg2l_gpio_irq_domain_alloc(struct irq_domain *domain,
  1021					       unsigned int virq,
  1022					       unsigned int nr_irqs, void *arg)
  1023	{
  1024		struct rzg2l_pinctrl_irq_chip_data *chip_data = NULL;
  1025		struct rzg2l_pinctrl *pctrl = domain->host_data;
  1026		struct irq_fwspec parent_fwspec;
  1027		irq_hw_number_t hwirq;
  1028		unsigned int type;
  1029		int irq, ret;
  1030		int gpioint;
  1031	
  1032		if (WARN_ON(nr_irqs != 1))
  1033			return -EINVAL;
  1034	
  1035		ret = irq_domain_translate_twocell(domain, arg, &hwirq, &type);
  1036		if (ret)
  1037			return ret;
  1038	
  1039		gpioint = rzg2l_gpio_get_gpioint(hwirq);
  1040		if (gpioint < 0)
  1041			return ret;
  1042	
  1043		chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL);
  1044		if (!chip_data)
  1045			return -ENOMEM;
  1046	
  1047		chip_data->pctrl = pctrl;
> 1048		chip_data->irq = irq;
  1049		ret = irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
  1050						    &pctrl->irq_chip, chip_data);
  1051		if (ret)
  1052			goto free_data;
  1053	
  1054		/* parent is IRQC */
  1055		parent_fwspec.fwnode = domain->parent->fwnode;
  1056		parent_fwspec.param_count = 3;
  1057		parent_fwspec.param[0] = gpioint;
  1058		parent_fwspec.param[1] = type;
  1059		parent_fwspec.param[2] = 1;
  1060		ret = irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
  1061		if (ret)
  1062			goto free_data;
  1063	
  1064		return 0;
  1065	
  1066	free_data:
  1067		kfree(chip_data);
  1068		return ret;
  1069	}
  1070	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30925 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/pinctrl/renesas/pinctrl-rzg2l.c:1048:19: warning: variable 'irq' is uninitialized when used here
Date: Tue, 28 Sep 2021 07:37:51 +0800	[thread overview]
Message-ID: <202109280744.nZycLrNL-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3581 bytes --]

tree:   https://github.com/0day-ci/linux/commits/Lad-Prabhakar/Renesas-RZ-G2L-IRQC-support/20210922-114225
head:   148cc816430df44e59684c9d9d841517efebdd02
commit: 87298d46797ed3e16804c5662b4338243d1548f4 pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO interrupt
date:   6 days ago
config: arm64-randconfig-r012-20210927 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/87298d46797ed3e16804c5662b4338243d1548f4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lad-Prabhakar/Renesas-RZ-G2L-IRQC-support/20210922-114225
        git checkout 87298d46797ed3e16804c5662b4338243d1548f4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/renesas/pinctrl-rzg2l.c:1048:19: warning: variable 'irq' is uninitialized when used here [-Wuninitialized]
           chip_data->irq = irq;
                            ^~~
   drivers/pinctrl/renesas/pinctrl-rzg2l.c:1029:9: note: initialize the variable 'irq' to silence this warning
           int irq, ret;
                  ^
                   = 0
   1 warning generated.


vim +/irq +1048 drivers/pinctrl/renesas/pinctrl-rzg2l.c

  1019	
  1020	static int rzg2l_gpio_irq_domain_alloc(struct irq_domain *domain,
  1021					       unsigned int virq,
  1022					       unsigned int nr_irqs, void *arg)
  1023	{
  1024		struct rzg2l_pinctrl_irq_chip_data *chip_data = NULL;
  1025		struct rzg2l_pinctrl *pctrl = domain->host_data;
  1026		struct irq_fwspec parent_fwspec;
  1027		irq_hw_number_t hwirq;
  1028		unsigned int type;
  1029		int irq, ret;
  1030		int gpioint;
  1031	
  1032		if (WARN_ON(nr_irqs != 1))
  1033			return -EINVAL;
  1034	
  1035		ret = irq_domain_translate_twocell(domain, arg, &hwirq, &type);
  1036		if (ret)
  1037			return ret;
  1038	
  1039		gpioint = rzg2l_gpio_get_gpioint(hwirq);
  1040		if (gpioint < 0)
  1041			return ret;
  1042	
  1043		chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL);
  1044		if (!chip_data)
  1045			return -ENOMEM;
  1046	
  1047		chip_data->pctrl = pctrl;
> 1048		chip_data->irq = irq;
  1049		ret = irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
  1050						    &pctrl->irq_chip, chip_data);
  1051		if (ret)
  1052			goto free_data;
  1053	
  1054		/* parent is IRQC */
  1055		parent_fwspec.fwnode = domain->parent->fwnode;
  1056		parent_fwspec.param_count = 3;
  1057		parent_fwspec.param[0] = gpioint;
  1058		parent_fwspec.param[1] = type;
  1059		parent_fwspec.param[2] = 1;
  1060		ret = irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
  1061		if (ret)
  1062			goto free_data;
  1063	
  1064		return 0;
  1065	
  1066	free_data:
  1067		kfree(chip_data);
  1068		return ret;
  1069	}
  1070	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30925 bytes --]

             reply	other threads:[~2021-09-27 23:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 23:37 kernel test robot [this message]
2021-09-27 23:37 ` drivers/pinctrl/renesas/pinctrl-rzg2l.c:1048:19: warning: variable 'irq' is uninitialized when used here kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109280744.nZycLrNL-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.