From: Mark Rutland <mark.rutland@arm.com> To: Dmitry Vyukov <dvyukov@google.com> Cc: syzbot <syzbot+488ddf8087564d6de6e2@syzkaller.appspotmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, will@kernel.org Subject: Re: [syzbot] upstream test error: KASAN: invalid-access Read in __entry_tramp_text_end Date: Tue, 28 Sep 2021 11:35:43 +0100 [thread overview] Message-ID: <20210928103543.GF1924@C02TD0UTHF1T.local> (raw) In-Reply-To: <CACT4Y+actfuftwMMOGXmEsLYbnCnqcZ2gJGeoMLsFCUNE-AxcQ@mail.gmail.com> On Tue, Sep 28, 2021 at 12:19:23PM +0200, Dmitry Vyukov wrote: > On Mon, 27 Sept 2021 at 19:18, Mark Rutland <mark.rutland@arm.com> wrote: > > What's happened here is that __d_lookup() (via a few layers of inlining) called > > load_unaligned_zeropad(). The `LDR` at the start of the asm faulted (I suspect > > due to a tag check fault), and so the exception handler replaced the PC with > > the (anonymous) fixup function. This is akin to a tail or sibling call, and so > > the fixup function entirely replaces __d_lookup() in the trace. > > > > The fixup function itself has an `LDR` which faulted (because it's > > designed to fixup page alignment problems, not tag check faults), and > > that is what's reported here. > > > > As the fixup function is anonymous, and the nearest prior symbol in .text is > > __entry_tramp_text_end, it gets symbolized as an offset from that. > > > > We can make the unwinds a bit nicer by adding some markers (e.g. patch > > below), but actually fixing this case will require some more thought. > > > > Thanks, > > Mark. > > > > ---->8---- > > diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S > > index 709d2c433c5e..127096a0faea 100644 > > --- a/arch/arm64/kernel/vmlinux.lds.S > > +++ b/arch/arm64/kernel/vmlinux.lds.S > > @@ -111,6 +111,11 @@ jiffies = jiffies_64; > > #define TRAMP_TEXT > > #endif > > > > +#define FIXUP_TEXT \ > > + __fixup_text_start = .; \ > > + *(.fixup); \ > > + __fixup_text_end = .; > > + > > /* > > * The size of the PE/COFF section that covers the kernel image, which > > * runs from _stext to _edata, must be a round multiple of the PE/COFF > > @@ -161,7 +166,7 @@ SECTIONS > > IDMAP_TEXT > > HIBERNATE_TEXT > > TRAMP_TEXT > > - *(.fixup) > > + FIXUP_TEXT > > *(.gnu.warning) > > . = ALIGN(16); > > *(.got) /* Global offset table */ > > > Oh, good it's very local to the .fixup thing rather than a common > issue that affects all unwinds. Yes, though the other issue I mentioned *does* exist, and can occur separately, even if we're getting lucky and not hitting it often enough to notice. > In the other x86 thread Josh Poimboeuf suggested to use asm goto to a > cold part of the function instead of .fixup: > https://lore.kernel.org/lkml/20210927234543.6waods7rraxseind@treble/ > This sounds like a more reliable solution that will cause less > maintenance burden. Would it work for arm64 as well? Maybe we can use that when CC_HAS_ASM_GOTO_OUTPUT is avaiable, but in general we can't rely on asm goto supporting output arguments (and IIRC GCC doesn't support that at all), so we'd still have to support the current fixup scheme. Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: Dmitry Vyukov <dvyukov@google.com> Cc: syzbot <syzbot+488ddf8087564d6de6e2@syzkaller.appspotmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, will@kernel.org Subject: Re: [syzbot] upstream test error: KASAN: invalid-access Read in __entry_tramp_text_end Date: Tue, 28 Sep 2021 11:35:43 +0100 [thread overview] Message-ID: <20210928103543.GF1924@C02TD0UTHF1T.local> (raw) In-Reply-To: <CACT4Y+actfuftwMMOGXmEsLYbnCnqcZ2gJGeoMLsFCUNE-AxcQ@mail.gmail.com> On Tue, Sep 28, 2021 at 12:19:23PM +0200, Dmitry Vyukov wrote: > On Mon, 27 Sept 2021 at 19:18, Mark Rutland <mark.rutland@arm.com> wrote: > > What's happened here is that __d_lookup() (via a few layers of inlining) called > > load_unaligned_zeropad(). The `LDR` at the start of the asm faulted (I suspect > > due to a tag check fault), and so the exception handler replaced the PC with > > the (anonymous) fixup function. This is akin to a tail or sibling call, and so > > the fixup function entirely replaces __d_lookup() in the trace. > > > > The fixup function itself has an `LDR` which faulted (because it's > > designed to fixup page alignment problems, not tag check faults), and > > that is what's reported here. > > > > As the fixup function is anonymous, and the nearest prior symbol in .text is > > __entry_tramp_text_end, it gets symbolized as an offset from that. > > > > We can make the unwinds a bit nicer by adding some markers (e.g. patch > > below), but actually fixing this case will require some more thought. > > > > Thanks, > > Mark. > > > > ---->8---- > > diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S > > index 709d2c433c5e..127096a0faea 100644 > > --- a/arch/arm64/kernel/vmlinux.lds.S > > +++ b/arch/arm64/kernel/vmlinux.lds.S > > @@ -111,6 +111,11 @@ jiffies = jiffies_64; > > #define TRAMP_TEXT > > #endif > > > > +#define FIXUP_TEXT \ > > + __fixup_text_start = .; \ > > + *(.fixup); \ > > + __fixup_text_end = .; > > + > > /* > > * The size of the PE/COFF section that covers the kernel image, which > > * runs from _stext to _edata, must be a round multiple of the PE/COFF > > @@ -161,7 +166,7 @@ SECTIONS > > IDMAP_TEXT > > HIBERNATE_TEXT > > TRAMP_TEXT > > - *(.fixup) > > + FIXUP_TEXT > > *(.gnu.warning) > > . = ALIGN(16); > > *(.got) /* Global offset table */ > > > Oh, good it's very local to the .fixup thing rather than a common > issue that affects all unwinds. Yes, though the other issue I mentioned *does* exist, and can occur separately, even if we're getting lucky and not hitting it often enough to notice. > In the other x86 thread Josh Poimboeuf suggested to use asm goto to a > cold part of the function instead of .fixup: > https://lore.kernel.org/lkml/20210927234543.6waods7rraxseind@treble/ > This sounds like a more reliable solution that will cause less > maintenance burden. Would it work for arm64 as well? Maybe we can use that when CC_HAS_ASM_GOTO_OUTPUT is avaiable, but in general we can't rely on asm goto supporting output arguments (and IIRC GCC doesn't support that at all), so we'd still have to support the current fixup scheme. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-28 10:35 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-04 11:57 [syzbot] upstream test error: KASAN: invalid-access Read in __entry_tramp_text_end syzbot 2021-09-17 15:03 ` Dmitry Vyukov 2021-09-17 15:03 ` Dmitry Vyukov 2021-09-21 16:51 ` Mark Rutland 2021-09-21 16:51 ` Mark Rutland 2021-09-27 14:27 ` Dmitry Vyukov 2021-09-27 14:27 ` Dmitry Vyukov 2021-09-27 14:30 ` Dmitry Vyukov 2021-09-27 14:30 ` Dmitry Vyukov 2021-09-27 17:01 ` Mark Rutland 2021-09-27 17:01 ` Mark Rutland 2021-09-27 17:18 ` Mark Rutland 2021-09-27 17:18 ` Mark Rutland 2021-09-28 10:19 ` Dmitry Vyukov 2021-09-28 10:19 ` Dmitry Vyukov 2021-09-28 10:35 ` Mark Rutland [this message] 2021-09-28 10:35 ` Mark Rutland 2021-09-29 1:36 ` Josh Poimboeuf 2021-09-29 1:36 ` Josh Poimboeuf 2021-09-29 7:39 ` Peter Zijlstra 2021-09-29 7:39 ` Peter Zijlstra 2021-09-29 8:50 ` Mark Rutland 2021-09-29 8:50 ` Mark Rutland 2021-09-29 9:59 ` Peter Zijlstra 2021-09-29 9:59 ` Peter Zijlstra 2021-09-29 10:37 ` Mark Rutland 2021-09-29 10:37 ` Mark Rutland 2021-09-29 11:43 ` Peter Zijlstra 2021-09-29 11:43 ` Peter Zijlstra 2021-09-30 19:26 ` Josh Poimboeuf 2021-09-30 19:26 ` Josh Poimboeuf 2021-10-01 12:27 ` Mark Rutland 2021-10-01 12:27 ` Mark Rutland 2021-10-02 5:10 ` Josh Poimboeuf 2021-10-02 5:10 ` Josh Poimboeuf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210928103543.GF1924@C02TD0UTHF1T.local \ --to=mark.rutland@arm.com \ --cc=dvyukov@google.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=syzbot+488ddf8087564d6de6e2@syzkaller.appspotmail.com \ --cc=syzkaller-bugs@googlegroups.com \ --cc=viro@zeniv.linux.org.uk \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.