* [PATCH -next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c
@ 2021-09-28 16:40 Mianhan Liu
2021-09-29 0:34 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Mianhan Liu @ 2021-09-28 16:40 UTC (permalink / raw)
To: David S. Miller, Hideaki YOSHIFUJI, David Ahern
Cc: Jakub Kicinski, netdev, linux-kernel, Mianhan Liu
fib_notifier.chasn't use any macro or function declared in net/netns/ipv4.h.
Thus, these files can be removed from fib_notifier.c safely without
affecting the compilation of the net/ipv4 module.
Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
---
net/ipv4/fib_notifier.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv4/fib_notifier.c b/net/ipv4/fib_notifier.c
index 0c28bd469..0e23ade74 100644
--- a/net/ipv4/fib_notifier.c
+++ b/net/ipv4/fib_notifier.c
@@ -6,7 +6,6 @@
#include <linux/export.h>
#include <net/net_namespace.h>
#include <net/fib_notifier.h>
-#include <net/netns/ipv4.h>
#include <net/ip_fib.h>
int call_fib4_notifier(struct notifier_block *nb,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c
2021-09-28 16:40 [PATCH -next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c Mianhan Liu
@ 2021-09-29 0:34 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-09-29 0:34 UTC (permalink / raw)
To: Mianhan Liu
Cc: David S. Miller, Hideaki YOSHIFUJI, David Ahern, netdev, linux-kernel
On Wed, 29 Sep 2021 00:40:11 +0800 Mianhan Liu wrote:
> fib_notifier.chasn't use any macro or function declared in net/netns/ipv4.h.
> Thus, these files can be removed from fib_notifier.c safely without
> affecting the compilation of the net/ipv4 module.
>
> Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
This one looks fine, applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-29 0:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 16:40 [PATCH -next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c Mianhan Liu
2021-09-29 0:34 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.