* [PATCH] drivers/pci/setup-irq.c: Fix up comments.
@ 2021-09-18 20:18 Pranay Sanghai
2021-09-28 18:47 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Pranay Sanghai @ 2021-09-18 20:18 UTC (permalink / raw)
To: bhelgaas; +Cc: linux-pci, linux-kernel
Make comments follow multi-line comment conventions. No functional change intended.
Signed-off-by: Pranay Sanghai <pranaysanghai@gmail.com>
---
drivers/pci/setup-irq.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
index 7129494754dd..ed628771250b 100644
--- a/drivers/pci/setup-irq.c
+++ b/drivers/pci/setup-irq.c
@@ -28,12 +28,13 @@ void pci_assign_irq(struct pci_dev *dev)
return;
}
- /* If this device is not on the primary bus, we need to figure out
- which interrupt pin it will come in on. We know which slot it
- will come in on 'cos that slot is where the bridge is. Each
- time the interrupt line passes through a PCI-PCI bridge we must
- apply the swizzle function. */
-
+ /*
+ * If this device is not on the primary bus, we need to figure out
+ * which interrupt pin it will come in on. We know which slot it
+ * will come in on 'cos that slot is where the bridge is. Each
+ * time the interrupt line passes through a PCI-PCI bridge we must
+ * apply the swizzle function.
+ */
pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
/* Cope with illegal. */
if (pin > 4)
@@ -56,7 +57,9 @@ void pci_assign_irq(struct pci_dev *dev)
pci_dbg(dev, "assign IRQ: got %d\n", dev->irq);
- /* Always tell the device, so the driver knows what is
- the real IRQ to use; the device does not use it. */
+ /*
+ * Always tell the device, so the driver knows what is
+ * the real IRQ to use; the device does not use it.
+ */
pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
}
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/pci/setup-irq.c: Fix up comments.
2021-09-18 20:18 [PATCH] drivers/pci/setup-irq.c: Fix up comments Pranay Sanghai
@ 2021-09-28 18:47 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2021-09-28 18:47 UTC (permalink / raw)
To: Pranay Sanghai; +Cc: bhelgaas, linux-pci, linux-kernel
On Sat, Sep 18, 2021 at 01:18:02PM -0700, Pranay Sanghai wrote:
> Make comments follow multi-line comment conventions. No functional change intended.
>
> Signed-off-by: Pranay Sanghai <pranaysanghai@gmail.com>
Applied to pci/misc for v5.16, with the changes below, thanks!
- Updated subject line to follow the convention (see "git log
--oneline drivers/pci/setup-irq.c").
- Rewrapped commit log to fit in 75 columns so it fits in 80 when
"git log" indents it.
- Rewrapped comments to fill 80 columns like the rest of the file.
- Replaced "'cos" with "because".
> ---
> drivers/pci/setup-irq.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
> index 7129494754dd..ed628771250b 100644
> --- a/drivers/pci/setup-irq.c
> +++ b/drivers/pci/setup-irq.c
> @@ -28,12 +28,13 @@ void pci_assign_irq(struct pci_dev *dev)
> return;
> }
>
> - /* If this device is not on the primary bus, we need to figure out
> - which interrupt pin it will come in on. We know which slot it
> - will come in on 'cos that slot is where the bridge is. Each
> - time the interrupt line passes through a PCI-PCI bridge we must
> - apply the swizzle function. */
> -
> + /*
> + * If this device is not on the primary bus, we need to figure out
> + * which interrupt pin it will come in on. We know which slot it
> + * will come in on 'cos that slot is where the bridge is. Each
> + * time the interrupt line passes through a PCI-PCI bridge we must
> + * apply the swizzle function.
> + */
> pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
> /* Cope with illegal. */
> if (pin > 4)
> @@ -56,7 +57,9 @@ void pci_assign_irq(struct pci_dev *dev)
>
> pci_dbg(dev, "assign IRQ: got %d\n", dev->irq);
>
> - /* Always tell the device, so the driver knows what is
> - the real IRQ to use; the device does not use it. */
> + /*
> + * Always tell the device, so the driver knows what is
> + * the real IRQ to use; the device does not use it.
> + */
> pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
> }
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-28 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-18 20:18 [PATCH] drivers/pci/setup-irq.c: Fix up comments Pranay Sanghai
2021-09-28 18:47 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.