* [PATCH -next] drivers/auxdisplay//ks0108.c: remove superfluous header files from ks0108.c
@ 2021-09-28 19:06 Mianhan Liu
2021-10-21 22:09 ` Miguel Ojeda
0 siblings, 1 reply; 2+ messages in thread
From: Mianhan Liu @ 2021-09-28 19:06 UTC (permalink / raw)
To: Miguel Ojeda; +Cc: linux-kernel, Mianhan Liu
ks0108.c hasn't use any macro or function declared in linux/fs.h,
linux/io.h and linux/uaccess.h.
Thus, these files can be removed from ks0108.c safely without
affecting the compilation of the drivers/auxdisplay/ module
Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
---
drivers/auxdisplay/ks0108.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c
index e871b94a1..234f9dbe6 100644
--- a/drivers/auxdisplay/ks0108.c
+++ b/drivers/auxdisplay/ks0108.c
@@ -15,10 +15,7 @@
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/delay.h>
-#include <linux/fs.h>
-#include <linux/io.h>
#include <linux/parport.h>
-#include <linux/uaccess.h>
#include <linux/ks0108.h>
#define KS0108_NAME "ks0108"
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drivers/auxdisplay//ks0108.c: remove superfluous header files from ks0108.c
2021-09-28 19:06 [PATCH -next] drivers/auxdisplay//ks0108.c: remove superfluous header files from ks0108.c Mianhan Liu
@ 2021-10-21 22:09 ` Miguel Ojeda
0 siblings, 0 replies; 2+ messages in thread
From: Miguel Ojeda @ 2021-10-21 22:09 UTC (permalink / raw)
To: Mianhan Liu; +Cc: Miguel Ojeda, linux-kernel
On Tue, Sep 28, 2021 at 9:09 PM Mianhan Liu <liumh1@shanghaitech.edu.cn> wrote:
>
> ks0108.c hasn't use any macro or function declared in linux/fs.h,
> linux/io.h and linux/uaccess.h.
> Thus, these files can be removed from ks0108.c safely without
> affecting the compilation of the drivers/auxdisplay/ module
Applied, thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-21 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 19:06 [PATCH -next] drivers/auxdisplay//ks0108.c: remove superfluous header files from ks0108.c Mianhan Liu
2021-10-21 22:09 ` Miguel Ojeda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.